get_latest_image.sh: move to chromite |
|||
Issue descriptionthis is a small util script. i think we already have util code in chromite that does the same thing, so hopefully shouldn't be too hard. imo we should try to pull this out of the user's view so we can eventually make it a util lib only and not have a program for scripts to run at all. (1) implement chromite/scripts/get_latest_image.py that provides same functionality as src/scripts/get_latest_image (2) *don't* put a symlink under chromite/bin/ for it, just under chromite/scripts/ (2) update single caller in chromite to use new get_latest_image (3) delete get_latest_image.sh from src/scripts/
,
Oct 16
that is indeed the script i'm referring to i sent you a CL to fix the main docs. i wouldn't worry about the autotest docs ... those are slated for cleaning. that leaves the three normal repos: crostestutils, platform/dev/, and src/scripts/.
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/docs/+/b18f0689718e0fe2f03ab469eca0fca055137924 commit b18f0689718e0fe2f03ab469eca0fca055137924 Author: Mike Frysinger <vapier@chromium.org> Date: Tue Oct 16 17:44:40 2018 developer_guide: drop redundant get_latest_image.sh usage The mount_gpt_image.sh script provides a flag that does the same thing as passing in get_latest_image.sh, so use that directly. BUG= chromium:893754 Change-Id: I5e19ffd585abe44c2fd539a567663163b0c5ff6b Reviewed-on: https://chromium-review.googlesource.com/1281790 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/b18f0689718e0fe2f03ab469eca0fca055137924/developer_guide.md
,
Oct 17
,
Oct 17
thinking a bit more, i wonder if we even need this script anymore. it basically just looks up the target of the ${DEFAULT_BUILD_ROOT}/images/${FLAGS_board}/latest symlink. maybe we should replace all users with that direct symlink and delete the script out right ?
,
Oct 22
For the record, confirming we took the script removal route. A simple check to clarify the possible failure was added to a couple of scripts. The rest have existing checks that make the problem clear enough that it was not necessary.
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/dev-util/+/d0f9e178c4373429b58f0a448d0e2e8323d99f22 commit d0f9e178c4373429b58f0a448d0e2e8323d99f22 Author: Alex Klein <saklein@chromium.org> Date: Wed Oct 24 05:50:43 2018 get_latest_image: update usage BUG= chromium:893754 TEST=precq Change-Id: If39e41f7790cae7bc242cc2fff455f46215f4c97 Reviewed-on: https://chromium-review.googlesource.com/1292029 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/d0f9e178c4373429b58f0a448d0e2e8323d99f22/build_util.py [modify] https://crrev.com/d0f9e178c4373429b58f0a448d0e2e8323d99f22/host/image_to_live.sh
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/999443c6ea05f515623b155ef8b3e07223396685 commit 999443c6ea05f515623b155ef8b3e07223396685 Author: Alex Klein <saklein@chromium.org> Date: Wed Oct 24 05:50:48 2018 get_latest_image: update usage BUG= chromium:893754 TEST=precq Change-Id: I3b6ff6649a29446907b68c86d8bf20fdbca6ac69 Reviewed-on: https://chromium-review.googlesource.com/1291872 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/999443c6ea05f515623b155ef8b3e07223396685/mod_image_for_recovery.sh [modify] https://crrev.com/999443c6ea05f515623b155ef8b3e07223396685/bin/cros_start_vm [modify] https://crrev.com/999443c6ea05f515623b155ef8b3e07223396685/security_test_image [modify] https://crrev.com/999443c6ea05f515623b155ef8b3e07223396685/common.sh [modify] https://crrev.com/999443c6ea05f515623b155ef8b3e07223396685/image_to_vm.sh [modify] https://crrev.com/999443c6ea05f515623b155ef8b3e07223396685/mount_gpt_image.sh
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crostestutils/+/3622896059e4628d7128a1ba3fdfef2d140f2744 commit 3622896059e4628d7128a1ba3fdfef2d140f2744 Author: Alex Klein <saklein@chromium.org> Date: Wed Oct 24 20:03:05 2018 get_latest_image: update usage BUG= chromium:893754 TEST=precq Change-Id: I3eddd3a87380fc8475ba1c557a73e46b0f775017 Reviewed-on: https://chromium-review.googlesource.com/1292030 Commit-Ready: Alex Klein <saklein@chromium.org> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/3622896059e4628d7128a1ba3fdfef2d140f2744/cros_run_vm_test [modify] https://crrev.com/3622896059e4628d7128a1ba3fdfef2d140f2744/ctest/ctest_unittest.py [modify] https://crrev.com/3622896059e4628d7128a1ba3fdfef2d140f2744/ctest/ctest.py
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/e1f90ebfd28c6ff0bf3f42a50d84b2e76908580b commit e1f90ebfd28c6ff0bf3f42a50d84b2e76908580b Author: Alex Klein <saklein@chromium.org> Date: Thu Oct 25 03:07:18 2018 get_latest_image: delete BUG= chromium:893754 TEST=precq CQ-DEPEND=CL:1291872, CL:1292029, CL:1292030 Change-Id: I38ff425499a4a5cf01b51b57afdc5a32e5d55266 Reviewed-on: https://chromium-review.googlesource.com/1291873 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [delete] https://crrev.com/999443c6ea05f515623b155ef8b3e07223396685/get_latest_image.sh
,
Oct 25
|
|||
►
Sign in to add a comment |
|||
Comment 1 by saklein@chromium.org
, Oct 15