setup_board: move to chromite |
|||||||
Issue descriptionsetup_board should be mostly standalone, but it does have some hairy logic internally related to SDK bootstrapping (for the "host" board). the host board code can be tested locally, but will be slow as it bootstraps things (it's actually more like setup_board+build_packages). here's the steps: (1) implement chromite/scripts/setup_board.py that provides same functionality as src/scripts/setup_board (2) update any callers to use new chromite path (use cs/ to find callers) (3) delete setup_board from src/scripts/
,
Nov 8
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/8c78090087603efe16ffa651bd72a0bf367111a6 commit 8c78090087603efe16ffa651bd72a0bf367111a6 Author: Alex Klein <saklein@chromium.org> Date: Fri Nov 16 13:02:16 2018 setup_board: remove unused arguments Remove several arguments that are not used internally. The arguments also have no external usages. BUG=chromium:893748 TEST=cs to verify no usages, precq Change-Id: I48a9966b710445f23863ba91edf2c1c53ab45b0d Reviewed-on: https://chromium-review.googlesource.com/1326881 Commit-Ready: Alex Klein <saklein@chromium.org> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/8c78090087603efe16ffa651bd72a0bf367111a6/setup_board
,
Nov 27
,
Nov 30
,
Dec 5
Status update: Good: This was partially implemented ~3 years ago. Bad: This was partially implemented ~3 years ago. Having it partially implemented was a big productivity boost at the start, but now it's slowing me down quite a bit now. Thought I had it about done, but found some edge cases I missed, and some that weren't implemented in the existing code that I thought were. Also found more of it implemented that I had missed before, and need to cleanup the whole process. Switched to new ticket yesterday to get a break from this, will be coming back to it soon.
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/2998633e0423a85bf86650d5389aaf9e6d5b8dfb commit 2998633e0423a85bf86650d5389aaf9e6d5b8dfb Author: Alex Klein <saklein@chromium.org> Date: Fri Dec 14 03:27:52 2018 setup_board: Extract host board setup. setup_board has the logic for standard boards and the host board (the chroot). There is no real reason for the script to handle both cases, and separating them will clean up both cases as we port setup_board to chromite. BUG=chromium:893748 TEST=precq, tryjobs CQ-DEPEND=CL:1370545 Change-Id: Ic7ae2a1f9bf57036bca29ee8a892497ab42d1dbc Reviewed-on: https://chromium-review.googlesource.com/1370286 Commit-Ready: Alex Klein <saklein@chromium.org> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/2998633e0423a85bf86650d5389aaf9e6d5b8dfb/setup_board [add] https://crrev.com/2998633e0423a85bf86650d5389aaf9e6d5b8dfb/build_sdk_board
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/fe690480a83dabe587f11fe713eb3da83daf22de commit fe690480a83dabe587f11fe713eb3da83daf22de Author: Alex Klein <saklein@chromium.org> Date: Fri Dec 14 03:27:53 2018 chromiumos-sdk: Add BuildSDKBoardStage. setup_board had the logic for standard boards and the host board (the chroot). There is no real reason for the script to handle both cases, and so has been split into two separate scripts. This CL integrates the new script into the SDK Builder. BUG=chromium:893748 TEST=precq, tryjobs CQ-DEPEND=CL:1370286 Change-Id: I3fdff8631c4dfc91af7805e2fda75b39f05c32a1 Reviewed-on: https://chromium-review.googlesource.com/1370545 Commit-Ready: Alex Klein <saklein@chromium.org> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/fe690480a83dabe587f11fe713eb3da83daf22de/cbuildbot/stages/build_stages.py [modify] https://crrev.com/fe690480a83dabe587f11fe713eb3da83daf22de/cbuildbot/commands.py [modify] https://crrev.com/fe690480a83dabe587f11fe713eb3da83daf22de/cbuildbot/builders/sdk_builders.py
,
Jan 9
Can we close this? It's a P0. I'm a manual nag.
,
Jan 9
Is this truly P0? THe convention is P0 is product critical bug that we may need to work overtime to address. This feel more like a P1/P2 to me
,
Jan 9
I'd say this is probably a P2. It's a really nice to have but not a true blocker for PCQ, which are P1s. I do have some code I need to circle back to to finish this up, though, but it is close.
,
Jan 15
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/docs/+/720e27e347a1cbb2513be7f63f08828cf949d119 commit 720e27e347a1cbb2513be7f63f08828cf949d119 Author: Alex Klein <saklein@chromium.org> Date: Tue Jan 15 03:38:08 2019
,
Jan 15
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/85214faa489ff59c3ffefd6cbf084acb0fb34900 commit 85214faa489ff59c3ffefd6cbf084acb0fb34900 Author: Alex Klein <saklein@chromium.org> Date: Wed Jan 16 09:47:04 2019 build_tool: Fix amd64-host board building The amd64-host board is now built using the build_sdk_board command rather than being included as a special case in setup_board. BUG=chromium:893748 TEST=precq Change-Id: Idbc7721c4dbd29c46256f0f91289e3e3e6c311bc Reviewed-on: https://chromium-review.googlesource.com/1412681 Commit-Ready: Alex Klein <saklein@chromium.org> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/85214faa489ff59c3ffefd6cbf084acb0fb34900/build_tool.py
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/a28439cf723cf30f4d5cf6e857865285b4699932 commit a28439cf723cf30f4d5cf6e857865285b4699932 Author: Alex Klein <saklein@chromium.org> Date: Wed Jan 16 20:29:01 2019 setup_board & make_chroot: make.conf.user content Shift the responsibility of filling out the default make.conf.user content from setup_board to make_chroot. make.conf.user is a chroot file, its creation is out of place in setup_board. BUG=chromium:893748 TEST=precq Change-Id: Iaa6ea07af23d03dc2862bb0a6902d62434789a98 Reviewed-on: https://chromium-review.googlesource.com/1410046 Commit-Ready: Alex Klein <saklein@chromium.org> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/a28439cf723cf30f4d5cf6e857865285b4699932/setup_board [modify] https://crrev.com/a28439cf723cf30f4d5cf6e857865285b4699932/sdk_lib/make_chroot.sh
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/dd822b068613843489e5012fd329d0f6d94a9c27 commit dd822b068613843489e5012fd329d0f6d94a9c27 Author: Alex Klein <saklein@chromium.org> Date: Wed Jan 16 20:29:05 2019 project-termina: Update setup_board reference in README README references old bash version of setup_board. The inclusion of build_packages in the instructions makes it redundant anyway. Remove the setup_board reference. BUG=chromium:893748 TEST=precq Change-Id: I46c705f714392605dc16525bdcee4e7566e5ee25 Reviewed-on: https://chromium-review.googlesource.com/1407569 Commit-Ready: Alex Klein <saklein@chromium.org> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/dd822b068613843489e5012fd329d0f6d94a9c27/project-termina/README.md
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/63e8928a4e9f2afa67c2a47111da71a806b761e2 commit 63e8928a4e9f2afa67c2a47111da71a806b761e2 Author: Alex Klein <saklein@chromium.org> Date: Wed Jan 16 20:28:57 2019 profiles/license_groups: Documentation fix Update the comment with accept licenses instructions to point to the doc page with the full documentation. BUG=chromium:893748 TEST=None Change-Id: I9c935d49226c6897d235a8dd70a8997c58f672f7 Reviewed-on: https://chromium-review.googlesource.com/1413333 Commit-Ready: Alex Klein <saklein@chromium.org> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/63e8928a4e9f2afa67c2a47111da71a806b761e2/profiles/license_groups
,
Jan 19
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/7436495687e000eaf3decda0efbbad8c3835366c commit 7436495687e000eaf3decda0efbbad8c3835366c Author: Alex Klein <saklein@chromium.org> Date: Sat Jan 19 04:05:20 2019 cros_build_lib: sudo preserve-env option Add the option to preserve the environment for SudoRunCommand calls. BUG=chromium:893748 TEST=precq Change-Id: Ic58fb97c9498538d0e76110d0d2c09438a0f1575 Reviewed-on: https://chromium-review.googlesource.com/1416415 Commit-Ready: Alex Klein <saklein@chromium.org> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/7436495687e000eaf3decda0efbbad8c3835366c/lib/cros_build_lib.py |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 Deleted