Reduce AEC3 suppression when the nearend is strong. |
|||
Issue descriptionDuring doubletalk situations such that the nearend is strong compared to the residual echo, the requirements for the amount of echo removal to apply are lower than they otherwise are, as the residual echo is masked by the nearend. Currently, no consideration to this is taken in AEC3.
,
Oct 10
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/0d8c100e814f82c35d445918423a4fa2e482166e commit 0d8c100e814f82c35d445918423a4fa2e482166e Author: Per Åhgren <peah@webrtc.org> Date: Wed Oct 10 05:18:54 2018 AEC3: Decrease the suppression during the echo-only case This CL changes the tuning of the echo suppressor for the case when there is echo only. The resulting effect is a slight increase of transparency Bug: webrtc:9844 , chromium:893744 Change-Id: I5e6a867e0d03dc3a468a8f5cfa64103e001baae1 Reviewed-on: https://webrtc-review.googlesource.com/c/104760 Commit-Queue: Per Åhgren <peah@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25075} [modify] https://crrev.com/0d8c100e814f82c35d445918423a4fa2e482166e/api/audio/echo_canceller3_config.h [modify] https://crrev.com/0d8c100e814f82c35d445918423a4fa2e482166e/modules/audio_processing/aec3/echo_canceller3.cc
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/004d2ec55e47a7d1331a3b363df2c56a9c6eb343 commit 004d2ec55e47a7d1331a3b363df2c56a9c6eb343 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Oct 10 07:25:08 2018 Roll src/third_party/webrtc 3a3f0274edd9..0d8c100e814f (5 commits) https://webrtc.googlesource.com/src.git/+log/3a3f0274edd9..0d8c100e814f git log 3a3f0274edd9..0d8c100e814f --date=short --no-merges --format='%ad %ae %s' 2018-10-10 peah@webrtc.org AEC3: Decrease the suppression during the echo-only case 2018-10-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision cfe6e706d0..476ae6d661 (598018:598136) 2018-10-10 steveanton@webrtc.org Remove container typedefs from RelayServer 2018-10-09 steveanton@webrtc.org Use unique_ptr in port_unittest 2018-10-09 peah@webrtc.org AEC3: Utilize dominant nearend functionality to increase transparency Created with: gclient setdep -r src/third_party/webrtc@0d8c100e814f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG= chromium:893744 ,chromium:None,chromium:893744 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icca5d743fed3db50ffc7442d7a8e0be74ec246f7 Reviewed-on: https://chromium-review.googlesource.com/c/1272263 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#598241} [modify] https://crrev.com/004d2ec55e47a7d1331a3b363df2c56a9c6eb343/DEPS
,
Oct 12
Is this finished?
,
Oct 18
Assigning these all to you, since it looks like you reported them and they're about AEC3. Untriaged needs to get triaged. :)
,
Oct 24
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Oct 9