They keychain reauthorization code is no longer needed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f0c72bc0694565eab6734f7b5be04a9d8ef6db9 commit 8f0c72bc0694565eab6734f7b5be04a9d8ef6db9 Author: Greg Kerr <kerrnel@chromium.org> Date: Fri Oct 12 20:47:04 2018 macOS: Remove keychain reauthorizing logic. The keychain was re-authorized to support Chrome's new signing certificate 18+ months ago. At this point, users who haven't re-launch Chrome in 18 months are unlikely to do so, or need the keychain. This removes the re-authorization code. Bug: 893729 Change-Id: I75b5a40407d196adfa5c31996024b9bb278221a1 Reviewed-on: https://chromium-review.googlesource.com/c/1271935 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599341} [modify] https://crrev.com/8f0c72bc0694565eab6734f7b5be04a9d8ef6db9/chrome/BUILD.gn [modify] https://crrev.com/8f0c72bc0694565eab6734f7b5be04a9d8ef6db9/chrome/app/framework.order [modify] https://crrev.com/8f0c72bc0694565eab6734f7b5be04a9d8ef6db9/chrome/browser/BUILD.gn [modify] https://crrev.com/8f0c72bc0694565eab6734f7b5be04a9d8ef6db9/chrome/browser/chrome_browser_main_mac.mm [delete] https://crrev.com/87da10ae482f4ee7efea00cb0e25ed51af997df6/chrome/browser/mac/keychain_reauthorize.h [delete] https://crrev.com/87da10ae482f4ee7efea00cb0e25ed51af997df6/chrome/browser/mac/keychain_reauthorize.mm [modify] https://crrev.com/8f0c72bc0694565eab6734f7b5be04a9d8ef6db9/chrome/installer/mac/BUILD.gn [modify] https://crrev.com/8f0c72bc0694565eab6734f7b5be04a9d8ef6db9/chrome/installer/mac/dmgdiffer.sh [modify] https://crrev.com/8f0c72bc0694565eab6734f7b5be04a9d8ef6db9/chrome/installer/mac/sign_app.sh.in [modify] https://crrev.com/8f0c72bc0694565eab6734f7b5be04a9d8ef6db9/chrome/installer/mac/variables.sh
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3211c2f58f5d7aafcca5ab597b8a732654d85f23 commit 3211c2f58f5d7aafcca5ab597b8a732654d85f23 Author: Greg Kerr <kerrnel@chromium.org> Date: Mon Oct 15 18:44:01 2018 Revert "macOS: Remove keychain reauthorizing logic." This reverts commit 8f0c72bc0694565eab6734f7b5be04a9d8ef6db9. Reason for revert: Blocking canary signing. Original change's description: > macOS: Remove keychain reauthorizing logic. > > The keychain was re-authorized to support Chrome's new signing > certificate 18+ months ago. At this point, users who haven't re-launch > Chrome in 18 months are unlikely to do so, or need the keychain. This > removes the re-authorization code. > > Bug: 893729 > Change-Id: I75b5a40407d196adfa5c31996024b9bb278221a1 > Reviewed-on: https://chromium-review.googlesource.com/c/1271935 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599341} TBR=avi@chromium.org,kerrnel@chromium.org,mark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 893729 , 895202 Change-Id: I3a82d2485307e1c3a0702fc486efbe5d1e7a8a7d Reviewed-on: https://chromium-review.googlesource.com/c/1280855 Reviewed-by: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599695} [modify] https://crrev.com/3211c2f58f5d7aafcca5ab597b8a732654d85f23/chrome/BUILD.gn [modify] https://crrev.com/3211c2f58f5d7aafcca5ab597b8a732654d85f23/chrome/app/framework.order [modify] https://crrev.com/3211c2f58f5d7aafcca5ab597b8a732654d85f23/chrome/browser/BUILD.gn [modify] https://crrev.com/3211c2f58f5d7aafcca5ab597b8a732654d85f23/chrome/browser/chrome_browser_main_mac.mm [add] https://crrev.com/3211c2f58f5d7aafcca5ab597b8a732654d85f23/chrome/browser/mac/keychain_reauthorize.h [add] https://crrev.com/3211c2f58f5d7aafcca5ab597b8a732654d85f23/chrome/browser/mac/keychain_reauthorize.mm [modify] https://crrev.com/3211c2f58f5d7aafcca5ab597b8a732654d85f23/chrome/installer/mac/BUILD.gn [modify] https://crrev.com/3211c2f58f5d7aafcca5ab597b8a732654d85f23/chrome/installer/mac/dmgdiffer.sh [modify] https://crrev.com/3211c2f58f5d7aafcca5ab597b8a732654d85f23/chrome/installer/mac/sign_app.sh.in [modify] https://crrev.com/3211c2f58f5d7aafcca5ab597b8a732654d85f23/chrome/installer/mac/variables.sh
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f25c18a750b764193a5327b4d652c4dd5c95417 commit 8f25c18a750b764193a5327b4d652c4dd5c95417 Author: Greg Kerr <kerrnel@chromium.org> Date: Mon Oct 15 18:48:50 2018 Revert "macOS: Remove keychain reauthorizing logic." This reverts commit 8f0c72bc0694565eab6734f7b5be04a9d8ef6db9. Reason for revert: Blocking canary signing. Original change's description: > macOS: Remove keychain reauthorizing logic. > > The keychain was re-authorized to support Chrome's new signing > certificate 18+ months ago. At this point, users who haven't re-launch > Chrome in 18 months are unlikely to do so, or need the keychain. This > removes the re-authorization code. > > Bug: 893729 > Change-Id: I75b5a40407d196adfa5c31996024b9bb278221a1 > Reviewed-on: https://chromium-review.googlesource.com/c/1271935 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599341} TBR=avi@chromium.org,kerrnel@chromium.org,mark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 893729 , 895202 Change-Id: I3a82d2485307e1c3a0702fc486efbe5d1e7a8a7d Reviewed-on: https://chromium-review.googlesource.com/c/1280855 Reviewed-by: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599695}(cherry picked from commit 3211c2f58f5d7aafcca5ab597b8a732654d85f23) Reviewed-on: https://chromium-review.googlesource.com/c/1281168 Cr-Commit-Position: refs/branch-heads/3581@{#5} Cr-Branched-From: 53e727daf255777aa6ad6feb3d8188ec70db52e0-refs/heads/master@{#599547} [modify] https://crrev.com/8f25c18a750b764193a5327b4d652c4dd5c95417/chrome/BUILD.gn [modify] https://crrev.com/8f25c18a750b764193a5327b4d652c4dd5c95417/chrome/app/framework.order [modify] https://crrev.com/8f25c18a750b764193a5327b4d652c4dd5c95417/chrome/browser/BUILD.gn [modify] https://crrev.com/8f25c18a750b764193a5327b4d652c4dd5c95417/chrome/browser/chrome_browser_main_mac.mm [add] https://crrev.com/8f25c18a750b764193a5327b4d652c4dd5c95417/chrome/browser/mac/keychain_reauthorize.h [add] https://crrev.com/8f25c18a750b764193a5327b4d652c4dd5c95417/chrome/browser/mac/keychain_reauthorize.mm [modify] https://crrev.com/8f25c18a750b764193a5327b4d652c4dd5c95417/chrome/installer/mac/BUILD.gn [modify] https://crrev.com/8f25c18a750b764193a5327b4d652c4dd5c95417/chrome/installer/mac/dmgdiffer.sh [modify] https://crrev.com/8f25c18a750b764193a5327b4d652c4dd5c95417/chrome/installer/mac/sign_app.sh.in [modify] https://crrev.com/8f25c18a750b764193a5327b4d652c4dd5c95417/chrome/installer/mac/variables.sh
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c29863d6049c40eef65b411c9d8ba0d0d4c4285 commit 2c29863d6049c40eef65b411c9d8ba0d0d4c4285 Author: Greg Kerr <kerrnel@chromium.org> Date: Thu Oct 18 20:10:29 2018 macOS: Remove keychain reauthorizing logic. The keychain was re-authorized to support Chrome's new signing certificate 18+ months ago. At this point, users who haven't re-launch Chrome in 18 months are unlikely to do so, or need the keychain. This removes the re-authorization code. Bug: 893729 CQ-Depend: CL:*698113 Change-Id: I9ba74e11861baafd36dd92b5cd2be2a2d46e6fa6 Reviewed-on: https://chromium-review.googlesource.com/c/1282028 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#600881} [modify] https://crrev.com/2c29863d6049c40eef65b411c9d8ba0d0d4c4285/chrome/BUILD.gn [modify] https://crrev.com/2c29863d6049c40eef65b411c9d8ba0d0d4c4285/chrome/app/framework.order [modify] https://crrev.com/2c29863d6049c40eef65b411c9d8ba0d0d4c4285/chrome/browser/BUILD.gn [modify] https://crrev.com/2c29863d6049c40eef65b411c9d8ba0d0d4c4285/chrome/browser/chrome_browser_main_mac.mm [delete] https://crrev.com/2fac591598af1a5769da0e8096f747a9e118febb/chrome/browser/mac/keychain_reauthorize.h [delete] https://crrev.com/2fac591598af1a5769da0e8096f747a9e118febb/chrome/browser/mac/keychain_reauthorize.mm [modify] https://crrev.com/2c29863d6049c40eef65b411c9d8ba0d0d4c4285/chrome/installer/mac/BUILD.gn [modify] https://crrev.com/2c29863d6049c40eef65b411c9d8ba0d0d4c4285/chrome/installer/mac/dmgdiffer.sh [modify] https://crrev.com/2c29863d6049c40eef65b411c9d8ba0d0d4c4285/chrome/installer/mac/sign_app.sh.in [modify] https://crrev.com/2c29863d6049c40eef65b411c9d8ba0d0d4c4285/chrome/installer/mac/variables.sh
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/src-internal.git/+/245ff8c6a02004001c99dad678238389143c0b42 commit 245ff8c6a02004001c99dad678238389143c0b42 Author: Greg Kerr <kerrnel@google.com> Date: Fri Oct 19 19:07:13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2eb4fd992ed42d148f69e5bf45e4b3e84038c9a commit e2eb4fd992ed42d148f69e5bf45e4b3e84038c9a Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Oct 19 20:26:48 2018 Roll src-internal 0f44307feaae..245ff8c6a020 (4 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0f44307feaae..245ff8c6a020 Created with: gclient setdep -r src-internal@245ff8c6a020 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:893729 ,chromium:895202 TBR=mmoss@chromium.org Change-Id: I9ac7b67e2cb019cd823c8ec2fabed1023f808a72 Reviewed-on: https://chromium-review.googlesource.com/c/1292229 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601279} [modify] https://crrev.com/e2eb4fd992ed42d148f69e5bf45e4b3e84038c9a/DEPS
Comment 1 by bugdroid1@chromium.org
, Oct 12