Run end to end Chrome Flywheel tests with network servicification enabled |
|
Issue descriptionWe need to figure out the test plan for data saver when network servicification is enabled. One low hanging fruit is to run all end to end webdriver tests with network servicification and DRP enabled.
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3ea2ae8e4429102857f29cc22ca1b4f304d8f96 commit e3ea2ae8e4429102857f29cc22ca1b4f304d8f96 Author: rajendrant <rajendrant@chromium.org> Date: Tue Nov 06 03:11:32 2018 Remove the deprecated session, credential in chrome-proxy The fields ps, sid in chrome-proxy header are deprecated. So removing them. https://g3doc.corp.google.com/wireless/speed/flywheel/g3doc/protocol/syntax_proxy.md#requests Bug: 893728 Change-Id: I752938b6defd6e55405bd40151341ab50486c014 Reviewed-on: https://chromium-review.googlesource.com/c/1316677 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#605582} [modify] https://crrev.com/e3ea2ae8e4429102857f29cc22ca1b4f304d8f96/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc [modify] https://crrev.com/e3ea2ae8e4429102857f29cc22ca1b4f304d8f96/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc [modify] https://crrev.com/e3ea2ae8e4429102857f29cc22ca1b4f304d8f96/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.h [modify] https://crrev.com/e3ea2ae8e4429102857f29cc22ca1b4f304d8f96/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc [modify] https://crrev.com/e3ea2ae8e4429102857f29cc22ca1b4f304d8f96/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc [modify] https://crrev.com/e3ea2ae8e4429102857f29cc22ca1b4f304d8f96/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03829be3bc0c02e4a2f834ce445061b01669556b commit 03829be3bc0c02e4a2f834ce445061b01669556b Author: rajendrant <rajendrant@chromium.org> Date: Tue Nov 06 09:59:27 2018 Merge proxy request headers correctly if header already exists This CL fixes the video.testCheckVideoHasViaHeader webdriver test. Chrome-Proxy header gets set to 'frfr' for first video requests (in resource_multibuffer_data_provider.cc). So the proxy delegate should merge the headers considering existing values. If a header already exists they should be combined with using ', '. Bug: 893728 Change-Id: Icb1eb84ef9af149b6e34e5792ca4a7d079efebed Reviewed-on: https://chromium-review.googlesource.com/c/1316096 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#605640} [modify] https://crrev.com/03829be3bc0c02e4a2f834ce445061b01669556b/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle.cc [modify] https://crrev.com/03829be3bc0c02e4a2f834ce445061b01669556b/services/network/network_context_unittest.cc [modify] https://crrev.com/03829be3bc0c02e4a2f834ce445061b01669556b/services/network/network_service_proxy_delegate.cc
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8cb53244972ebc8aa8ed24aa0f270db490ad2e4 commit b8cb53244972ebc8aa8ed24aa0f270db490ad2e4 Author: rajendrant <rajendrant@chromium.org> Date: Tue Nov 06 22:09:50 2018 Populate page ID for chrome-proxy separately with NetworkService Chrome-proxy is piecemeal constructed when NetworkService is enabled. For example, the secure hash is added from the post_cache_headers in NetworkContext. 'frfr' is added for first media requests from the blink layer. This CL adds page ID for mainframe requests via post cache headers in URLLoader. Bug: 893728 Change-Id: I9110896ed7242e424b02e2c125a080dd853d6325 Reviewed-on: https://chromium-review.googlesource.com/c/1318431 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#605841} [modify] https://crrev.com/b8cb53244972ebc8aa8ed24aa0f270db490ad2e4/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/b8cb53244972ebc8aa8ed24aa0f270db490ad2e4/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc [modify] https://crrev.com/b8cb53244972ebc8aa8ed24aa0f270db490ad2e4/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc [modify] https://crrev.com/b8cb53244972ebc8aa8ed24aa0f270db490ad2e4/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.h
,
Nov 6
Following are the tests that fail after the above fixes. smoke.py testCheckPageWithHoldback proxy_connection.py testTCPReset bypass.py testMissingViaHeaderNoBypassExperiment lite_page.py testLitePageFallbackViaPagePolicies testPreviewNotProvidedForFastConnection testPreviewProvidedForSlowConnection testInteractiveCASPR lofi.py testLoFiCacheBypass testLoFiFastConnection testLoFiOnSlowConnection
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd8d31b4ec1756d2ef642b1d1f4e0bd82d4fb356 commit cd8d31b4ec1756d2ef642b1d1f4e0bd82d4fb356 Author: rajendrant <rajendrant@chromium.org> Date: Fri Nov 09 00:36:26 2018 Copy previews state to net::ResourceRequest from common params PreviewsState is used in DataReductionProxyURLLoaderThrottle to set some chrome-proxy specific headers to serve previews. Bug: 893728 Change-Id: Ie54f174bb1ba2ff4d77f725c0e64450f8d2aad0c Reviewed-on: https://chromium-review.googlesource.com/c/1327568 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#606661} [modify] https://crrev.com/cd8d31b4ec1756d2ef642b1d1f4e0bd82d4fb356/content/browser/loader/navigation_url_loader_impl.cc
,
Nov 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/033a2fe465fed2c6041d8f026c048d10fbcb698a commit 033a2fe465fed2c6041d8f026c048d10fbcb698a Author: rajendrant <rajendrant@chromium.org> Date: Sat Nov 10 05:01:38 2018 Show Previews UI at commit for Client LoFi with network-serivce Client LoFi infobar will be shown when lofi response is received, and android omnibox UI will be shown at navigation commit. This CL changes the behavior to show the infobar UI as well at navigation commit, when NetworkService is enabled, since the response headers of subresources would not be received in the browser process. Bug: 893728 Change-Id: I66122590e80974449528635892b1c720efe04450 Reviewed-on: https://chromium-review.googlesource.com/c/1327556 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#607102} [modify] https://crrev.com/033a2fe465fed2c6041d8f026c048d10fbcb698a/chrome/browser/previews/previews_ui_tab_helper.cc
,
Jan 2
Refreshed during triage - is there more to do here?
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d6da1bbe1e0f380537387516e52c0d833c35afc commit 5d6da1bbe1e0f380537387516e52c0d833c35afc Author: rajendrant <rajendrant@chromium.org> Date: Wed Jan 09 19:32:09 2019 Remove test that checks if 4xx without via header is bypassed Bug: 893728 Change-Id: Ie06806e841ccb1cd67f164832d5ed9ca3987f236 Reviewed-on: https://chromium-review.googlesource.com/c/1402349 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#621269} [modify] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/tools/chrome_proxy/webdriver/bypass.py
,
Jan 16
(6 days ago)
Some of the remaining tests are failing due to the following histograms missing. DataReductionProxy.ProxySchemeUsed DataReductionProxy.BypassedBytes.MissingViaHeaderOther Previews.InfoBarAction.LitePage Previews.InfoBarAction.LoFi The previews bit is likely not handled while recording these histograms.
,
Jan 16
(6 days ago)
Note that Previews.InfoBarAction.* histograms are going away (http://shortn/_03D1SScOWB has details). So, it might be useful to split off the bug related to Previews.InfoBarAction.* histograms. Robert might be the best person to work on that. |
|
►
Sign in to add a comment |
|
Comment 1 by rajendrant@chromium.org
, Nov 2