New issue
Advanced search Search tips

Issue 893711 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 9
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Kernel-4.19: boards 'scarlet' and 'elm' don't build

Project Member Reported by zwisler@google.com, Oct 9

Issue description

When trying to build linux-next at commit 088c04f5bc33 ("CHROMIUM: Normalize defconfig"), both scarlet and elm fail with the following errors:

chromeos-kernel-next-4.19_rc6-r13: ../../../../../tmp/portage/sys-kernel/chromeos-kernel-next-4.19_rc6-r13/work/chromeos-kernel-next-4.19_rc6/drivers/md/dm-verity-chromeos.c: In function 'chromeos_invalidate_kernel_nand':
chromeos-kernel-next-4.19_rc6-r13: ../../../../../tmp/portage/sys-kernel/chromeos-kernel-next-4.19_rc6-r13/work/chromeos-kernel-next-4.19_rc6/drivers/md/dm-verity-chromeos.c:282:13: error: 'struct erase_info' has no member named 'mtd'
chromeos-kernel-next-4.19_rc6-r13:   erase.instr.mtd = dev;
chromeos-kernel-next-4.19_rc6-r13:              ^
chromeos-kernel-next-4.19_rc6-r13: ../../../../../tmp/portage/sys-kernel/chromeos-kernel-next-4.19_rc6-r13/work/chromeos-kernel-next-4.19_rc6/drivers/md/dm-verity-chromeos.c:285:13: error: 'struct erase_info' has no member named 'callback'
chromeos-kernel-next-4.19_rc6-r13:   erase.instr.callback = complete_erase;
chromeos-kernel-next-4.19_rc6-r13:              ^
chromeos-kernel-next-4.19_rc6-r13: ../../../../../tmp/portage/sys-kernel/chromeos-kernel-next-4.19_rc6-r13/work/chromeos-kernel-next-4.19_rc6/drivers/md/dm-verity-chromeos.c:291:17: error: 'struct erase_info' has no member named 'state'
chromeos-kernel-next-4.19_rc6-r13:   if (erase.instr.state == MTD_ERASE_FAILED) {
chromeos-kernel-next-4.19_rc6-r13:                  ^
chromeos-kernel-next-4.19_rc6-r13: ../../../../../tmp/portage/sys-kernel/chromeos-kernel-next-4.19_rc6-r13/work/chromeos-kernel-next-4.19_rc6/drivers/md/dm-verity-chromeos.c:291:27: error: 'MTD_ERASE_FAILED' undeclared (first use in this function)
chromeos-kernel-next-4.19_rc6-r13:   if (erase.instr.state == MTD_ERASE_FAILED) {
chromeos-kernel-next-4.19_rc6-r13:  
 
Cc: -groeck@chromium.org zwisler@chromium.org
Owner: groeck@chromium.org
Status: Started (was: Untriaged)
This is actually fatal; mtd_erase() changed from asynchronous to cynchronous, and the use of #ifdef CONFIG_MTD was wrong.

s/cynchronous/synchronous/
Status: Fixed (was: Started)
Should be fixed with chromeos-4.19-merge-181009

Confirmed that scarlet builds for me with chromeos-4.19-merge-181009.

Sign in to add a comment