New issue
Advanced search Search tips

Issue 893695 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 15
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Chrome OS does not need CONFIG_EFI, remove it

Project Member Reported by zwisler@google.com, Oct 9

Issue description

Chromebooks do not need CONFIG_EFI defined in their kernel config, as they do not use EFI.  Remove that from the x86_64, i386, arm64 and mediatek kernel configs to save on compilation time and disk space.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e742fee15a89bc9c2cc8e4fdb99d2c3d9538028

commit 9e742fee15a89bc9c2cc8e4fdb99d2c3d9538028
Author: Ioana Pandele <ioanap@chromium.org>
Date: Thu Oct 11 19:07:54 2018

[Android] Hide the KA when tapping outside of page

The KA relies on the FocusedNodeChanged event that it receives as a
RenderFrameObserver. This event however is not triggered when the focus
moves outside the frame (e.g. on the omnibox). In order to detect such
a focus change we use DidEndTextFieldEditing to hide the KA, same as
for the autofill popup.
When the user taps back onto the field DidCompleteFocusChangeInFrame is
called, which leads to the accessory being shown again.

TBR for 1 line in components/autofill/content/renderer/autofill_agent.cc
TBR=dvadym@chromium.org

Bug:  893695 
Change-Id: I76a66ce43fad0a74c0abbc10c42d8916fd7e891a
Reviewed-on: https://chromium-review.googlesource.com/c/1268246
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598878}
[modify] https://crrev.com/9e742fee15a89bc9c2cc8e4fdb99d2c3d9538028/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/9e742fee15a89bc9c2cc8e4fdb99d2c3d9538028/components/autofill/content/renderer/autofill_agent.cc
[modify] https://crrev.com/9e742fee15a89bc9c2cc8e4fdb99d2c3d9538028/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/9e742fee15a89bc9c2cc8e4fdb99d2c3d9538028/components/autofill/content/renderer/password_autofill_agent.h

Status: WontFix (was: Untriaged)
On second thought I'm not sure this change is a good idea. According to:

https://www.chromium.org/chromium-os/chromiumos-design-docs/disk-format

we go out of our way to make sure that we can boot on an EFI system, and though this doesn't happen on chromebooks this may happen in other situations (virtualized Chrome OS instances, early proto hardware, etc.)

Abandoning for now.

Sign in to add a comment