New issue
Advanced search Search tips

Issue 893690 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Crostini: After updating VSCode, the docked icon is not used any more and launching vscode create a "penguin icon" instead

Reported by toms...@gmail.com, Oct 9

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 11021.34.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.41 Safari/537.36
Platform: 11021.34.0 (Official Build) beta-channel eve

Steps to reproduce the problem:
1. Launch termina VM/crostini on pixelbook
2. download latest version of vscode
3. install vscode through crostini .deb installer (apt-get upgrade had the same issue)

What is the expected behavior?
When clicking on the pinned vscode taskbar icon, then vscode launch, but then a 'penguin' icon appear in the taskbar instead of the vscode icon being used.

What went wrong?
VSCode takbar icon not updated/recognized any more after latest vscode update ( 1.28.0 )

Did this work before? Yes Same ChromeOS version

Chrome version: 70.0.3538.41  Channel: beta
OS Version: 11021.34.0
Flash Version: 31.0.0.122
 
Components: OS>Systems>Containers
Labels: Proj-Containers
Owner: jkardatzke@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: jkardatzke@chromium.org
Owner: timzheng@chromium.org
I reproduced this as well...
I can reproduce the same thing

Chrome OS version: Version 70.0.3538.41 (Official Build) beta (64-bit)

Note that if I type on the search key, then type 'vscode' the correct icon appears in the launcher
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b15ad0db9fa426f52d231197e90cf5311b35567

commit 1b15ad0db9fa426f52d231197e90cf5311b35567
Author: Tim Zheng <timzheng@google.com>
Date: Thu Oct 11 23:09:11 2018

Skip no display desktop files for wmclass match.

This CL skips no display desktop files when trying to find an app ID
with wmclass. Some apps create some no display entries and they cause
the current logic to unable to uniquely identify an app entry from the
registry.

BUG= chromium:893690 
TEST=Manually verified on an eve device.

Change-Id: I88f24f87d9af125032ea82fd21f8a7b97f3ca998
Reviewed-on: https://chromium-review.googlesource.com/c/1277679
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599002}
[modify] https://crrev.com/1b15ad0db9fa426f52d231197e90cf5311b35567/chrome/browser/chromeos/crostini/crostini_registry_service.cc

Status: Fixed (was: Started)
The issue seems to be still persistent at 70.0.3538.76, please verify once again.
The fix was not merged into 70.
Do you know in which version the fix will be rolled out?
It's in 71.
Thank you for the update!

Sign in to add a comment