EDIT button should be disabled when “No Search Results found” text is seen in Bookmarks |
||||||||||
Issue descriptionApp Version: 71.0.3573.0 Canary iOS Version: 10.3.3,11.4.1, 12 Device: iPhone,ipad Pre condition : 1- Have Few Bookmarks saved Steps to reproduce: 1. Launch Chrome 2. Tap on Menu > Tap on Bookmarks 3. Perform any Invalid search(Say : abc123) 4. Tap on Edit button in “No Search Results found” Observed results: Edit button is enabled. Expected results: Edit Button should be disabled when “No Search Results found” text is seen. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on the current stable channel build : NA, New UI in M71 Bug reproducible on the current beta channel build : NA, New UI in M71 Link to video/image: https://drive.google.com/file/d/15r1GUn9rf-z2PGGkKVtLWbp8_23NKCLx/view?usp=sharing
,
Oct 10
djean@ PTAL since its Bookmarks search related
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a168223668906d8682d1bb309b54d408387d1b8 commit 1a168223668906d8682d1bb309b54d408387d1b8 Author: David Jean <djean@google.com> Date: Mon Oct 15 14:30:48 2018 [ios] Fix bookmarks Edit button / Animation bugs - Fixed Edit button to be disabled when seaching and no results. - Fixed problem with background during search. - Fixed clunky animation by closing search controller first. Bug: 893559, 893687 ,894031 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I6846006abf82d2e6ef1b6a9d783f6824d27df076 Reviewed-on: https://chromium-review.googlesource.com/c/1276646 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#599634} [modify] https://crrev.com/1a168223668906d8682d1bb309b54d408387d1b8/ios/chrome/browser/ui/bookmarks/bookmark_home_mediator.mm [modify] https://crrev.com/1a168223668906d8682d1bb309b54d408387d1b8/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm [modify] https://crrev.com/1a168223668906d8682d1bb309b54d408387d1b8/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
,
Oct 16
,
Oct 16
[Auto-generated comment by a script] We noticed that this issue is targeted for M-71; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-71 label, otherwise remove Merge-TBD label. Thanks.
,
Oct 16
,
Oct 18
,
Oct 19
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 19
Verified on 72.0.3584.0 Canary, iPhoneX iOS 11.4.1, iPhone7 iOS 12.1 beta Looks good.
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ea7d956c57710ab3aa5ca55848b0288a5719303 commit 5ea7d956c57710ab3aa5ca55848b0288a5719303 Author: David Jean <djean@google.com> Date: Mon Oct 22 07:03:14 2018 [ios] Fix bookmarks Edit button / Animation bugs - Fixed Edit button to be disabled when seaching and no results. - Fixed problem with background during search. - Fixed clunky animation by closing search controller first. Bug: 893559, 893687 ,894031 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I6846006abf82d2e6ef1b6a9d783f6824d27df076 Reviewed-on: https://chromium-review.googlesource.com/c/1276646 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599634}(cherry picked from commit 1a168223668906d8682d1bb309b54d408387d1b8) Reviewed-on: https://chromium-review.googlesource.com/c/1292875 Cr-Commit-Position: refs/branch-heads/3578@{#201} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/5ea7d956c57710ab3aa5ca55848b0288a5719303/ios/chrome/browser/ui/bookmarks/bookmark_home_mediator.mm [modify] https://crrev.com/5ea7d956c57710ab3aa5ca55848b0288a5719303/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm [modify] https://crrev.com/5ea7d956c57710ab3aa5ca55848b0288a5719303/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ea7d956c57710ab3aa5ca55848b0288a5719303 Commit: 5ea7d956c57710ab3aa5ca55848b0288a5719303 Author: djean@google.com Commiter: gambard@chromium.org Date: 2018-10-22 07:03:14 +0000 UTC [ios] Fix bookmarks Edit button / Animation bugs - Fixed Edit button to be disabled when seaching and no results. - Fixed problem with background during search. - Fixed clunky animation by closing search controller first. Bug: 893559, 893687 ,894031 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I6846006abf82d2e6ef1b6a9d783f6824d27df076 Reviewed-on: https://chromium-review.googlesource.com/c/1276646 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599634}(cherry picked from commit 1a168223668906d8682d1bb309b54d408387d1b8) Reviewed-on: https://chromium-review.googlesource.com/c/1292875 Cr-Commit-Position: refs/branch-heads/3578@{#201} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 24
Verified on chrome beta version 71.0.3578.21 on iPhone 8 plus with iOS 11.4.1, 12.1 beta 5. Edit button is in disabled state. Looks good. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by linds...@chromium.org
, Oct 10Owner: sczs@chromium.org
Status: Assigned (was: Untriaged)