New issue
Advanced search Search tips

Issue 893685 link

Starred by 1 user
Status: Fixed
Owner:
carlosil@chromium.org
Closed: Oct 16
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug

Blocked on:
issue 893684
Blocking:
issue 893647



Sign in to add a comment

Implement Metrics for Mixed Content Autoupgrade Experiment

Project Member Reported by carlosil@chromium.org, Oct 9 
We should log UMA metrics for Websocket and Form submission autoupgrades, and UKM for subresource upgrades, they should log failure/success, and in the fallback case, delay.

Comment 1 by carlosil@chromium.org, Oct 11

Components: Blink>SecurityFeature

Comment 2 by carlosil@chromium.org, Oct 11

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c750a81e9fdfc847c674dd74f8f4795760bb1931

commit c750a81e9fdfc847c674dd74f8f4795760bb1931
Author: Carlos IL <carlosil@chromium.org>
Date: Mon Oct 15 20:54:00 2018

Added metrics for autoupgraded resources and websockets.

Added histograms that log start/failure/response code for autoupgraded
resources, and start/failure/connection success for autoupgraded
websockets. Metrics for form submissions will come in a later CL.

Bug:  893685 
Change-Id: I7715a61c2f7a7582d5b317c1fa8c8fa60c1408a2
Reviewed-on: https://chromium-review.googlesource.com/c/1275295
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599743}
[modify] https://crrev.com/c750a81e9fdfc847c674dd74f8f4795760bb1931/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/c750a81e9fdfc847c674dd74f8f4795760bb1931/third_party/blink/renderer/core/loader/mixed_content_checker.cc
[modify] https://crrev.com/c750a81e9fdfc847c674dd74f8f4795760bb1931/third_party/blink/renderer/core/loader/mixed_content_checker.h
[modify] https://crrev.com/c750a81e9fdfc847c674dd74f8f4795760bb1931/third_party/blink/renderer/modules/websockets/dom_websocket.cc
[modify] https://crrev.com/c750a81e9fdfc847c674dd74f8f4795760bb1931/third_party/blink/renderer/modules/websockets/dom_websocket.h
[modify] https://crrev.com/c750a81e9fdfc847c674dd74f8f4795760bb1931/third_party/blink/renderer/platform/DEPS
[modify] https://crrev.com/c750a81e9fdfc847c674dd74f8f4795760bb1931/third_party/blink/renderer/platform/loader/BUILD.gn
[modify] https://crrev.com/c750a81e9fdfc847c674dd74f8f4795760bb1931/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[add] https://crrev.com/c750a81e9fdfc847c674dd74f8f4795760bb1931/third_party/blink/renderer/platform/loader/mixed_content_autoupgrade_status.h
[modify] https://crrev.com/c750a81e9fdfc847c674dd74f8f4795760bb1931/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/c750a81e9fdfc847c674dd74f8f4795760bb1931/tools/metrics/histograms/histograms.xml

Comment 4 by carlosil@chromium.org, Oct 16

Labels: Merge-Request-71 M-71 OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows
Requesting merge approval into 71 since we'd like to gather initial metrics from there. CL above (which is in canary now) adds UMA metrics (which I've checked via chrome://histograms) that are only logged when the "AutoupgradeMixedContent" feature flag is enabled.
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 16

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by gov...@chromium.org, Oct 16

Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 branch 3578 based on comment #4. Please merge ASAP so we can pick it up for tomorrow's release. Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 16

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f905a1da7dbfc92c319ac73d07954106809480c7

commit f905a1da7dbfc92c319ac73d07954106809480c7
Author: Carlos IL <carlosil@chromium.org>
Date: Tue Oct 16 18:02:26 2018

Added metrics for autoupgraded resources and websockets.

Added histograms that log start/failure/response code for autoupgraded
resources, and start/failure/connection success for autoupgraded
websockets. Metrics for form submissions will come in a later CL.

Bug:  893685 
Change-Id: I7715a61c2f7a7582d5b317c1fa8c8fa60c1408a2
Reviewed-on: https://chromium-review.googlesource.com/c/1275295
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599743}(cherry picked from commit c750a81e9fdfc847c674dd74f8f4795760bb1931)
Reviewed-on: https://chromium-review.googlesource.com/c/1283931
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#45}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/f905a1da7dbfc92c319ac73d07954106809480c7/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/f905a1da7dbfc92c319ac73d07954106809480c7/third_party/blink/renderer/core/loader/mixed_content_checker.cc
[modify] https://crrev.com/f905a1da7dbfc92c319ac73d07954106809480c7/third_party/blink/renderer/core/loader/mixed_content_checker.h
[modify] https://crrev.com/f905a1da7dbfc92c319ac73d07954106809480c7/third_party/blink/renderer/modules/websockets/dom_websocket.cc
[modify] https://crrev.com/f905a1da7dbfc92c319ac73d07954106809480c7/third_party/blink/renderer/modules/websockets/dom_websocket.h
[modify] https://crrev.com/f905a1da7dbfc92c319ac73d07954106809480c7/third_party/blink/renderer/platform/DEPS
[modify] https://crrev.com/f905a1da7dbfc92c319ac73d07954106809480c7/third_party/blink/renderer/platform/loader/BUILD.gn
[modify] https://crrev.com/f905a1da7dbfc92c319ac73d07954106809480c7/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[add] https://crrev.com/f905a1da7dbfc92c319ac73d07954106809480c7/third_party/blink/renderer/platform/loader/mixed_content_autoupgrade_status.h
[modify] https://crrev.com/f905a1da7dbfc92c319ac73d07954106809480c7/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/f905a1da7dbfc92c319ac73d07954106809480c7/tools/metrics/histograms/histograms.xml

Comment 8 by carlosil@chromium.org, Oct 16

Status: Fixed (was: Started)
Thanks!
Project Member

Comment 9 by cr-audit...@appspot.gserviceaccount.com, Oct 23

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/f905a1da7dbfc92c319ac73d07954106809480c7

Commit: f905a1da7dbfc92c319ac73d07954106809480c7
Author: carlosil@chromium.org
Commiter: carlosil@chromium.org
Date: 2018-10-16 18:02:26 +0000 UTC

Added metrics for autoupgraded resources and websockets.

Added histograms that log start/failure/response code for autoupgraded
resources, and start/failure/connection success for autoupgraded
websockets. Metrics for form submissions will come in a later CL.

Bug:  893685 
Change-Id: I7715a61c2f7a7582d5b317c1fa8c8fa60c1408a2
Reviewed-on: https://chromium-review.googlesource.com/c/1275295
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599743}(cherry picked from commit c750a81e9fdfc847c674dd74f8f4795760bb1931)
Reviewed-on: https://chromium-review.googlesource.com/c/1283931
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#45}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
►

Sign in to add a comment