New issue
Advanced search Search tips

Issue 893684 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 9
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 893647
issue 893683
issue 893685



Sign in to add a comment

Add a flag to ResourceRequest that logs if a request was autoupgraded to HTTPS

Project Member Reported by carlosil@chromium.org, Oct 9

Issue description

This is needed for metrics and fallback.

 
Blocking: 893685
Labels: Team-Security-UX
Owner: carlosil@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60bd5f6d6217b4b09ede3eea4be33c07fa976a95

commit 60bd5f6d6217b4b09ede3eea4be33c07fa976a95
Author: Carlos IL <carlosil@chromium.org>
Date: Tue Oct 09 19:51:27 2018

Add IsAutomaticUpgrade flag to ResourceRequest

Added a flag that gets set when a mixed content request was
autoupgraded to HTTPS, this will be later used to handle
fallbacks and log metrics.

Bug:  893684 

Change-Id: Idb62b407c75c0e2a7a629c178a8fcec7fad05bfe
Reviewed-on: https://chromium-review.googlesource.com/c/1269460
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598046}
[modify] https://crrev.com/60bd5f6d6217b4b09ede3eea4be33c07fa976a95/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
[modify] https://crrev.com/60bd5f6d6217b4b09ede3eea4be33c07fa976a95/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/60bd5f6d6217b4b09ede3eea4be33c07fa976a95/third_party/blink/renderer/platform/loader/fetch/resource_request.cc
[modify] https://crrev.com/60bd5f6d6217b4b09ede3eea4be33c07fa976a95/third_party/blink/renderer/platform/loader/fetch/resource_request.h

Status: Fixed (was: Started)

Sign in to add a comment