Delete "Headless Linux (dbg)" builder |
|||||||
Issue descriptionOn the following page the flakiness dashboard link should be clickable but the html for the link is displayed instead: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_headless_rel/92673 (see screenshot)
,
Oct 9
Looks like there's no particular reason.... I think we should just migrate it to swarming. pdr@, did this break recently? Or did you just notice that it looked like it was doing something it shouldn't be doing.
,
Oct 9
,
Oct 9
I just noticed this and thought it might have been related to a recent patch. I don't think this is high priority.
,
Oct 9
Marking as Available then, since it's not high priority.
,
Oct 9
Philip, why is it its own linux_chromium_headless_rel builder instead of integrating into the normal ones?
,
Oct 9
I'd guess for no good reason. In fact, these tests do run on linux_chromium_rel_ng also. So maybe we can just delete the builder?
,
Oct 9
Yeah, I think both the CI and try version of this bot can be deleted. The tests are running on "Linux Tests" bot, which is supported by CQ. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests/72920 John, you were part of the initial creation of the bot in bug 594108 , do you know of a reason why this bot needs to be separate?
,
Oct 10
After looking at this, I don't think there's a reason to keep this around. The only potential reason not to delete these is that there are a few python tests which I don't think are run anywhere: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933123861911620960/+/steps/headless_python_unittests__with_patch_/0/stdout shows these being run. When I made a CL to delete this builder, generate_buildbot_json.py warned that this test suite wasn't referenced anywhere, once I deleted "Headless Linux (dbg)" and the associated trybot. https://chromium.googlesource.com/chromium/src/+log/master/headless/lib/browser/devtools_api makes it look like these tests could still be testing code which is occasionally modified, so I think we should at least keep around the test suite. Maybe add it to the regular linux bot? |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by martiniss@chromium.org
, Oct 9