New issue
Advanced search Search tips

Issue 893655 link

Starred by 1 user
Status: Verified
Owner:
backer@chromium.org
Closed: Oct 10
Cc:
piman@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Paint flashing is broken

Project Member Reported by pdr@chromium.org, Oct 9 
To reproduce:
Start chrome with --show-paint-rects

Or

Open the inspector.
Go to the rendering tab (press escape, then three dots, then rendering).
Enable paint flashing.


The page flashes red instead of showing paint rects.

Regression range:
https://chromium.googlesource.com/chromium/src/+log/5e3bf2a1f618d292d253ee5b0236fcd2cb909c50..73a64c107201141b3af296e76fb8c98c14523d12

I think this is:
Use SharedImage for HUD layer and one copy raster
https://chromium.googlesource.com/chromium/src/+/e29d023ec416e0931584cb4c6daaa478cd36b478
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0010af1a4dbfb262fbbf84b46af72a347700ac2b

commit 0010af1a4dbfb262fbbf84b46af72a347700ac2b
Author: Jonathan Backer <backer@chromium.org>
Date: Wed Oct 10 18:18:13 2018

HUD: Flush ganesh before deleting texture

We should destroy the ScopeSkSurface before glDeleteTextures so
that ganesh flushes all GL commands. This bug manifests on OSX
with GPU raster, but not linux with GPU raster, presumably because
of different flushing behaviour.

Bug:  893655 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0f6ba26be026e0d33f6f665d24a40e19a3639d83
Reviewed-on: https://chromium-review.googlesource.com/c/1271783
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598407}
[modify] https://crrev.com/0010af1a4dbfb262fbbf84b46af72a347700ac2b/cc/layers/heads_up_display_layer_impl.cc

Comment 3 by backer@chromium.org, Oct 10

Status: Fixed (was: Assigned)

Comment 4 by viswa.karala@chromium.org, Oct 11

Labels: Needs-Feedback
Tried reproducing the issue on chrome version# 71.0.3573.0 using MacBook Air 10.12.6 and MacBook Pro 10.13.1 with steps mentioned below:
1) Launched chrome reported version and navigated to URL: www.fb.com and logged into it
2) Opened Devtools > Elements, pressed escape > clicked on three dot menu and selected Rendering option
3) Enabled 'Paint Flashing' option and hovered mouse over elements section, able to see sections highlighted in main webpage

pdr@ Please find the attached screencast for your reference, could you please try to test this issue on latest chrome# 71.0.3577.0 and help us in verifying the fix.

Thanks!
893655.mp4
1.9 MB View Download

Comment 5 by pdr@chromium.org, Oct 11

Status: Verified (was: Fixed)
viswa.karala, everything is working great now.

Thanks everyone!
►

Sign in to add a comment