New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 893633 link

Starred by 1 user
Status: Assigned
Owner:
█ jdemeulenaere@chromium.org
Last visit > 30 days ago
Cc:
mheikal@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

15KB regression in resource_sizes (MonochromePublic.apk) at 597131:597133

Project Member Reported by mheikal@chromium.org, Oct 9 
Caused by “[Autofill Assistant] Implement ShowDetailsAction.”

Commit: 4ce87c061141e75a45917978571e85f0d2484351

Link to size graph: https://chromeperf.appspot.com/report?sid=bb23072657e2d7ca892a1c3fa4643b1ee29b3a0a44d0732adda87168e89c0380&num_points=10&rev=597133

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Based on the graph: 11K java code and 8K native code

It's not clear to me whether or not this increase was expected.
Please have a look and either:

- Close as “Won't Fix” with a short justification, or
- Land a revert / fix-up.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 9 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=893633

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=8605c6713d4274fe55b6e80e5ead4c50877c6ad1af483d6833074192e12f41f7


Bot(s) for this bug's original alert(s):

Android Builder Perf

Comment 3 by mheikal@chromium.org, Oct 9 

Supersize output for this change:

202 symbols added (+), 7030 changed (~), 31 removed (-), 872245 unchanged (not shown)
Added/Removed by section: .text: +102 .rodata: +9 .data.rel.ro: +7 .data: +5 .bss: +4 .dex: +28 .dex.method: +23
Of changed symbols, 373 grew, 6901 shrank
Number of unique symbols 566489 -> 566639 (+150)
1 paths added, 0 removed, 2929 changed

Showing 7,263 symbols (602 -> 752 unique) with total pss: 14241 bytes
Histogram of symbols based on PSS:
    (-1024,-512]: 1    (-32,-16]: 3    (-2,-1]: 291      [2,4): 30     [32,64): 47    [512,1024): 1
     (-256,-128]: 3     (-16,-8]: 12    (-1,0): 6489     [4,8): 28    [64,128): 41   [2048,4096): 2
      (-128,-64]: 11     (-8,-4]: 21     (0,1): 18      [8,16): 43   [128,256): 14
       (-64,-32]: 12     (-4,-2]: 53     [1,2): 110    [16,32): 28   [256,512): 5
Sizes: .text=4.28kb     .rodata=256 bytes  .data.rel.ro=432 bytes  .data=88 bytes   .bss=160 bytes  .dex=455 bytes  .dex.method=1961 bytes .pak.translations=0 bytes    .pak.nontranslated=0 bytes    .other=6.51kb     total=13.9kb
Counts: .text=6640 .rodata=9 .data.rel.ro=9 .data=6 .bss=8 .dex=71 .dex.method=352 .pak.translations=0 .pak.nontranslated=0 .other=179
Number of unique paths: 2883

Section Legend: t=.text, r=.rodata, R=.data.rel.ro, d=.data, b=.bss, x=.dex, m=.dex.method, p=.pak.translations, P=.pak.nontranslated, o=.other
Index | Running Total | Section@Address | Δ PSS (Δ size_without_padding) | Path
------------------------------------------------------------
~ 0)       3412 (24.0%) o@0x0        3412 (0->0)        {no path}
               Overhead: ELF file
~ 1)       5796 (40.7%) o@0x0        2384 (0->0)        {no path}
               Overhead: APK file
- 2)       5248 (36.9%) m@0x0        -548 (548->0)      third_party/feed/src/src/main/java/com/google/android/libraries/feed/feedmodelprovider/FeedModelProvider.java
               FeedModelProvider#lambda$handleToken$1$FeedModelProvider
+ 3)       5796 (40.7%) m@0x0        548 (0->548)       third_party/feed/src/src/main/java/com/google/android/libraries/feed/feedmodelprovider/FeedModelProvider.java
               FeedModelProvider#lambda$handleToken$19$FeedModelProvider
~ 4)       6150 (43.2%) o@0x0        354 (1628104->1628458) base/trace_event/cfi_backtrace_android.cc
               assets/unwind_cfi_32
+ 5)       6456 (45.3%) t@0x2ab3e34  306 (0->304)       $root_gen_dir/components/autofill_assistant/browser/service.pb.cc
               autofill_assistant::DetailsProto::MergePartialFromCodedStream
+ 6)       6760 (47.5%) t@0x2899148  304 (0->304)       chrome/browser/android/autofill_assistant/ui_controller_android.cc
               autofill_assistant::UiControllerAndroid::ShowDetails
+ 7)       7052 (49.5%) m@0x0        292 (0->292)       chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
               AutofillAssistantUiController#onShowDetails
~ 8)       7332 (51.5%) o@0x0        280 (5125932->5126212) $APK/resources.arsc
               resources.arsc
+ 9)       7584 (53.3%) t@0x2ab3b18  252 (0->252)       $root_gen_dir/components/autofill_assistant/browser/service.pb.cc
               autofill_assistant::DateTimeProto::MergePartialFromCodedStream
+ 10)      7828 (55.0%) t@0x2ab37da  244 (0->244)       $root_gen_dir/components/autofill_assistant/browser/service.pb.cc
               autofill_assistant::DateProto::MergePartialFromCodedStream
+ 11)      8053 (56.5%) m@0x0        225 (0->225)       chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
               AutofillAssistantUiDelegate$DownloadImageTask#doInBackground
~ 12)      8275 (58.1%) o@0x0        222 (1006->1228)   chrome/android/java/res/layout/autofill_assistant_sheet.xml
               res/layout-v17/autofill_assistant_sheet.xml
- 13)      8063 (56.6%) m@0x0        -212 (212->0)      third_party/feed/src/src/main/java/com/google/android/libraries/feed/feedmodelprovider/FeedModelProvider.java
               FeedModelProvider#lambda$new$0$FeedModelProvider
+ 14)      8275 (58.1%) m@0x0        212 (0->212)       third_party/feed/src/src/main/java/com/google/android/libraries/feed/feedmodelprovider/FeedModelProvider.java
               FeedModelProvider#lambda$new$18$FeedModelProvider
+ 15)      8461 (59.4%) t@0x2ab41b6  186 (0->186)       $root_gen_dir/components/autofill_assistant/browser/service.pb.cc
               autofill_assistant::ShowDetailsProto::MergePartialFromCodedStream
~ 16)      8638 (60.7%) m@0x0        177 (327->504)     chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
               AutofillAssistantUiDelegate#<init>
- 17)      8469 (59.5%) m@0x0        -169 (169->0)      third_party/feed/src/src/main/java/com/google/android/libraries/feed/feedsessionmanager/FeedSessionManager.java
               FeedSessionManager#lambda$null$11$FeedSessionManager
+ 18)      8638 (60.7%) m@0x0        169 (0->169)       third_party/feed/src/src/main/java/com/google/android/libraries/feed/feedsessionmanager/FeedSessionManager.java
               FeedSessionManager#lambda$null$45$FeedSessionManager
+ 19)      8798 (61.8%) m@0x0        160 (0->160)       chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
               AutofillAssistantUiDelegate#getDetailsText
+ 20)      8954 (62.9%) t@0x2ab4070  156 (0->156)       $root_gen_dir/components/autofill_assistant/browser/service.pb.cc
               autofill_assistant::DetailsProto::MergeFrom
- 21)      8800 (61.8%) m@0x0        -154 (154->0)      third_party/feed/src/src/main/java/com/google/android/libraries/feed/feedsessionmanager/internal/SessionCache.java
               SessionCache#lambda$new$0$SessionCache
+ 22)      8954 (62.9%) m@0x0        154 (0->154)       third_party/feed/src/src/main/java/com/google/android/libraries/feed/feedsessionmanager/internal/SessionCache.java
               SessionCache#lambda$new$48$SessionCache
+ 23)      9100 (63.9%) m@0x0        146 (0->146)       chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
               AutofillAssistantUiDelegate$$Lambda$4#onResult
+ 24)      9244 (64.9%) t@0x2aa7490  144 (0->144)       components/autofill_assistant/browser/actions/show_details_action.cc
               autofill_assistant::ShowDetailsAction::ProcessAction


******************************Resource Sizes Diff******************************
For an explanation of these metrics, see:
https://chromium.googlesource.com/chromium/src/+/master/docs/speed/binary_size/metrics.md#Metrics-for-Android

Specifics:
       +15,267 bytes normalized apk size
        +2,376 bytes secondary dex size
        +8,624 bytes main lib size
           +12 bytes main dex size
InstallSize:
       +13,233 bytes APK size
    +22,880.52 bytes Estimated installed size
InstallBreakdown (+20,496.52 bytes):
          +354 bytes unwind_cfi (dev and canary only) size
          +226 bytes Non-compiled Android resources size
        +8,624 bytes Native code size
            +9 bytes Package metadata size
    +11,003.52 bytes Java code size
          +280 bytes Compiled Android resources size
Dex:
           +24 entries fields
           +23 entries methods
            +4 entries types
           +11 entries strings
►

Sign in to add a comment