New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 893628 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

chrome:// pages: implement 'Managed by' message

Project Member Reported by nicolaso@chromium.org, Oct 9

Issue description

See bug 893626, we want to implement a UI proposal [1] to display a 'Managed by your organization' message on the following pages:

- about:settings
- about:bookmarks
- about:history
- about:downloads
- about:extensions

[1] https://docs.google.com/presentation/d/1Q6Pn0YB1UgH1QKiSMQadTjStMMXKVoH60nb9QN3ee1o/edit
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4d54fcbe0fd1022dbf9dd7606da9387d640bd5f

commit f4d54fcbe0fd1022dbf9dd7606da9387d640bd5f
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Thu Oct 18 19:34:09 2018

Add BrowserPolicyConnector::HasMachineLevelPolicies()

It returns true when there are any policies at the machine level,
whether that's from a platform provider, or from cloud policies.

Bug: 893626, 893628
Change-Id: I6e90ff54ee400a82df04c2f671d408d04b3e3bc5
Reviewed-on: https://chromium-review.googlesource.com/c/1269764
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600866}
[modify] https://crrev.com/f4d54fcbe0fd1022dbf9dd7606da9387d640bd5f/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/f4d54fcbe0fd1022dbf9dd7606da9387d640bd5f/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h
[modify] https://crrev.com/f4d54fcbe0fd1022dbf9dd7606da9387d640bd5f/chrome/browser/policy/chrome_browser_policy_connector.cc
[modify] https://crrev.com/f4d54fcbe0fd1022dbf9dd7606da9387d640bd5f/chrome/browser/policy/chrome_browser_policy_connector.h
[add] https://crrev.com/f4d54fcbe0fd1022dbf9dd7606da9387d640bd5f/chrome/browser/policy/chrome_browser_policy_connector_unittest.cc
[modify] https://crrev.com/f4d54fcbe0fd1022dbf9dd7606da9387d640bd5f/chrome/test/BUILD.gn
[modify] https://crrev.com/f4d54fcbe0fd1022dbf9dd7606da9387d640bd5f/components/policy/core/browser/browser_policy_connector.h

Can we exclude Demo Mode devices from this message? We bypass other warnings (like the Public Sessions sign-in screen message) since enterprise enrollment is more of an implementation detail of Demo Mode than an organizational relationship with the user. We also display a different message in chrome://settings for controlled settings.
Cc: wlarsen@google.com
+wlarsen@ FYI
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8516b846cd6f074986e1067837182c1041720f18

commit 8516b846cd6f074986e1067837182c1041720f18
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Mon Dec 10 22:01:13 2018

[WebUI] Add <managed-footnote> component

This Polymer component can be used on WebUI pages as a disclosure for
managed users. It shows an enterprise icon and the text 'Your browser is
managed by your organization'. It also has a hyperlink that points to a
Help Center article.

Bug: 893628
Change-Id: Id9e5e0b3552943c260ac251c3b643dd963b5809a
Reviewed-on: https://chromium-review.googlesource.com/c/1352438
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615273}
[modify] https://crrev.com/8516b846cd6f074986e1067837182c1041720f18/chrome/app/generated_resources.grd
[add] https://crrev.com/8516b846cd6f074986e1067837182c1041720f18/chrome/app/generated_resources_grd/IDS_MANAGED_BY_ORG_WITH_HYPERLINK.png.sha1
[modify] https://crrev.com/8516b846cd6f074986e1067837182c1041720f18/chrome/test/data/webui/cr_components/cr_components_browsertest.js
[add] https://crrev.com/8516b846cd6f074986e1067837182c1041720f18/chrome/test/data/webui/cr_components/managed_footnote_test.js
[modify] https://crrev.com/8516b846cd6f074986e1067837182c1041720f18/ui/webui/resources/cr_components/BUILD.gn
[modify] https://crrev.com/8516b846cd6f074986e1067837182c1041720f18/ui/webui/resources/cr_components/cr_components_resources.grdp
[add] https://crrev.com/8516b846cd6f074986e1067837182c1041720f18/ui/webui/resources/cr_components/managed_footnote/BUILD.gn
[add] https://crrev.com/8516b846cd6f074986e1067837182c1041720f18/ui/webui/resources/cr_components/managed_footnote/managed_footnote.html
[add] https://crrev.com/8516b846cd6f074986e1067837182c1041720f18/ui/webui/resources/cr_components/managed_footnote/managed_footnote.js
[modify] https://crrev.com/8516b846cd6f074986e1067837182c1041720f18/ui/webui/resources/cr_elements/icons.html

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88c244235d8370e05091a790c3f24ad0a7477cd9

commit 88c244235d8370e05091a790c3f24ad0a7477cd9
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Wed Dec 12 15:42:22 2018

Add 'Managed by' UI on chrome://downloads

Adds a message for managed users at the top of the chrome://downloads
page.

Enterprise users will now see a message that says "Your browser is
managed by your organization", with a link they can click to view a help
center article.

The new UI is hidden behind a flag so that most users don't see this WIP
feature just yet.

Bug: 893628
Change-Id: I23781e239e3b87e7b8d4f59a679292774eea54a3
Reviewed-on: https://chromium-review.googlesource.com/c/1352616
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615900}
[modify] https://crrev.com/88c244235d8370e05091a790c3f24ad0a7477cd9/chrome/browser/resources/md_downloads/i18n_setup.html
[modify] https://crrev.com/88c244235d8370e05091a790c3f24ad0a7477cd9/chrome/browser/resources/md_downloads/manager.html
[modify] https://crrev.com/88c244235d8370e05091a790c3f24ad0a7477cd9/chrome/browser/resources/md_downloads/manager.js
[modify] https://crrev.com/88c244235d8370e05091a790c3f24ad0a7477cd9/chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc
[modify] https://crrev.com/88c244235d8370e05091a790c3f24ad0a7477cd9/chrome/test/data/webui/md_downloads/manager_tests.js
[modify] https://crrev.com/88c244235d8370e05091a790c3f24ad0a7477cd9/ui/webui/resources/cr_components/managed_footnote/managed_footnote.html

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85de6d1dcc0c77beb59a085d7abd0970337d0d0a

commit 85de6d1dcc0c77beb59a085d7abd0970337d0d0a
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Wed Dec 12 19:18:10 2018

Add 'Managed by' UI on chrome://extensions

Adds a message for managed users at the top of the
chrome://extensions page.

Enterprise users will now see a message that says "Your browser is
managed by your organization", with a link they can click to view a help
center article.

The new UI is hidden behind a flag so that most users don't see this WIP
feature just yet.

Bug: 893628
Change-Id: Ib8aac65759880b3cd3509b2f57990affb3aafc4f
Reviewed-on: https://chromium-review.googlesource.com/c/1352496
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615990}
[modify] https://crrev.com/85de6d1dcc0c77beb59a085d7abd0970337d0d0a/chrome/browser/resources/md_extensions/item_list.html
[modify] https://crrev.com/85de6d1dcc0c77beb59a085d7abd0970337d0d0a/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/85de6d1dcc0c77beb59a085d7abd0970337d0d0a/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/85de6d1dcc0c77beb59a085d7abd0970337d0d0a/chrome/test/data/webui/extensions/item_list_test.js

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17e33d80ab29ad2b015207c4b9dddfd18f0712ed

commit 17e33d80ab29ad2b015207c4b9dddfd18f0712ed
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Tue Dec 18 15:25:44 2018

Add 'Managed by' UI on chrome://bookmarks

Adds a message for managed users at the bottom of the sidebar on the
chrome://bookmarks page.

Enterprise users will now see a message that says "Your browser is
managed by your organization", with a link they can click to view a help
center article.

The new UI is hidden behind a flag so that most users don't see this WIP
feature just yet.

Bug: 893628
Change-Id: Ic53e0eef22254c6de4aca7067f7ef01d5062870d
Reviewed-on: https://chromium-review.googlesource.com/c/1378638
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617497}
[modify] https://crrev.com/17e33d80ab29ad2b015207c4b9dddfd18f0712ed/chrome/browser/browser_resources.grd
[modify] https://crrev.com/17e33d80ab29ad2b015207c4b9dddfd18f0712ed/chrome/browser/resources/md_bookmarks/app.html
[modify] https://crrev.com/17e33d80ab29ad2b015207c4b9dddfd18f0712ed/chrome/browser/resources/md_bookmarks/bookmarks.html
[add] https://crrev.com/17e33d80ab29ad2b015207c4b9dddfd18f0712ed/chrome/browser/resources/md_bookmarks/strings.html
[modify] https://crrev.com/17e33d80ab29ad2b015207c4b9dddfd18f0712ed/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[modify] https://crrev.com/17e33d80ab29ad2b015207c4b9dddfd18f0712ed/ui/webui/resources/cr_components/managed_footnote/managed_footnote.html

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/298c2e1d6015f093e12b55f1111e5d1228e5a9f4

commit 298c2e1d6015f093e12b55f1111e5d1228e5a9f4
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Dec 18 19:40:37 2018

Revert "Add 'Managed by' UI on chrome://bookmarks"

This reverts commit 17e33d80ab29ad2b015207c4b9dddfd18f0712ed.

Reason for revert: MD bookmarks tests are failing on ChromeOS bot.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9661

Original change's description:
> Add 'Managed by' UI on chrome://bookmarks
> 
> Adds a message for managed users at the bottom of the sidebar on the
> chrome://bookmarks page.
> 
> Enterprise users will now see a message that says "Your browser is
> managed by your organization", with a link they can click to view a help
> center article.
> 
> The new UI is hidden behind a flag so that most users don't see this WIP
> feature just yet.
> 
> Bug: 893628
> Change-Id: Ic53e0eef22254c6de4aca7067f7ef01d5062870d
> Reviewed-on: https://chromium-review.googlesource.com/c/1378638
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617497}

TBR=dpapad@chromium.org,nicolaso@chromium.org

Change-Id: I4586d75b113847c8aa31188ebf7725085ae86d20
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 893628
Reviewed-on: https://chromium-review.googlesource.com/c/1383113
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617591}
[modify] https://crrev.com/298c2e1d6015f093e12b55f1111e5d1228e5a9f4/chrome/browser/browser_resources.grd
[modify] https://crrev.com/298c2e1d6015f093e12b55f1111e5d1228e5a9f4/chrome/browser/resources/md_bookmarks/app.html
[modify] https://crrev.com/298c2e1d6015f093e12b55f1111e5d1228e5a9f4/chrome/browser/resources/md_bookmarks/bookmarks.html
[delete] https://crrev.com/c9d642eef6ed289cf500959a8e6740d1fa421160/chrome/browser/resources/md_bookmarks/strings.html
[modify] https://crrev.com/298c2e1d6015f093e12b55f1111e5d1228e5a9f4/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[modify] https://crrev.com/298c2e1d6015f093e12b55f1111e5d1228e5a9f4/ui/webui/resources/cr_components/managed_footnote/managed_footnote.html

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2432c5d137f908068f125de55dbe15d7e85df9d5

commit 2432c5d137f908068f125de55dbe15d7e85df9d5
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Wed Jan 09 16:31:30 2019

Reland "Add 'Managed by' UI on chrome://bookmarks"

This is a reland of 17e33d80ab29ad2b015207c4b9dddfd18f0712ed

Original change's description:
> Add 'Managed by' UI on chrome://bookmarks
> 
> Adds a message for managed users at the bottom of the sidebar on the
> chrome://bookmarks page.
> 
> Enterprise users will now see a message that says "Your browser is
> managed by your organization", with a link they can click to view a help
> center article.
> 
> The new UI is hidden behind a flag so that most users don't see this WIP
> feature just yet.
> 
> Bug: 893628
> Change-Id: Ic53e0eef22254c6de4aca7067f7ef01d5062870d
> Reviewed-on: https://chromium-review.googlesource.com/c/1378638
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617497}

Bug: 893628
Change-Id: I415bdda4baac4fc30878d29652173e6d56cb3211
Reviewed-on: https://chromium-review.googlesource.com/c/1383197
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621174}
[modify] https://crrev.com/2432c5d137f908068f125de55dbe15d7e85df9d5/chrome/browser/browser_resources.grd
[modify] https://crrev.com/2432c5d137f908068f125de55dbe15d7e85df9d5/chrome/browser/resources/md_bookmarks/app.html
[modify] https://crrev.com/2432c5d137f908068f125de55dbe15d7e85df9d5/chrome/browser/resources/md_bookmarks/bookmarks.html
[modify] https://crrev.com/2432c5d137f908068f125de55dbe15d7e85df9d5/chrome/browser/resources/md_bookmarks/command_manager.html
[modify] https://crrev.com/2432c5d137f908068f125de55dbe15d7e85df9d5/chrome/browser/resources/md_bookmarks/edit_dialog.html
[modify] https://crrev.com/2432c5d137f908068f125de55dbe15d7e85df9d5/chrome/browser/resources/md_bookmarks/folder_node.html
[modify] https://crrev.com/2432c5d137f908068f125de55dbe15d7e85df9d5/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/2432c5d137f908068f125de55dbe15d7e85df9d5/chrome/browser/resources/md_bookmarks/list.html
[add] https://crrev.com/2432c5d137f908068f125de55dbe15d7e85df9d5/chrome/browser/resources/md_bookmarks/strings.html
[modify] https://crrev.com/2432c5d137f908068f125de55dbe15d7e85df9d5/chrome/browser/resources/md_bookmarks/toolbar.html
[modify] https://crrev.com/2432c5d137f908068f125de55dbe15d7e85df9d5/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[modify] https://crrev.com/2432c5d137f908068f125de55dbe15d7e85df9d5/ui/webui/resources/cr_components/managed_footnote/managed_footnote.html

Project Member

Comment 10 by bugdroid1@chromium.org, Yesterday (35 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04fb00a20bc9758ec846853c5751ab18221869ce

commit 04fb00a20bc9758ec846853c5751ab18221869ce
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Mon Jan 21 20:53:47 2019

Add 'Managed UI' on chrome://settings

Adds a message for managed users at the top of the chrome://settings
page.

Enterprise users will now see a message that says "Your browser is
managed by your organization", with a link they can click to view a help
center article.

The new UI is hidden behind a flag so that most users don't see this WIP
feature just yet.

Bug: 893628
Change-Id: I878497a5f39cb2a86015af5331198bfffbcf53a3
Reviewed-on: https://chromium-review.googlesource.com/c/1401509
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624649}
[modify] https://crrev.com/04fb00a20bc9758ec846853c5751ab18221869ce/chrome/browser/resources/settings/i18n_setup.html
[modify] https://crrev.com/04fb00a20bc9758ec846853c5751ab18221869ce/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/04fb00a20bc9758ec846853c5751ab18221869ce/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/04fb00a20bc9758ec846853c5751ab18221869ce/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/04fb00a20bc9758ec846853c5751ab18221869ce/chrome/test/data/webui/settings/settings_main_test.js

Project Member

Comment 11 by bugdroid, Today (11 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95a1e24688c9a29ce5aea56f17d45e5ccd0e409e

commit 95a1e24688c9a29ce5aea56f17d45e5ccd0e409e
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Tue Jan 22 21:23:56 2019

Add 'Managed by' UI on chrome://history

Also updates the visual style of the footnote at the bottom of
chrome://history (the one that says "Your Google Account may have other
forms of browsing history...").

Adds a message for managed users at the bottom of the sidebar on the
chrome://history page page.

Enterprise users will now see a message that says "Your browser is
managed by your organization", with a link they can click to view a help
center article.

The new UI is hidden behind a flag so that most users don't see this WIP
feature just yet.

Bug: 893628
Change-Id: I127c83f421987914e7c137cdc7cdea3952e48b04
Reviewed-on: https://chromium-review.googlesource.com/c/1382811
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624925}
[modify] https://crrev.com/95a1e24688c9a29ce5aea56f17d45e5ccd0e409e/chrome/browser/browser_resources.grd
[modify] https://crrev.com/95a1e24688c9a29ce5aea56f17d45e5ccd0e409e/chrome/browser/resources/md_history/app.html
[modify] https://crrev.com/95a1e24688c9a29ce5aea56f17d45e5ccd0e409e/chrome/browser/resources/md_history/app.js
[modify] https://crrev.com/95a1e24688c9a29ce5aea56f17d45e5ccd0e409e/chrome/browser/resources/md_history/history.html
[modify] https://crrev.com/95a1e24688c9a29ce5aea56f17d45e5ccd0e409e/chrome/browser/resources/md_history/history.js
[modify] https://crrev.com/95a1e24688c9a29ce5aea56f17d45e5ccd0e409e/chrome/browser/resources/md_history/history_item.html
[modify] https://crrev.com/95a1e24688c9a29ce5aea56f17d45e5ccd0e409e/chrome/browser/resources/md_history/history_toolbar.html
[modify] https://crrev.com/95a1e24688c9a29ce5aea56f17d45e5ccd0e409e/chrome/browser/resources/md_history/shared_vars.html
[modify] https://crrev.com/95a1e24688c9a29ce5aea56f17d45e5ccd0e409e/chrome/browser/resources/md_history/side_bar.html
[modify] https://crrev.com/95a1e24688c9a29ce5aea56f17d45e5ccd0e409e/chrome/browser/resources/md_history/side_bar.js
[add] https://crrev.com/95a1e24688c9a29ce5aea56f17d45e5ccd0e409e/chrome/browser/resources/md_history/strings.html
[modify] https://crrev.com/95a1e24688c9a29ce5aea56f17d45e5ccd0e409e/chrome/browser/resources/md_history/synced_device_card.html
[modify] https://crrev.com/95a1e24688c9a29ce5aea56f17d45e5ccd0e409e/chrome/browser/resources/md_history/synced_device_manager.html
[modify] https://crrev.com/95a1e24688c9a29ce5aea56f17d45e5ccd0e409e/chrome/browser/ui/webui/md_history_ui.cc
[modify] https://crrev.com/95a1e24688c9a29ce5aea56f17d45e5ccd0e409e/ui/webui/resources/cr_components/managed_footnote/managed_footnote.html

Sign in to add a comment