Couple of notes on the implementation
1. Increase the height of the row
2. Rounded corners for the overflow menu on Mac.
3. "organization" vs "Organization"
Attaching spec
Also tried checking this out in Canary on Windows, but was not able to see the change?
Also tried checking out demo on Canary on Windows, but this message didn't show up?
Thanks for sharing the spec. I'll update the alignment to better match the spec, and fix the rounded corners on Mac.
As for Windows, I couldn't reproduce your issue on Canary 72.0.3622.0. Did you enable the 'show-managed-ui' flag in about:flags? Or perhaps your computer isn't managed [1].
Also found an issue on Windows, where the grey background gets drawn over the menu's bottom border. It's especially obvious in the menu's bottom left corner [1].
I'll take a look at all of that as soon as I can. :-)
[1] https://support.google.com/chromebook/answer/1331549
[2] https://imgur.com/a/EAapw7j
namratakannan@, I noticed a small issue with the spec for Mac OS. The spec says to use a 16px margin on either side of the icon.
However, on Mac OS, the left margin of the menu is is 25px, not 16px. So, if we use 16px on the left, it won't be aligned with the other menu items.
Anyways, should I adjust the right margin to also be 25px? Or should I use 16px still?
namratakannan@: the patch from comment 9 is in Canary now, and should fix most of these issues. Can you take a another look?
I can't reproduce your issue on Windows. Make sure the flag is turned on, and your device is managed (see comment 5) when testing.
Checked on windows and I realized two issues:
1. The horizontal alignment of icon and text
2. Can we follow the padding that the update icon follows today on Windows? Image attached
BTW implementation on Mac looks good.
FWIW the update icon also isn't aligned with the text baseline, it just looks less weird because of the shape of the icon.
Anyways, we can try enlarging the icon by 2px horizontally and moving it up by 4px.
Comment 1 by bugdroid1@chromium.org
, Oct 18