New issue
Advanced search Search tips

Issue 893618 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

blink/tools/run_web_tests.py should automatically pick a target directory if none exists

Project Member Reported by nedngu...@google.com, Oct 9

Issue description

I usually build chromium default (chromium/src/out/Default/). Running ./third_party/blink/tools/run_web_tests.py usually complain about chromium/src/out/Release/Content Shell.app/Contents/MacOS/Content Shell doesn't exist. 


I think it would be a bit more convenient for users if:
1) run_web_tests.py scans all the target directories in chromium/src/out/
2) It picks the directory whose "chromium/src/out/<target>/Content Shell.app/Contents/MacOS/Content Shell" is the most recently built binary.

Thoughts?
 
A more conservative approach that would have much of the same benefit, is to check if there is only one candidate after the scan, and if so use that, and otherwise list the command line arguments that should be added to pick one or the other.
#1: SG, I think we can start with the more conservative approach first.
Owner: nednguyen@chromium.org
Status: Assigned (was: Untriaged)
Owner: nedngu...@google.com
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90a499f67f5f97dfd6f11845f9101dd6e605528e

commit 90a499f67f5f97dfd6f11845f9101dd6e605528e
Author: Ned Nguyen <nednguyen@google.com>
Date: Wed Oct 17 21:51:31 2018

Do not skip system health smoke test if --also-run-disabled-tests flag is passed

System health test are skipped dynamically, so unlike other Telemetry tests which are disabled
with @dectorators.Skip(..), the logic to not skip these tests have be done by the sites that invoke self.skipTest(..)

Bug:  893618 
Change-Id: I2c2869c5ec75613e797bc68d4c546b698f949869
Reviewed-on: https://chromium-review.googlesource.com/c/1287099
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#600569}
[modify] https://crrev.com/90a499f67f5f97dfd6f11845f9101dd6e605528e/tools/perf/benchmarks/system_health_smoke_test.py

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31d8df28ffbaa133c2749057832d771fcecfa7d2

commit 31d8df28ffbaa133c2749057832d771fcecfa7d2
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Oct 18 01:46:53 2018

Implement generate_test_also_run_disabled_tests_args for Telemetry unittest script

Bug:  893618 
Change-Id: I56f6c0ccf0c7cecfa419d557ed9fc444f500cd2d
Reviewed-on: https://chromium-review.googlesource.com/c/1287039
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#600633}
[modify] https://crrev.com/31d8df28ffbaa133c2749057832d771fcecfa7d2/testing/scripts/common.py
[modify] https://crrev.com/31d8df28ffbaa133c2749057832d771fcecfa7d2/testing/scripts/run_telemetry_as_googletest.py

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/601c5f9c7377dbb00dc8677df4bcff9ab63a9cfc

commit 601c5f9c7377dbb00dc8677df4bcff9ab63a9cfc
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Oct 18 01:55:10 2018

Implement generate_test_repeat_args for Telemetry unittest script

Bug:  893618 
Change-Id: Idbfa57949f173847d2985e528fe05bdf1a2e93a2
Reviewed-on: https://chromium-review.googlesource.com/c/1287033
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600634}
[modify] https://crrev.com/601c5f9c7377dbb00dc8677df4bcff9ab63a9cfc/testing/scripts/common.py
[modify] https://crrev.com/601c5f9c7377dbb00dc8677df4bcff9ab63a9cfc/testing/scripts/run_telemetry_as_googletest.py

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05

commit 5f74e5433d04e79587c8f452a0d6a5dc3c96ca05
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Oct 18 14:53:10 2018

Automatically pick a target directory which exists for run_web_tests.py script

This also updates how we compute the default for 'configuration'. First, we try to look for the
configuration definition (args.gn) & use that value. If that doesn't succeed, we guess the
value of configuration using the target value.

Reviewers: the main change is in third_party/blink/tools/blinkpy/web_tests/port/base.py, the rest are followed by.


Bug:  893618 
Change-Id: I578c977bcaccd6294596f8cf7079748809698db6
Reviewed-on: https://chromium-review.googlesource.com/c/1281043
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#600760}
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/lint_test_expectations.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/lint_test_expectations_unittest.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/port/android.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/port/android_unittest.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/port/base.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/port/base_unittest.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/port/browser_test_unittest.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/port/driver_unittest.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/port/factory.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/port/factory_unittest.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/port/linux_unittest.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/port/mac_unittest.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/port/mock_drt_unittest.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/port/port_testcase.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/port/test.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/port/win_unittest.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper.py

Status: Fixed (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd33154bc873405c45a224e9f942dfffdd82193f

commit bd33154bc873405c45a224e9f942dfffdd82193f
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Oct 18 19:34:13 2018

Revert "Automatically pick a target directory which exists for run_web_tests.py script"

This reverts commit 5f74e5433d04e79587c8f452a0d6a5dc3c96ca05.

Reason for revert: this broke run_web_tests.py, I'm getting:
No handlers could be found for logger "blinkpy.web_tests.port.base"


Original change's description:
> Automatically pick a target directory which exists for run_web_tests.py script
> 
> This also updates how we compute the default for 'configuration'. First, we try to look for the
> configuration definition (args.gn) & use that value. If that doesn't succeed, we guess the
> value of configuration using the target value.
> 
> Reviewers: the main change is in third_party/blink/tools/blinkpy/web_tests/port/base.py, the rest are followed by.
> 
> 
> Bug:  893618 
> Change-Id: I578c977bcaccd6294596f8cf7079748809698db6
> Reviewed-on: https://chromium-review.googlesource.com/c/1281043
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Robert Ma <robertma@chromium.org>
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#600760}

TBR=dpranke@chromium.org,nednguyen@google.com,robertma@chromium.org

Change-Id: I99ddad12601e0d207ee7d9c276b9d64333488f67
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  893618 
Reviewed-on: https://chromium-review.googlesource.com/c/1289431
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600867}
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/lint_test_expectations.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/lint_test_expectations_unittest.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/port/android.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/port/android_unittest.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/port/base.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/port/base_unittest.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/port/browser_test_unittest.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/port/driver_unittest.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/port/factory.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/port/factory_unittest.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/port/linux_unittest.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/port/mac_unittest.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/port/mock_drt_unittest.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/port/port_testcase.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/port/test.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/port/win_unittest.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/bd33154bc873405c45a224e9f942dfffdd82193f/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper.py

Cc: wangxianzhu@chromium.org
The CL was reverted because many people chose to specify the target over configuration and the error message wasn't printed properly to tell people what to do.

So fixes in the reland:
1) Make sure that the error message are output properly if there are multiple targets (https://chromium-review.googlesource.com/c/chromium/src/+/1289305)
2) If --target is specified, look into the args.gn file & use that to determine the configuration
Status: Assigned (was: Fixed)
I think we should add (which afaik is the workflow many developers use and was broken with the CL):
3) If --target is not specified:
  a. If --release or --debug is specified and there are both "out/Release" and "out/Debug", it should choose out/Release or out/Debug based on args.gn.
  b. If none of --target, --release, --debug, the behavior should be like the current behavior.
#12: that's what I meant with (2) in #11. Sorry, I still confuse between --target and --release, --debug :-P 
This is why all of --target/--release/--debug/--build-directory/--configuration need to go :).
Should we keep one of them (--target)?

It would sound good to me if only --target is supported, but we need to show a message for --release and --debug to let developers know to switch to --target.
The comment in https://chromium-review.googlesource.com/c/chromium/src/+/1281043#message-66fed83542b5c13bd1bf9db4f8b04376b3ffb54f is how I'd get rid of all of these things. The problem is that we're trying to be too clever about guessing which directory to use and what the configuration in that directory is. We should just make it easy for the dev to tell us that instead (implicitly), but having them invoke the right wrapper instead of a generic script.

And, yes, we'll need some sort of message to get people to migrate over to things.
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d994d5998d6f901576bea2152e2099b4c800f57

commit 0d994d5998d6f901576bea2152e2099b4c800f57
Author: Ned Nguyen <nednguyen@google.com>
Date: Fri Oct 19 20:09:45 2018

Reland (with fix) "Automatically pick a target directory which exists for run_web_tests.py script"

This is a reland of 5f74e5433d04e79587c8f452a0d6a5dc3c96ca05.

The original reland is in patch set 1, fixes are in subsequent patchset.

The fix implements:
If --release or --debug is specified and there are both more than one target dirs,
it would try to choose the dir that match the configuration on args.gn

Original change's description:
>Automatically pick a target directory which exists for run_web_tests.py script
>
> This also updates how we compute the default for 'configuration'. First, we try to look for the
> configuration definition (args.gn) & use that value. If that doesn't succeed, we guess the
> value of configuration using the target value.
>
> Reviewers: the main change is in third_party/blink/tools/blinkpy/web_tests/port/base.py, the rest are followed by.
>
>
> Bug:  893618 
> Change-Id: I578c977bcaccd6294596f8cf7079748809698db6
> Reviewed-on: https://chromium-review.googlesource.com/c/1281043
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Robert Ma <robertma@chromium.org>
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#600760}

Bug:  893618 
Change-Id: I386b8261fc4abddd51a5b4f290c5eb3ac6ce5361
Reviewed-on: https://chromium-review.googlesource.com/c/1289308
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601271}
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/lint_test_expectations.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/lint_test_expectations_unittest.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/port/android.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/port/android_unittest.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/port/base.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/port/base_unittest.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/port/browser_test_unittest.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/port/driver_unittest.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/port/factory.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/port/factory_unittest.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/port/linux_unittest.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/port/mac_unittest.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/port/mock_drt_unittest.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/port/port_testcase.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/port/test.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/port/win_unittest.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/0d994d5998d6f901576bea2152e2099b4c800f57/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper.py

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d535eab41bedbf8ef757b026f7afee28176ae3f4

commit d535eab41bedbf8ef757b026f7afee28176ae3f4
Author: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Date: Mon Oct 22 11:52:41 2018

Revert "Reland (with fix) "Automatically pick a target directory which exists for run_web_tests.py script""

This reverts commit 0d994d5998d6f901576bea2152e2099b4c800f57.

Reason for revert: bot failure crbug.com/897673

TEST RESULTS WERE INVALID - webkit_layout_tests failing on chromium.android/KitKat Phone Tester (dbg)

Original change's description:
> Reland (with fix) "Automatically pick a target directory which exists for run_web_tests.py script"
> 
> This is a reland of 5f74e5433d04e79587c8f452a0d6a5dc3c96ca05.
> 
> The original reland is in patch set 1, fixes are in subsequent patchset.
> 
> The fix implements:
> If --release or --debug is specified and there are both more than one target dirs,
> it would try to choose the dir that match the configuration on args.gn
> 
> Original change's description:
> >Automatically pick a target directory which exists for run_web_tests.py script
> >
> > This also updates how we compute the default for 'configuration'. First, we try to look for the
> > configuration definition (args.gn) & use that value. If that doesn't succeed, we guess the
> > value of configuration using the target value.
> >
> > Reviewers: the main change is in third_party/blink/tools/blinkpy/web_tests/port/base.py, the rest are followed by.
> >
> >
> > Bug:  893618 
> > Change-Id: I578c977bcaccd6294596f8cf7079748809698db6
> > Reviewed-on: https://chromium-review.googlesource.com/c/1281043
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Reviewed-by: Robert Ma <robertma@chromium.org>
> > Commit-Queue: Ned Nguyen <nednguyen@google.com>
> > Cr-Commit-Position: refs/heads/master@{#600760}
> 
> Bug:  893618 
> Change-Id: I386b8261fc4abddd51a5b4f290c5eb3ac6ce5361
> Reviewed-on: https://chromium-review.googlesource.com/c/1289308
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601271}

TBR=dpranke@chromium.org,nednguyen@google.com,robertma@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  893618 ,897673
Change-Id: Ib095b320122267c9e1d352d6c5b3e0fc358ce4c7
Reviewed-on: https://chromium-review.googlesource.com/c/1293453
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601531}
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/lint_test_expectations.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/lint_test_expectations_unittest.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/port/android.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/port/android_unittest.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/port/base.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/port/base_unittest.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/port/browser_test_unittest.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/port/driver_unittest.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/port/factory.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/port/factory_unittest.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/port/linux_unittest.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/port/mac_unittest.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/port/mock_drt_unittest.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/port/port_testcase.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/port/test.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/port/win_unittest.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/d535eab41bedbf8ef757b026f7afee28176ae3f4/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper.py

Status: WontFix (was: Assigned)
Given it's not easy to make this change & the direction in issue 897803 will make this issue obsolete, I will proceed with working on issue 897803 instead.
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68c34986a566b42afba671db722b26a4d973fec9

commit 68c34986a566b42afba671db722b26a4d973fec9
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Nov 01 01:07:58 2018

Add clean_up_after_test_run hook for BaseIsolatedScriptArgsAdapater

This is a pure refactoring change to make the code cleaner. There is no intended effects change.

Bug:  893618 
Change-Id: I68d59e804c637da07cefac7fcdcdef3c70626227
Reviewed-on: https://chromium-review.googlesource.com/c/1311801
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#604469}
[modify] https://crrev.com/68c34986a566b42afba671db722b26a4d973fec9/testing/scripts/common.py
[modify] https://crrev.com/68c34986a566b42afba671db722b26a4d973fec9/testing/scripts/run_isolated_script_test.py

Sign in to add a comment