New issue
Advanced search Search tips

Issue 893608 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 897520



Sign in to add a comment

layout tests: Fix 'instant' scroll speed

Project Member Reported by sadrul@chromium.org, Oct 9

Issue description

The relevant TODO: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/resources/gesture-util.js?l=90

  // TODO(bokan): This isn't really instant but high enough that it works for
  // current purposes. This should be replaced with the Infinity value and
  // the synthetic gesture code modified to guarantee the single update behavior.
  const SPEED_INSTANT = 200000;

The current value used for SPEED_INSTANT is dependent on the frequency of event dispatch (see issue 893506, for example).
 
Owner: bokan@chromium.org
Status: Assigned (was: Untriaged)
Yeah, that's true of all our tests using gpuBenchmarking though. I plan to address this in Q4.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b72d3b61ffa3e8d27e9bbfed0cd0427759a2f77

commit 3b72d3b61ffa3e8d27e9bbfed0cd0427759a2f77
Author: Sadrul Chowdhury <sadrul@chromium.org>
Date: Tue Oct 09 16:20:50 2018

blink gesture: Increase the 'instant speed' for scroll gesture.

Double the 'instant speed' for scroll gestures, so that when the input
dispatch frequency goes from 60Hz to 120Hz ( crbug.com/783034 ), some
layout tests do not become flaky.

Bug: 893608, 893506

Change-Id: Id8f4491b43088fac3b1a2cf70888a1a10b8ba774
Reviewed-on: https://chromium-review.googlesource.com/c/1271017
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597938}
[modify] https://crrev.com/3b72d3b61ffa3e8d27e9bbfed0cd0427759a2f77/third_party/WebKit/LayoutTests/resources/gesture-util.js

Blocking: 897520

Sign in to add a comment