No "Manage passwords..." footer on the dropdown |
||||||||||||||||
Issue descriptionChrome Version: 71.0.3559.6 OS: Linux (only tested on Linux, but I assume other desktop platforms are also affected) What steps will reproduce the problem? This happened on this page, while I was trying to buy some tickets https://omniwebticketing.com/cinemaduparc/?schdate=2018-10-19&perfix=27395 If you're reading this after 2018/10/19, you may need to try to buy tickets for another event on omniwebticketing.com (not sure how to find one). The problem happens when the select password dropdown is shown on a name or password field. What is the expected result? The last footer should be "Manage passwords...". What happens instead? The last footer appears, but it's empty. See screenshot.
,
Oct 9
I can't reproduce it on the latest ToT 71.0.3576.0 (Developer Build) (64-bit) It has nothing to do with passwords. The dropdown is for filling emails. The footer "Manage passwords" should not be there. I don't know why the space is empty.
,
Oct 9
This repros for me as well. I agree that it's not necessarily a password issue, though--this form is presumably treating it as an email and not a username.
,
Oct 22
,
Oct 22
We got reports of this happening on other websites on M70. We previously thought this was only happening on M71. The most recent report was https://www.boxed.com/, but I was not able to reproduce it. This is how I got to the error: 1. Navigate to https://cinemaduparc.com/en/now-playing 2. Scroll down until you see showtimes and click on a time for any movie. This will redirect you to https://omniwebticketing.com 3. You need to have an account on the website. The issue happens when you click on the email field. I sent a fix that consists of showing "Manage..." in the footer when the popup type is unspecified (which is the case for this bug). But we should find a proper fix for that in Small Forms.
,
Oct 22
,
Oct 22
,
Oct 22
,
Oct 22
Fix is in the CQ right now: https://chromium-review.googlesource.com/c/chromium/src/+/1293729 Will merge to M70 and M71 branches as soon as the requests are approved.
,
Oct 22
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65c419d84ae1f69966f168f4b298b3a4dfd30495 commit 65c419d84ae1f69966f168f4b298b3a4dfd30495 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Mon Oct 22 17:00:23 2018 [AF] Use 'Manage...' as footer string when popup type is unspecified Bug: 893592 Change-Id: I619bb47295302ba74301c327372206269c12bf23 Reviewed-on: https://chromium-review.googlesource.com/c/1293729 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#601618} [modify] https://crrev.com/65c419d84ae1f69966f168f4b298b3a4dfd30495/components/autofill/core/browser/autofill_external_delegate.cc
,
Oct 22
Since this bug is not easy to reproduce, uploading screenshots from by local checkout with and without the fix.
,
Oct 22
,
Oct 22
Can you please merge this to M71 ASAP? Let's verify this in M71 Dev tomorrow, and we can merge to M70 depending on how this looks. Pre-emptively approving M70 merge.
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86258cfc6b60bbc63866b4b0613e7fbe8f21ea7e commit 86258cfc6b60bbc63866b4b0613e7fbe8f21ea7e Author: Fabio Tirelo <ftirelo@chromium.org> Date: Mon Oct 22 19:15:59 2018 [Merge M71][AF] Use 'Manage...' as footer string when popup type is unspecified Bug: 893592 Change-Id: I619bb47295302ba74301c327372206269c12bf23 Reviewed-on: https://chromium-review.googlesource.com/c/1293729 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601618}(cherry picked from commit 65c419d84ae1f69966f168f4b298b3a4dfd30495) Reviewed-on: https://chromium-review.googlesource.com/c/1294413 Cr-Commit-Position: refs/branch-heads/3578@{#238} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/86258cfc6b60bbc63866b4b0613e7fbe8f21ea7e/components/autofill/core/browser/autofill_external_delegate.cc
,
Oct 23
Verified the fix on Mac 10.13.1, Windows-10 and Ubuntu 14.04 using Chrome version 71.0.3578.20 and on 72.0.3589.0 as per the comment #0. Attaching screenshots for reference. Observed the Manage footer in the dropdown. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version 71.0.3559.6 Thanks...!!
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f761dc8735de6471b4e28a4280ac4985a78c551 commit 4f761dc8735de6471b4e28a4280ac4985a78c551 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Tue Oct 23 15:09:10 2018 [Merge M70][AF] Use 'Manage...' as footer string when popup type is unspecified Bug: 893592 Change-Id: I619bb47295302ba74301c327372206269c12bf23 Reviewed-on: https://chromium-review.googlesource.com/c/1293729 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601618}(cherry picked from commit 65c419d84ae1f69966f168f4b298b3a4dfd30495) Reviewed-on: https://chromium-review.googlesource.com/c/1294573 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#1033} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/4f761dc8735de6471b4e28a4280ac4985a78c551/components/autofill/core/browser/autofill_external_delegate.cc
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f761dc8735de6471b4e28a4280ac4985a78c551 Commit: 4f761dc8735de6471b4e28a4280ac4985a78c551 Author: ftirelo@chromium.org Commiter: ftirelo@chromium.org Date: 2018-10-23 15:09:10 +0000 UTC [Merge M70][AF] Use 'Manage...' as footer string when popup type is unspecified Bug: 893592 Change-Id: I619bb47295302ba74301c327372206269c12bf23 Reviewed-on: https://chromium-review.googlesource.com/c/1293729 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601618}(cherry picked from commit 65c419d84ae1f69966f168f4b298b3a4dfd30495) Reviewed-on: https://chromium-review.googlesource.com/c/1294573 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#1033} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86258cfc6b60bbc63866b4b0613e7fbe8f21ea7e Commit: 86258cfc6b60bbc63866b4b0613e7fbe8f21ea7e Author: ftirelo@chromium.org Commiter: ftirelo@chromium.org Date: 2018-10-22 19:15:59 +0000 UTC [Merge M71][AF] Use 'Manage...' as footer string when popup type is unspecified Bug: 893592 Change-Id: I619bb47295302ba74301c327372206269c12bf23 Reviewed-on: https://chromium-review.googlesource.com/c/1293729 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601618}(cherry picked from commit 65c419d84ae1f69966f168f4b298b3a4dfd30495) Reviewed-on: https://chromium-review.googlesource.com/c/1294413 Cr-Commit-Position: refs/branch-heads/3578@{#238} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 23
Fabio: can you please verify this in M71 dev as well? Version:71.0.3578.20
,
Oct 24
Re C#21: abdulsyed@, this has already been verified on M71 dev 71.0.3578.20(...Comment#21) Verified the fix on Mac 10.13.1, Windows-10 and Ubuntu 14.04 using Chrome version 70.0.3538.77 as per the comment #0. Attaching screenshot for reference. Observed the Manage footer in the dropdown. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version 71.0.3559.6 Thanks...!!
,
Oct 24
++Correction: Verified on Dev M71 71.0.3578.20 (....comment#17) Thanks!
,
Oct 24
,
Oct 25
|
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by ftirelo@chromium.org
, Oct 9137 KB
137 KB View Download