New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 893589 link

Starred by 1 user
Status: Fixed
Owner:
feuunk@chromium.org
Closed: Oct 9
Cc:
butter-team@google.com
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Wallet metadata is broken for full sync users when Butter is enabled

Project Member Reported by feuunk@google.com, Oct 9 
When the butter feature flag is enabled, chrome_sync_client always uses the account storage for the metadata syncable service. This means that metadata for regular sync (when wallet uses the profile storage) is broken.

I ran into this while testing the fix for crbug.com/890709.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f6065717084a42b498c83c5d6d99afd64f6bbc7

commit 4f6065717084a42b498c83c5d6d99afd64f6bbc7
Author: Florian Uunk <feuunk@chromium.org>
Date: Tue Oct 09 15:17:58 2018

Syncable services always use profile storage

Syncable services don't support ephemeral storage, so we should not try
to use the account storage for them. Instead, the USS bridges will be
capable of doing this.

Using the account storage caused wallet metadata sync to be broken for
full sync users when the enable-autofill-account-wallet-storage flag was
on.

Bug:  893589 
Change-Id: I4f943a2f654e519873e2390bb1fabfbada3c48f0
Reviewed-on: https://chromium-review.googlesource.com/c/1270959
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597921}
[modify] https://crrev.com/4f6065717084a42b498c83c5d6d99afd64f6bbc7/chrome/browser/sync/chrome_sync_client.cc

Comment 2 by feuunk@google.com, Oct 9

Status: Fixed (was: Started)
►

Sign in to add a comment