Record PageVisits UseCounter in UKM |
|
Issue descriptionIn UKM, we need a way to compute the % of page loads where a use counter is being used. In UMA, this is done by recording the PageVisits counter, which is incremented on every page load. For UKM, for consistencty, we should do the same.
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e48e3628e14fb36ceac4454cf1e7fb40beaf9377 commit e48e3628e14fb36ceac4454cf1e7fb40beaf9377 Author: Bryan McQuade <bmcquade@chromium.org> Date: Tue Oct 09 16:36:27 2018 Record the PageVisits WebFeature in UKM. In UMA, in order to compute the percent of page loads where a usecounter is observed, we record the PageVisits counter, which is incremented on every page load commit. This change updates our UKM usecounter recording to do the same, so we can compute the percent of pageloads where a usecounter is observed in UKM. Bug: 893555 Change-Id: I30f14f564caf7600bf23239c4378c2d516303d20 Reviewed-on: https://chromium-review.googlesource.com/c/1270336 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#597943} [modify] https://crrev.com/e48e3628e14fb36ceac4454cf1e7fb40beaf9377/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer.cc [modify] https://crrev.com/e48e3628e14fb36ceac4454cf1e7fb40beaf9377/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/e48e3628e14fb36ceac4454cf1e7fb40beaf9377/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc |
|
►
Sign in to add a comment |
|
Comment 1 by bmcquade@chromium.org
, Oct 9