New issue
Advanced search Search tips

Issue 893550 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

[LayoutNG] Ellipsis should be applied after applying relative position offset

Project Member Reported by mstensho@chromium.org, Oct 9

Issue description

external/wpt/css/css-ui/text-overflow-015.html fails because of this bug.

The spec is clear about this:
http://www.w3.org/TR/css3-ui/#ellipsing-details
 
Components: Blink>Layout
Labels: -Type-Bug -Pri-2 Pri-3 Type-Task
Thank you for filing this. This is in the sheet:
https://docs.google.com/spreadsheets/d/1fyxi-EPtDyzVtr-4h0ruZfg492l3Rl_sFgHfiQCwIEc/edit#gid=0
Status: Available (was: Untriaged)
fast/text/ellipsis-in-relative-inline-right.html
fast/text/ellipsis-in-relative-inline.html

Filled in this bug# to the sheet.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b019ab9d5282823197f0a259d4ec11a43fa7059c

commit b019ab9d5282823197f0a259d4ec11a43fa7059c
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Tue Oct 09 13:09:43 2018

[LayoutNG] Associate ellipsis+relpos test failure with designated bug.

TBR=kojii@chromium.org

Bug: 893550
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I5ce6ed3a5d6b5b9b429eab1506b0af44a408e2b7
Reviewed-on: https://chromium-review.googlesource.com/c/1270835
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597893}
[modify] https://crrev.com/b019ab9d5282823197f0a259d4ec11a43fa7059c/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64e69875694e4654ababe4208039584755bd2d8c

commit 64e69875694e4654ababe4208039584755bd2d8c
Author: Ian Kilpatrick <ikilpatrick@chromium.org>
Date: Tue Jan 08 03:36:47 2019

[LayoutNG] Remove legacy position:relative ellipsising behaviour.

This removes changes performed in:
https://chromium-review.googlesource.com/563625

Previously the existing layout system would account for the value of any
positon:relative offsets, to produce the final ellipsis.

There is only one wpt test case, and doesn't account for nearly the
wide range of potential edge-cases that can occur. E.g.
https://www.software.hixie.ch/utilities/js/live-dom-viewer/?saved=6485

Bug: 893550
Change-Id: Iecb688a658f5c96fadf1074cc8943ec96e2517e9
Reviewed-on: https://chromium-review.googlesource.com/c/1392175
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620605}
[modify] https://crrev.com/64e69875694e4654ababe4208039584755bd2d8c/third_party/blink/renderer/core/layout/layout_block_flow_line.cc
[modify] https://crrev.com/64e69875694e4654ababe4208039584755bd2d8c/third_party/blink/renderer/core/layout/layout_box.h
[modify] https://crrev.com/64e69875694e4654ababe4208039584755bd2d8c/third_party/blink/renderer/core/layout/line/inline_flow_box.cc
[modify] https://crrev.com/64e69875694e4654ababe4208039584755bd2d8c/third_party/blink/renderer/core/layout/line/inline_flow_box.h
[modify] https://crrev.com/64e69875694e4654ababe4208039584755bd2d8c/third_party/blink/web_tests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/64e69875694e4654ababe4208039584755bd2d8c/third_party/blink/web_tests/TestExpectations
[delete] https://crrev.com/7c8b7f00ff2c9c7e5673da536258f99452714d4c/third_party/blink/web_tests/fast/text/ellipsis-in-relative-inline-right.html
[delete] https://crrev.com/7c8b7f00ff2c9c7e5673da536258f99452714d4c/third_party/blink/web_tests/fast/text/ellipsis-in-relative-inline.html
[delete] https://crrev.com/7c8b7f00ff2c9c7e5673da536258f99452714d4c/third_party/blink/web_tests/platform/linux/fast/text/ellipsis-in-relative-inline-expected.png
[delete] https://crrev.com/7c8b7f00ff2c9c7e5673da536258f99452714d4c/third_party/blink/web_tests/platform/linux/fast/text/ellipsis-in-relative-inline-right-expected.png
[delete] https://crrev.com/7c8b7f00ff2c9c7e5673da536258f99452714d4c/third_party/blink/web_tests/platform/mac-mac10.10/fast/text/ellipsis-in-relative-inline-expected.png
[delete] https://crrev.com/7c8b7f00ff2c9c7e5673da536258f99452714d4c/third_party/blink/web_tests/platform/mac-mac10.10/fast/text/ellipsis-in-relative-inline-right-expected.png
[delete] https://crrev.com/7c8b7f00ff2c9c7e5673da536258f99452714d4c/third_party/blink/web_tests/platform/mac-mac10.12/fast/text/ellipsis-in-relative-inline-expected.png
[delete] https://crrev.com/7c8b7f00ff2c9c7e5673da536258f99452714d4c/third_party/blink/web_tests/platform/mac-mac10.12/fast/text/ellipsis-in-relative-inline-right-expected.png
[delete] https://crrev.com/7c8b7f00ff2c9c7e5673da536258f99452714d4c/third_party/blink/web_tests/platform/mac/fast/text/ellipsis-in-relative-inline-expected.png
[delete] https://crrev.com/7c8b7f00ff2c9c7e5673da536258f99452714d4c/third_party/blink/web_tests/platform/mac/fast/text/ellipsis-in-relative-inline-right-expected.png
[delete] https://crrev.com/7c8b7f00ff2c9c7e5673da536258f99452714d4c/third_party/blink/web_tests/platform/win/fast/text/ellipsis-in-relative-inline-expected.png
[delete] https://crrev.com/7c8b7f00ff2c9c7e5673da536258f99452714d4c/third_party/blink/web_tests/platform/win/fast/text/ellipsis-in-relative-inline-right-expected.png
[delete] https://crrev.com/7c8b7f00ff2c9c7e5673da536258f99452714d4c/third_party/blink/web_tests/platform/win7/fast/text/ellipsis-in-relative-inline-expected.png
[delete] https://crrev.com/7c8b7f00ff2c9c7e5673da536258f99452714d4c/third_party/blink/web_tests/platform/win7/fast/text/ellipsis-in-relative-inline-right-expected.png

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/837b8e19e776e4849081d88af42c5d2726b735ad

commit 837b8e19e776e4849081d88af42c5d2726b735ad
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Fri Jan 18 11:18:05 2019

[LayoutNG] text-overflow-015.html fails in both engines now.

TBR=ikilpatrick@chromium.org,kojii@chromium.org

Bug: 893550
Change-Id: I7f5cf01c216bc4172d7752ee226a5e36eec2f335
Reviewed-on: https://chromium-review.googlesource.com/c/1420839
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624071}
[modify] https://crrev.com/837b8e19e776e4849081d88af42c5d2726b735ad/third_party/blink/web_tests/FlagExpectations/enable-blink-features=LayoutNG

Sign in to add a comment