New issue
Advanced search Search tips

Issue 893548 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'Gallery' icon is seen blur in Files App context Menu

Project Member Reported by mmanchala@chromium.org, Oct 9

Issue description

Chrome Version: 71.0.3572.0/11140.0.0 dev-channel Daisy,Reks and Kip
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> press 'Ctrl+F5(Overview Mode Button)' for screenshot -> go to Files App-> Right click for context menu
(2)Now observe 'Gallery' icon is seen blur available at first option in context menu 
(Please refer Video and Screenshot)

Expected: 'Gallery' icon should not be seen blur in context Menu
Actual: Instead 'Gallery' icon is seen blur

This is Regression Issue as same is working fine in M-70


 
Actual_BlurGallerYIcon.mp4
5.9 MB View Download
Actual_BlurGalleryICon.jpg
79.8 KB View Download
Expected_GalleryIcon.jpg
137 KB View Download
Expected_GalleryIcon.mp4
9.4 MB View Download
Cc: tapted@chromium.org pcovell@chromium.org
Components: Platform>Apps>PhotoEditor
tapted@ - Do you know if we changed the Gallery icon recently?
Owner: kaznacheev@chromium.org
Status: Assigned (was: Untriaged)
I confirm that I can reproduce locally.

From gallery icons history, I traced to this CL:
https://chromium-review.googlesource.com/1243680

Assigning to CL owner.
Status: Started (was: Assigned)
Apparently removing a 32px icon was not as safe as I assumed. Preparing a CL that restores all icon sizes that were previously used. Will need new icon files for these sizes, requesting them from UX.
Owner: sgabr...@chromium.org
Status: Assigned (was: Started)
Cc: gogoy@google.com
Labels: -M-71 M-72
Labels: Files-Fixit-2018
Owner: kaznacheev@chromium.org
All assets for the gallery app attached.
files_gallery.zip
94.3 KB Download
Owner: sgabr...@chromium.org
These work great, thank!
However, I need more sizes for the other 3 icon sets (files app, video player, audio player). I am sorry, I should have been clearer.
All assets attached
assets.zip
364 KB Download
Owner: kaznacheev@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c

commit e9dca2f22e8863e5f8ec15ca228531f29cec5d5c
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Thu Nov 15 15:30:59 2018

Bring back full range of icon sizes for Files app

Return to using icon sizes from before crrev.com/c/1243680.
This should exclude a possibility of any regressions.
Updating the icon look to the latest UI design.

Bug:  893548 
Test: steps in bug
Change-Id: I596750416a5c87f0239119086b4db84554f3d3a0
Reviewed-on: https://chromium-review.googlesource.com/c/1336188
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608373}
[add] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/audio_player/icons/audio-player-256.png
[add] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/audio_player/icons/audio-player-32.png
[add] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/audio_player/icons/audio-player-64.png
[add] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/audio_player/icons/audio-player-96.png
[modify] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/audio_player/manifest.json
[add] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/file_manager/common/images/icon256.png
[add] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/file_manager/common/images/icon32.png
[add] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/file_manager/common/images/icon64.png
[modify] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/file_manager/manifest.json
[modify] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/file_manager_resources.grd
[add] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/gallery/images/icon256.png
[add] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/gallery/images/icon32.png
[add] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/gallery/images/icon64.png
[add] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/gallery/images/icon96.png
[modify] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/gallery/manifest.json
[add] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/video_player/images/icon/video-player-256.png
[add] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/video_player/images/icon/video-player-32.png
[add] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/video_player/images/icon/video-player-64.png
[add] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/video_player/images/icon/video-player-96.png
[modify] https://crrev.com/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c/ui/file_manager/video_player/manifest.json

Status: Fixed (was: Started)

Sign in to add a comment