New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 893527 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Dynamic Type: The empty article string should support Dynamic Type

Project Member Reported by gambard@chromium.org, Oct 9

Issue description

The "That’s all for now Your suggested articles appear here" string displayed when the article sections of the NTP is empty should support Dynamic Type.
 
Labels: zine-triaged
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c245af46fb47db066cbdc99a5f578e2b94b2ca2f

commit c245af46fb47db066cbdc99a5f578e2b94b2ca2f
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Oct 12 08:35:26 2018

[iOS] Use Dynamic Type in the empty NTP cell

This CL adds Dynamic Type to the cell displayed when the NTP's articles
section is empty.

Bug:  893527 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: If36d6ece1eaac888f606f7730de379aec11ba6be
Reviewed-on: https://chromium-review.googlesource.com/c/1273536
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599144}
[modify] https://crrev.com/c245af46fb47db066cbdc99a5f578e2b94b2ca2f/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
https://drive.google.com/file/d/1n8Ortdxetmazb79tZE-FA0IfWzCglNuY/view?usp=sharing
verified on iPad Pro 12'9 iOS 11.4.1, iPhone XSMax iOS 12 

On build 72.0.3582.0 Canary

Sign in to add a comment