New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 893525 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocked on:
issue 895804



Sign in to add a comment

Dynamic Type: Articles suggestions should support Dynamic type

Project Member Reported by gambard@chromium.org, Oct 9

Issue description

When the user is choosing the "accessibility" as preferred content size category, the article layout should change to having everything on one column.
i.e. the article's image should be above the title, not on the side.
 
Labels: zine-triaged
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a440a0de6b8a41902a9996325713b5bc39a7404

commit 8a440a0de6b8a41902a9996325713b5bc39a7404
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Oct 11 16:57:29 2018

[iOS] Change the Articles layout on Accessibility ContentSize

When the user is picking a preferred ContentSize from the
"accessibility" bucket, the layout of the article should be different.

Bug:  893525 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8686c33ef80775d799e6fbb8752ee4c011798154
Reviewed-on: https://chromium-review.googlesource.com/c/1273147
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598805}
[modify] https://crrev.com/8a440a0de6b8a41902a9996325713b5bc39a7404/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.h
[modify] https://crrev.com/8a440a0de6b8a41902a9996325713b5bc39a7404/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.mm
[modify] https://crrev.com/8a440a0de6b8a41902a9996325713b5bc39a7404/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm
[modify] https://crrev.com/8a440a0de6b8a41902a9996325713b5bc39a7404/ios/chrome/browser/ui/uikit_ui_util.h
[modify] https://crrev.com/8a440a0de6b8a41902a9996325713b5bc39a7404/ios/chrome/browser/ui/uikit_ui_util.mm
[modify] https://crrev.com/8a440a0de6b8a41902a9996325713b5bc39a7404/ios/showcase/content_suggestions/sc_content_suggestions_item.mm

Status: Fixed (was: Assigned)
Blockedon: 895804
Tested in:

App Version: 72.0.3582.0 canary
Devices: iPhone X, iPad Mini
iOS Versions: 11.4.1, 12.0, 10.3.3

Article image is aligned above the title in iPhones but in case of iPads article suggestions are misaligned. Filed a separate bug https://crbug.com/895804
Status: Verified (was: Fixed)
Marking this as 'Verified' since iOS 10.3.3 is not supported for M72. 

As we have already filed a separate bug for iOS 10.3.3(https://crbug.com/895804), we will reverify once it is merged to M71.
Cc: subhashi...@chromium.org

Sign in to add a comment