New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 893524 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Dynamic Type: Have the Section Title for the NTP supporting Dynamic Type

Project Member Reported by gambard@chromium.org, Oct 9

Issue description

When the user is choosing the "accessibility" as preferred content size category, the title should be on two lines ("Articles for you" and "hide").

 
Components: UI>Browser>NewTabPage UI>Accessibility
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/755d6f957abd6af5b8bbbf045ac622b92fea60a5

commit 755d6f957abd6af5b8bbbf045ac622b92fea60a5
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Oct 12 08:35:30 2018

[iOS] Support Accessibility ContentSize on NTP header

This CL changes the header of the "Articles for you" section of the NTP
to have a better support for the "accessibility" categories of preferred
content size chosen by the user.

Bug:  893524 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I56ed6f89e7767697083c3e8e5d5a796db3066aee
Reviewed-on: https://chromium-review.googlesource.com/c/1273522
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599145}
[modify] https://crrev.com/755d6f957abd6af5b8bbbf045ac622b92fea60a5/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_articles_header_item.mm
[modify] https://crrev.com/755d6f957abd6af5b8bbbf045ac622b92fea60a5/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
verified on iPad Pro 12'9 iOS 11.4.1, iPhone XSMax iOS 12 On build 72.0.3582.0 Canary

Sign in to add a comment