New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 893522 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocked on:
issue 892145



Sign in to add a comment

Dynamic Type: Have NTP fake omnibox scaling up with Dynamic Type

Project Member Reported by gambard@chromium.org, Oct 9

Issue description

The fake omnibox displayed on the NTP should behave in the same way as the real omnibox.
 
Labels: zine-triaged
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a20f19dd20b7835c9fae0e19d5c0b2cc048ae9cd

commit a20f19dd20b7835c9fae0e19d5c0b2cc048ae9cd
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Nov 06 15:23:33 2018

[iOS] Refactor NTP header

This CL refactors the NTP header, changing the name of the variables
to have something more understandable.
It also changes the creation of the subviews of the fake omnibox, moving
it to the view.

Bug:  893522 
Change-Id: Ib03f6e25a303016fdb6296011f05153667cfa2c3
Reviewed-on: https://chromium-review.googlesource.com/c/1309836
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605682}
[modify] https://crrev.com/a20f19dd20b7835c9fae0e19d5c0b2cc048ae9cd/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h
[modify] https://crrev.com/a20f19dd20b7835c9fae0e19d5c0b2cc048ae9cd/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm
[modify] https://crrev.com/a20f19dd20b7835c9fae0e19d5c0b2cc048ae9cd/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.h
[modify] https://crrev.com/a20f19dd20b7835c9fae0e19d5c0b2cc048ae9cd/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/a20f19dd20b7835c9fae0e19d5c0b2cc048ae9cd/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/a20f19dd20b7835c9fae0e19d5c0b2cc048ae9cd/ios/chrome/browser/ui/ntp/new_tab_page_header_constants.h
[modify] https://crrev.com/a20f19dd20b7835c9fae0e19d5c0b2cc048ae9cd/ios/chrome/browser/ui/ntp/new_tab_page_header_constants.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a9a3dc9e3c68a1f501215703548c48745cfdcfe

commit 9a9a3dc9e3c68a1f501215703548c48745cfdcfe
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Nov 13 10:13:50 2018

[iOS] Support Dynamic Type in NTP fakebox

This CL changes the NTP fakebox so it supports Dynamic Type, in the
same way as the toolbar is supporting it.

Bug:  893522 
Change-Id: Icd1e90374bcd071ab77516147891882bd4af5fa7
Reviewed-on: https://chromium-review.googlesource.com/c/1307408
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607542}
[modify] https://crrev.com/9a9a3dc9e3c68a1f501215703548c48745cfdcfe/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/9a9a3dc9e3c68a1f501215703548c48745cfdcfe/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h
[modify] https://crrev.com/9a9a3dc9e3c68a1f501215703548c48745cfdcfe/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm
[modify] https://crrev.com/9a9a3dc9e3c68a1f501215703548c48745cfdcfe/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/9a9a3dc9e3c68a1f501215703548c48745cfdcfe/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/9a9a3dc9e3c68a1f501215703548c48745cfdcfe/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm
[modify] https://crrev.com/9a9a3dc9e3c68a1f501215703548c48745cfdcfe/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/9a9a3dc9e3c68a1f501215703548c48745cfdcfe/ios/chrome/browser/ui/ntp/new_tab_page_header_constants.h
[modify] https://crrev.com/9a9a3dc9e3c68a1f501215703548c48745cfdcfe/ios/chrome/browser/ui/ntp/new_tab_page_header_constants.mm
[modify] https://crrev.com/9a9a3dc9e3c68a1f501215703548c48745cfdcfe/ios/chrome/browser/ui/toolbar/primary_toolbar_view_controller.mm
[modify] https://crrev.com/9a9a3dc9e3c68a1f501215703548c48745cfdcfe/ios/chrome/browser/ui/toolbar/toolbar_utils.h
[modify] https://crrev.com/9a9a3dc9e3c68a1f501215703548c48745cfdcfe/ios/chrome/browser/ui/toolbar/toolbar_utils.mm

Status: Fixed (was: Assigned)

Sign in to add a comment