Issue metadata
Sign in to add a comment
|
Regression: Unwanted background screen appears while rotating the app launcher |
||||||||||||||||||||||
Issue descriptionChrome Version: 71.0.3572.0/11140.0.0 dev channel Kip, Reks & Daisy OS:Chrome OS What steps will reproduce the problem? (1)Sign into user >> Keep open App launcher in max mode (2)Rotate the display and observe Actual: Unwanted background pages appears while rotating the app launcher Expected: No such unwanted traces of background pages should appear while rotating the app launcher This is a Regression issue as same is working fine in 71.0.3567.0/11137.0.0 dev Attached the screencast for reference..
,
Oct 9
Is there any change recently to move the app_list_view layer to other window containers?
,
Oct 9
+weidongg who might know.
,
Oct 9
Re #2, I don't think app_list_view is moved to another window container in clamshell mode. It is only moved to https://cs.chromium.org/chromium/src/ash/public/cpp/shell_window_ids.h?q=AppListTabletMode&g=0&l=61 in tablet mode.
,
Oct 9
Hi newcomer@, can you find some one bisecting the bug? Thanks. I am working on other P0 Shelf blur bug right now.
,
Oct 9
I'm gardening and also working on a P-0 :P. weidongg, do you have cycles?
,
Oct 9
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc343a32fdbbb756a32ef694ab5aebe06f934908 commit bc343a32fdbbb756a32ef694ab5aebe06f934908 Author: Weidong Guo <weidongg@chromium.org> Date: Wed Oct 10 17:04:12 2018 Fix unwanted animation that occurs after rotating screen Changes: Set the widget bounds after display metrics change based on the current app list state instead of using initial widget bounds. Bug: 893521 Change-Id: I370080e6822e2eb20aa391651b1de6737e0b90b0 Reviewed-on: https://chromium-review.googlesource.com/c/1272238 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#598370} [modify] https://crrev.com/bc343a32fdbbb756a32ef694ab5aebe06f934908/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/bc343a32fdbbb756a32ef694ab5aebe06f934908/ash/app_list/views/app_list_view.h
,
Oct 10
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86efdf5808eabd88b7a75bd295cd3bdafc58b8b9 commit 86efdf5808eabd88b7a75bd295cd3bdafc58b8b9 Author: Weidong Guo <weidongg@chromium.org> Date: Thu Oct 11 18:56:59 2018 Fix close animation target y issue This is a follow up fix for go/cgcl/1272238. Bug: 893521 Change-Id: I3ea08e13eb0909e7b216448d9cdad2761c5e4647 Reviewed-on: https://chromium-review.googlesource.com/c/1277385 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#598873} [modify] https://crrev.com/86efdf5808eabd88b7a75bd295cd3bdafc58b8b9/ash/app_list/views/app_list_view.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by newcomer@chromium.org
, Oct 9Status: Assigned (was: Untriaged)