Regression : Media controls flicker when user increase/decrease volume using slider.
Reported by
avsha...@etouch.net,
Oct 9
|
||
Issue descriptionChrome Version : 71.0.3574.0 (Official Build) 90c2ba94f7158703b83270aa5db0203821a5fcca-refs/branch-heads/3574@{#1} 32/64 bit OS : Windows(7, 8, 8.1 ,10), Mac(10.12.6, 10.13.1, 10.14.1, 10.13.6), Linux(14.04 LTS) Test URL : https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html What steps will reproduce the problem? 1. Launch chrome, navigate to above URL, set 'Width' to 250 and play the video. 2. Hover on 'Volume' icon and try to increase/decrease volume using slider. 3. Observe the media controls. Actual Result : Media controls flicker when user increase/decrease volume using slider. Expected Result : Media controls should not flicker when user increase or decrease volume using slider. This is a regression issue broken in ‘M-71’ and below is the 'change log' information: Good Build : 71.0.3573.0 (Revision : 597470) Bad Build : 71.0.3574.0 (Revision : 597692) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/71.0.3573.0..71.0.3574.0?pretty=fuller&n=10000 Suspect: r597483 ? steimel@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Unable to provide 'per-revision' bisect as it shows "RuntimeError : We don't have enough builds to bisect..." error message for above range. (tried on other machines but still getting the same error again) 2. Tried performing 'Chromium bisect' but the issue is not reproducible in Chromium builds. 3. Hence provided manual suspect through change log. Thank you..!
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/476ae6d661472eedd8b03be75b28760fd2ec266d commit 476ae6d661472eedd8b03be75b28760fd2ec266d Author: Tommy Steimel <steimel@chromium.org> Date: Tue Oct 09 23:47:19 2018 [Media Controls] Prevent volume slider from moving during use This CL adds a check in OnVolumeChange to only cause a controls positioning update if the volume slider is not currently being used. This prevents an issue where the controls constantly shift while the slider is in use on smaller controls. Bug: 893510 Change-Id: I7008f83f6435f0704c06651d54ac98d84ef31ab2 Reviewed-on: https://chromium-review.googlesource.com/c/1271397 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#598136} [add] https://crrev.com/476ae6d661472eedd8b03be75b28760fd2ec266d/third_party/WebKit/LayoutTests/media/controls/volume-slider-doesnt-shift-on-smaller-controls.html [modify] https://crrev.com/476ae6d661472eedd8b03be75b28760fd2ec266d/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/476ae6d661472eedd8b03be75b28760fd2ec266d/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
,
Oct 9
|
||
►
Sign in to add a comment |
||
Comment 1 by steimel@chromium.org
, Oct 9