New issue
Advanced search Search tips

Issue 893506 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: virtual/threaded/fast/events/pinch/pinch-zoom-pan-position-fixed.html

Blocking:
issue 783034



Sign in to add a comment

virtual/threaded/fast/events/pinch/pinch-zoom-pan-position-fixed.html is flaky

Project Member Reported by Findit, Oct 9

Issue description


Flaky test: virtual/threaded/fast/events/pinch/pinch-zoom-pan-position-fixed.html
Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=407060f59dd89610
Test output log: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%281%29/84460
Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/I7cb96177df54729b24f5414c897cca97456e9484
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyyQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKSAWNocm9taXVtLndpbi9XaW43IFRlc3RzICgxKS84NDQ2MC93ZWJraXRfbGF5b3V0X3Rlc3RzL2RtbHlkSFZoYkM5MGFISmxZV1JsWkM5bVlYTjBMMlYyWlc1MGN5OXdhVzVqYUM5d2FXNWphQzE2YjI5dExYQmhiaTF3YjNOcGRHbHZiaTFtYVhobFpDNW9kRzFzDAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20virtual/threaded/fast/events/pinch/pinch-zoom-pan-position-fixed.html&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyyQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKSAWNocm9taXVtLndpbi9XaW43IFRlc3RzICgxKS84NDQ2MC93ZWJraXRfbGF5b3V0X3Rlc3RzL2RtbHlkSFZoYkM5MGFISmxZV1JsWkM5bVlYTjBMMlYyWlc1MGN5OXdhVzVqYUM5d2FXNWphQzE2YjI5dExYQmhiaTF3YjNOcGRHbHZiaTFtYVhobFpDNW9kRzFzDAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw
 
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f50ce7c63326a95b47f9217571bea98b8d5ff53

commit 4f50ce7c63326a95b47f9217571bea98b8d5ff53
Author: Olga Sharonova <olka@chromium.org>
Date: Tue Oct 09 12:17:09 2018

Revert "Reland "synthetic gesture: Allow high-frequency dispatch.""

This reverts commit a66784e0fd71f686f1d7152902137619608c6c80.

Reason for revert: FindIt suspects it caused flakiness of virtual/threaded/fast/events/pinch/pinch-zoom-pan-position-fixed.html

Bug: 893506

Original change's description:
> Reland "synthetic gesture: Allow high-frequency dispatch."
> 
> This is a reland of 581a728b2665c85e466408c2d53371abcb7f763e
> Fix for the revert in http://crrev.com/c/1264175
> 
> Original change's description:
> > synthetic gesture: Allow high-frequency dispatch.
> >
> > For synthesized scroll/drag/pinch gestures, dispatch the events
> > at a high frequency (120Hz) so that there's at least one event in
> > each frame. Dispatching events at a lower frequency (60Hz) means
> > the timer can go out of sync with begin-frame, and so there can
> > be frames where there was to event dispatch. Our telemetry code
> > reports this as jank, which is incorrect. Dispatching at a higher
> > frequency for the scroll/drag/pinch gestures resolves this issue.
> >
> > BUG= 783034 
> >
> > Change-Id: I1102f76ed743231cbb10fdb872e8c66f895fa223
> > Reviewed-on: https://chromium-review.googlesource.com/c/1255152
> > Reviewed-by: Victor Miura <vmiura@chromium.org>
> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> > Reviewed-by: Lan Wei <lanwei@chromium.org>
> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#596507}
> 
> TBR=vmiura@, nzolghadr@, lanwei@ since reland without changes
> 
> Bug:  783034 
> Change-Id: I7cb96177df54729b24f5414c897cca97456e9484
> Reviewed-on: https://chromium-review.googlesource.com/c/1263882
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#597137}

TBR=sadrul@chromium.org,vmiura@chromium.org,lanwei@chromium.org,nzolghadr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  783034 
Change-Id: I9baf489175adae82a15777427640f6eff7e2c76d
Reviewed-on: https://chromium-review.googlesource.com/c/1270717
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597886}
[modify] https://crrev.com/4f50ce7c63326a95b47f9217571bea98b8d5ff53/content/browser/renderer_host/input/synthetic_gesture.cc
[modify] https://crrev.com/4f50ce7c63326a95b47f9217571bea98b8d5ff53/content/browser/renderer_host/input/synthetic_gesture.h
[modify] https://crrev.com/4f50ce7c63326a95b47f9217571bea98b8d5ff53/content/browser/renderer_host/input/synthetic_gesture_controller.cc
[modify] https://crrev.com/4f50ce7c63326a95b47f9217571bea98b8d5ff53/content/browser/renderer_host/input/synthetic_gesture_controller.h
[modify] https://crrev.com/4f50ce7c63326a95b47f9217571bea98b8d5ff53/content/browser/renderer_host/input/synthetic_pointer_action.cc
[modify] https://crrev.com/4f50ce7c63326a95b47f9217571bea98b8d5ff53/content/browser/renderer_host/input/synthetic_pointer_action.h
[modify] https://crrev.com/4f50ce7c63326a95b47f9217571bea98b8d5ff53/content/browser/renderer_host/input/synthetic_tap_gesture.cc
[modify] https://crrev.com/4f50ce7c63326a95b47f9217571bea98b8d5ff53/content/browser/renderer_host/input/synthetic_tap_gesture.h

Components: Blink>Input
Cc: bokan@chromium.org sahel@chromium.org sadrul@chromium.org nzolghadr@chromium.org
It looks like there's one pixel of red background showing at the top in the failing case. This looks like an actual bug somewhere? Increasing the frequency of event-dispatch should not cause this, right? Perhaps some issues with the event-coalescing?

/cc some input/scrolling folks.
Labels: -Sheriff-Chromium
Removing from sheriff queue since the CL is reverted and bug has an owner. (If flakiness persists, findIt will add it back to the queue.)
Blocking: 783034
Cc: vmi...@chromium.org
Owner: sadrul@chromium.org
Status: Started (was: Untriaged)
I am putting in a short-term workaround: https://chromium-review.googlesource.com/c/chromium/src/+/1271017

The real issue is crbug.com/893608
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b72d3b61ffa3e8d27e9bbfed0cd0427759a2f77

commit 3b72d3b61ffa3e8d27e9bbfed0cd0427759a2f77
Author: Sadrul Chowdhury <sadrul@chromium.org>
Date: Tue Oct 09 16:20:50 2018

blink gesture: Increase the 'instant speed' for scroll gesture.

Double the 'instant speed' for scroll gestures, so that when the input
dispatch frequency goes from 60Hz to 120Hz ( crbug.com/783034 ), some
layout tests do not become flaky.

Bug: 893608, 893506

Change-Id: Id8f4491b43088fac3b1a2cf70888a1a10b8ba774
Reviewed-on: https://chromium-review.googlesource.com/c/1271017
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597938}
[modify] https://crrev.com/3b72d3b61ffa3e8d27e9bbfed0cd0427759a2f77/third_party/WebKit/LayoutTests/resources/gesture-util.js

Sign in to add a comment