Migrate capture_unittests to Tast and run it on Chrome CQ and PFQ |
||||||
Issue descriptionCapture_unittests [1] is a test which runs binary unittests on DUT. We'd like to run this test via Tast. The benefits of this migration are: - We can easily manage where capture_unittests will run (e.g. CQ, PFQ). - We can run some tests only on devices that have a camera, by using Tast's autotest-capability dependency feature. (cf. [2]) This migration should be done in a similar way to video_VideoDecodeAccelerator [3]. See go/cros-camera-waterfall-test for the original context. [1] https://cs.chromium.org/chromium/src/media/capture/BUILD.gn?l=306&rcl=07d128a1f0526df85d6e23488177409d1c6f2af6 [2] http://crbug.com/893494 [3] http://crbug.com/889496
,
Oct 15
crrev.com/c/1256775 was merged. crbug.com/889496 doesn't block this issue now? You can pre-install capture_unittests by adding it to chrome-binary-tests and chromeos-chrome.
,
Oct 15
Ah, I am going to write a common package in tast to run a binary test.. OK, so it may be better to mark this blocked by crbug.com/889496.
,
Oct 29
,
Nov 1
Let me change the summary to make it match the goal I set in go/cros-camera-waterfall-test.
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1d8d2f290023f58a530b85dd0709f43c1a96efb0 commit 1d8d2f290023f58a530b85dd0709f43c1a96efb0 Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Fri Dec 21 02:06:18 2018 chromeos-chrome: Build capture_unittests and video_decode_accelerator_tests Build capture_unittests and video_decode_accelerator_tests to run it from a Tast test. capture_unittests is a binary test for video capture stack and it should be run on Chromium CQ and PFQ. video_decode_accelerator_tests is a new video acceleartion tests that will replace video_decode_accelerator_unittest in the future. BUG=chromium:893501, chromium:905954 TEST=locally build with CL:1375210 for amd64-generic Change-Id: Ifd83d7c99f9595bbdf3da6f407d47c5c7d7493f8 Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1383771 [modify] https://crrev.com/1d8d2f290023f58a530b85dd0709f43c1a96efb0/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Dec 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b123c70e3f49a1e51eb6152cf2826f89015c335d commit b123c70e3f49a1e51eb6152cf2826f89015c335d Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Sun Dec 23 09:32:19 2018 [Video Capture ChromeOS] Stop creating temp file outside of temp directory Before this commit, CameraConfigChromeOSTest.ParseSuccessfully test creates dummy conf file at working directory. This behavior will cause a failure when we run capture_unittests under a read-only directory. This situation will happen when we try to call capture_unittests via Tast. This CL makes the test to create a temporal file under temporal directory. Test: capture_unittests --test-launcher-jobs=1 on kevin Bug: 893501 Change-Id: Id03ef1c058cd1fd57e18d21dc096f371bf947025 Reviewed-on: https://chromium-review.googlesource.com/c/1382729 Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#618786} [modify] https://crrev.com/b123c70e3f49a1e51eb6152cf2826f89015c335d/media/capture/video/linux/camera_config_chromeos_unittest.cc
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f57106f5925e20252602bfbc7ac893e026d83a71 commit f57106f5925e20252602bfbc7ac893e026d83a71 Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Thu Jan 03 23:04:30 2019 chrome-binary-tests: Put capture_unittests/video_decode_accelerator_tests in test image Add Chrome's capture_unittests and video_decode_accelerator_tests to test image so taht we can run them via Tast tests. This commit should be merged after CL:1383771 and chorme uprev. BUG=chromium:893501, chromium:905954 TEST=build_package and tast run video.CaptureUnittests with CL:1375769 on amd64-generic VM Change-Id: I33e12e4b5523e54235ea5660295a1f4806ce4d71 Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1375210 Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/f57106f5925e20252602bfbc7ac893e026d83a71/chromeos-base/chrome-binary-tests/chrome-binary-tests-0.0.1.ebuild [rename] https://crrev.com/f57106f5925e20252602bfbc7ac893e026d83a71/chromeos-base/chrome-binary-tests/chrome-binary-tests-0.0.1-r4.ebuild
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/a20418c6e4e4595ab2024fe515335e787de829ce commit a20418c6e4e4595ab2024fe515335e787de829ce Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Tue Jan 08 03:40:50 2019 video: Add CaptureUnittests tast tests Add Tast wrapper for Chrome's capture_unittests. Though we don't have autotest version of this test, we want to have Tast version to run it on Chrome CQ and PFQ easily. BUG=chromium:893501 TEST=tast run DUT video.CaptureUnittests CQ-DEPEND=CL:1375210 Change-Id: I530124b8b767b9b47780e6a548ab92124f0cf4a7 Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1375769 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Dan Erat <derat@chromium.org> [add] https://crrev.com/a20418c6e4e4595ab2024fe515335e787de829ce/src/chromiumos/tast/local/bundles/cros/video/capture_unittests.go [add] https://crrev.com/a20418c6e4e4595ab2024fe515335e787de829ce/src/chromiumos/tast/local/bundles/cros/video/lib/vm/vm.go [modify] https://crrev.com/a20418c6e4e4595ab2024fe515335e787de829ce/src/chromiumos/tast/local/bundles/cros/video/webrtc/webrtc.go [add] https://crrev.com/a20418c6e4e4595ab2024fe515335e787de829ce/src/chromiumos/tast/local/bundles/cros/video/data/bear.mjpeg.external
,
Jan 9
,
Jan 10
tast.CaptureUnittests started running, but it's constantly failing on several devices. https://stainless.corp.google.com/search?view=matrix&row=model&col=build&first_date=2019-01-04&last_date=2019-01-10&test=tast.video.CaptureUnittest&status=FAIL&exclude_cts=false&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=false At least, there are 2 causes for these failures: (1) MJPEG tests are running on devices where HALv3 is used, where MJPEG isn't dealt with at Chrome-side. (2) TakePhoto test is failing on bob while checking JFIF/EXIF format. (1) will be fixed by http://crrev.com/c/1404904 (2) is tracked by b/122634040
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/669fedf5eccf89245da0bc49e25ae6e7d5dac2f5 commit 669fedf5eccf89245da0bc49e25ae6e7d5dac2f5 Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Mon Jan 14 16:56:26 2019 [Video Capture, Test] Skip MJPEG tests on ChromeOS devices using HALv3 On Chrome OS devieces where HAL v3 camera service are used, VideoCaptureDevice class doesn't handle MJPEG data. This is because MJPEG data from a camera are decoded to YUV by the HAL before coming to Chrome. So, UsingRealWebcam_CaptureMjpeg tests should be skipped on such devices. Bug: 893501 Test: run capture_unittests on eve Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Change-Id: I55814b1c8368511ee1c1e0c84e1ba6bb1760961f Reviewed-on: https://chromium-review.googlesource.com/c/1404904 Reviewed-by: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#622481} [modify] https://crrev.com/669fedf5eccf89245da0bc49e25ae6e7d5dac2f5/media/capture/BUILD.gn [modify] https://crrev.com/669fedf5eccf89245da0bc49e25ae6e7d5dac2f5/media/capture/video/video_capture_device_unittest.cc
,
Jan 21
(2 days ago)
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hiroh@chromium.org
, Oct 15