Sync: Add integration tests for KEEP_DATA/CLEAR_DATA behavior |
||||
Issue descriptionWe should add some integration tests for Sync's behavior on ProfileSyncService::RequestStop(KEEP_DATA) vs (CLEAR_DATA), especially in combination with standalone-transport. Something like: Base case 1: - Start Sync. - Stop(KEEP_DATA). - Start Sync again. - Make sure Sync data wasn't re-downloaded. Base case 2: - Start Sync. - Stop(CLEAR_DATA). - Make sure Sync data is gone. (Maybe by restarting and making sure we re-downloaded it?) Standalone transport case: - Start full Sync. - Switch to transport only. - Turn full Sync on again. - Make sure we didn't re-download. Currently the re-downloading isn't exposed anywhere. As a hack, we could check the UMA histogram Sync.ModelTypeEntityChange. Alternatively, we could extend the FakeServer to expose this info (which data was read, how often, etc).
,
Oct 9
,
Oct 19
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f2f4f3289620c254f96fea4241c3c953dd3111e commit 6f2f4f3289620c254f96fea4241c3c953dd3111e Author: Marc Treib <treib@chromium.org> Date: Mon Oct 22 16:36:26 2018 Sync: Add integration tests for KEEP_DATA/CLEAR_DATA behavior These tests make sure that the KEEP_DATA/CLEAR_DATA parameter to RequestStop() behaves as expected: With KEEP_DATA, the Sync data does not have to be redownloaded when Sync later gets turned on again. This holds even if Sync starts up in standalone-transport mode in the meantime. Bug: 893496 Change-Id: Ibd2167f201f5b973cadac936fdf6a97036bfc598 Reviewed-on: https://chromium-review.googlesource.com/c/1291393 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#601609} [modify] https://crrev.com/6f2f4f3289620c254f96fea4241c3c953dd3111e/chrome/browser/sync/test/integration/enable_disable_test.cc
,
Oct 23
|
||||
►
Sign in to add a comment |
||||
Comment 1 by treib@chromium.org
, Oct 9