New issue
Advanced search Search tips

Issue 893486 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 891782



Sign in to add a comment

Multiple check fail on shutting down Debug build

Project Member Reported by olivierrobin@chromium.org, Oct 9

Issue description

first issue 

[1009/103606.694980:ERROR:leak_tracker.h(101)] Leaked 0x7fc2d58150a0 which was allocated by:
[1009/103606.695140:ERROR:leak_tracker.h(102)] 0   Chromium                            0x000000010ff858fd base::debug::StackTrace::StackTrace(unsigned long) + 157
1   Chromium                            0x000000010ff8593d base::debug::StackTrace::StackTrace(unsigned long) + 29
2   Chromium                            0x000000010fc5a2da base::debug::StackTrace::StackTrace() + 26
3   Chromium                            0x000000011400b22f base::debug::LeakTracker<io_thread::SystemURLRequestContextGetter>::LeakTracker() + 47
4   Chromium                            0x0000000113fffbd5 base::debug::LeakTracker<io_thread::SystemURLRequestContextGetter>::LeakTracker() + 21
5   Chromium                            0x0000000113fffb79 io_thread::SystemURLRequestContextGetter::SystemURLRequestContextGetter(io_thread::IOSIOThread*) + 105
6   Chromium                            0x0000000113fffbfd io_thread::SystemURLRequestContextGetter::SystemURLRequestContextGetter(io_thread::IOSIOThread*) + 29
7   Chromium                            0x00000001140055e5 io_thread::IOSIOThread::system_url_request_context_getter() + 549
8   Chromium                            0x000000010e8ea195 IOSChromeIOThread::GetSystemNetworkContext() + 69
9   Chromium                            0x000000010e8ea61b IOSChromeIOThread::GetSharedURLLoaderFactory() + 139
10  Chromium                            0x000000010f0e6b6e ApplicationContextImpl::GetSharedURLLoaderFactory() + 62
11  Chromium                            0x000000010e957971 IOSChromeMetricsServicesManagerClient::GetURLLoaderFactory() + 49
12  Chromium                            0x0000000113b5f2f4 metrics_services_manager::MetricsServicesManager::GetRapporServiceImpl() + 1172
13  Chromium                            0x0000000113b5fc0d metrics_services_manager::MetricsServicesManager::UpdateRunningServices() + 557
14  Chromium                            0x0000000113b5fe04 metrics_services_manager::MetricsServicesManager::UpdatePermissions(bool, bool, bool) + 372
15  Chromium                            0x0000000113b60101 metrics_services_manager::MetricsServicesManager::UpdateUploadPermissions(bool) + 257

 
2nd failure

[1009/105727.281635:FATAL:observer_list_threadsafe.h(153)] Check failed: observers_.empty(). 
(lldb) bt
* thread #1, name = 'CrWebMain', queue = 'com.apple.main-thread', stop reason = EXC_BREAKPOINT (code=EXC_I386_BPT, subcode=0x0)
    frame #0: 0x000000010597c044 Chromium`base::debug::BreakDebugger() at debugger_posix.cc:274
    frame #1: 0x0000000105698ba2 Chromium`logging::LogMessage::~LogMessage(this=0x00007ffeece26020) at logging.cc:856
    frame #2: 0x0000000105695485 Chromium`logging::LogMessage::~LogMessage(this=0x00007ffeece26020) at logging.cc:584
  * frame #3: 0x000000010771721e Chromium`base::ObserverListThreadSafe<network::NetworkConnectionTracker::NetworkConnectionObserver>::AssertEmpty(this=0x0000600000d243f0) const at observer_list_threadsafe.h:153
    frame #4: 0x0000000107716f5b Chromium`network::NetworkConnectionTracker::~NetworkConnectionTracker(this=0x00007f8526002b30) at network_connection_tracker.cc:55
    frame #5: 0x00000001077172d5 Chromium`network::NetworkConnectionTracker::~NetworkConnectionTracker(this=0x00007f8526002b30) at network_connection_tracker.cc:53
    frame #6: 0x00000001077172f9 Chromium`network::NetworkConnectionTracker::~NetworkConnectionTracker(this=0x00007f8526002b30) at network_connection_tracker.cc:53
    frame #7: 0x0000000104adabfe Chromium`ApplicationContextImpl::~ApplicationContextImpl() [inlined] std::__1::default_delete<network::NetworkConnectionTracker>::operator(this=0x0000600000610990, __ptr=0x00007f8526002b30)(network::NetworkConnectionTracker*) const at memory:2322
    frame #8: 0x0000000104adabd6 Chromium`ApplicationContextImpl::~ApplicationContextImpl() [inlined] std::__1::unique_ptr<network::NetworkConnectionTracker, std::__1::default_delete<network::NetworkConnectionTracker> >::reset(this=0x0000600000610990, __p=0x0000000000000000) at memory:2635
    frame #9: 0x0000000104adab59 Chromium`ApplicationContextImpl::~ApplicationContextImpl() [inlined] std::__1::unique_ptr<network::NetworkConnectionTracker, std::__1::default_delete<network::NetworkConnectionTracker> >::~unique_ptr(this=0x0000600000610990) at memory:2589
    frame #10: 0x0000000104adab59 Chromium`ApplicationContextImpl::~ApplicationContextImpl() [inlined] std::__1::unique_ptr<network::NetworkConnectionTracker, std::__1::default_delete<network::NetworkConnectionTracker> >::~unique_ptr(this=0x0000600000610990) at memory:2589
    frame #11: 0x0000000104adab59 Chromium`ApplicationContextImpl::~ApplicationContextImpl(this=0x00006000006108c0) at application_context_impl.cc:116
    frame #12: 0x0000000104adb745 Chromium`ApplicationContextImpl::~ApplicationContextImpl(this=0x00006000006108c0) at application_context_impl.cc:113
    frame #13: 0x0000000104adb769 Chromium`ApplicationContextImpl::~ApplicationContextImpl(this=0x00006000006108c0) at application_context_impl.cc:113
    frame #14: 0x0000000104ae449c Chromium`IOSChromeMainParts::~IOSChromeMainParts() [inlined] std::__1::default_delete<ApplicationContextImpl>::operator(this=0x0000600003171060, __ptr=0x00006000006108c0)(ApplicationContextImpl*) const at memory:2322
    frame #15: 0x0000000104ae4477 Chromium`IOSChromeMainParts::~IOSChromeMainParts() [inlined] std::__1::unique_ptr<ApplicationContextImpl, std::__1::default_delete<ApplicationContextImpl> >::reset(this=0x0000600003171060, __p=0x0000000000000000) at memory:2635
    frame #16: 0x0000000104ae4424 Chromium`IOSChromeMainParts::~IOSChromeMainParts() [inlined] std::__1::unique_ptr<ApplicationContextImpl, std::__1::default_delete<ApplicationContextImpl> >::~unique_ptr(this=0x0000600003171060) at memory:2589
    frame #17: 0x0000000104ae4424 Chromium`IOSChromeMainParts::~IOSChromeMainParts() [inlined] std::__1::unique_ptr<ApplicationContextImpl, std::__1::default_delete<ApplicationContextImpl> >::~unique_ptr(this=0x0000600003171060) at memory:2589
    frame #18: 0x0000000104ae4424 Chromium`IOSChromeMainParts::~IOSChromeMainParts(this=0x0000600003171050) at ios_chrome_main_parts.mm:75
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f56d168e749f63261f22467720496a6127b8355d

commit f56d168e749f63261f22467720496a6127b8355d
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Tue Oct 09 14:45:24 2018

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/450ff6a5e7581a87b3fd863512a96ec60cb1aa65

commit 450ff6a5e7581a87b3fd863512a96ec60cb1aa65
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Tue Oct 09 18:13:29 2018

Mark TranslateService resource_request_allowed_notifier_ as leaky

TranslateService is never destroyed, so its members are leaked.

Bug:  893486 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I15868ce7ad6094804d7556225504a4591da6b123
Reviewed-on: https://chromium-review.googlesource.com/c/1269532
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597995}
[modify] https://crrev.com/450ff6a5e7581a87b3fd863512a96ec60cb1aa65/ios/chrome/browser/translate/translate_service_ios.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4c714f7171b3f501264dbf01301fff2cd0497f0

commit f4c714f7171b3f501264dbf01301fff2cd0497f0
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Wed Oct 10 09:14:22 2018

Reset _httpProtocolHandlerDelegate in MainController

IOSIOThread checks that all references to SystemURLRequestContextGetter
have been released on shutdown.
This causes a DCHECK.

Bug:  893486 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7f7987e9f3cb8a3cc978d05347f6ac8c305b3bc9
Reviewed-on: https://chromium-review.googlesource.com/c/1269866
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598263}
[modify] https://crrev.com/f4c714f7171b3f501264dbf01301fff2cd0497f0/ios/chrome/app/main_controller.mm

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/359e3fca3d29491c8f6c850208abef2d7f2146e9

commit 359e3fca3d29491c8f6c850208abef2d7f2146e9
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Wed Oct 10 16:24:58 2018

Stop observing prefs on MemoryDebuggerManager destroy

Bug:  893486 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I23066a159be3b58d4eca39595eae0ce74495ad71
Reviewed-on: https://chromium-review.googlesource.com/c/1270741
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598356}
[modify] https://crrev.com/359e3fca3d29491c8f6c850208abef2d7f2146e9/ios/chrome/browser/memory/memory_debugger_manager.mm

Blocking: 891782
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3

commit 4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Fri Oct 12 09:04:37 2018

Stop observing prefs in MainController on Shutdown

Bug:  893486 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iba70383fe0993c7c921a118197197497c1d42572
Reviewed-on: https://chromium-review.googlesource.com/c/1270899
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599149}
[modify] https://crrev.com/4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3/ios/chrome/app/main_controller.mm

Status: Fixed (was: Started)

Sign in to add a comment