New issue
Advanced search Search tips

Issue 893480 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Support test_driver.action_sequence() for content_shell

Project Member Reported by foolip@chromium.org, Oct 9

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e60301374d325a6cafd2942b4bf6197432c0015a

commit e60301374d325a6cafd2942b4bf6197432c0015a
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Wed Oct 10 12:50:04 2018

Import wpt@434ca4744845966d5f3f87355f41ccc6f777376f (manual)

Using wpt-import in Chromium df7ba195913732e773ac78b838f5226aa094866f.
With Chromium commits locally applied on WPT:
65d72632bf "Make DTMF tone change more deterministic"

Based on https://chromium-review.googlesource.com/1270479 which failed
due to  issue 893079 .

TBR=robertma@chromium.org

Bug:  893079 , 893490,  884588 , 893480
Change-Id: I4fbdb2dc8f5353692e11de3689ad0462c702f496
No-Export: true
Reviewed-on: https://chromium-review.googlesource.com/c/1269732
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598294}
[modify] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
[modify] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-grid/abspos/support/grid.css
[modify] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-grid/grid-definition/support/grid.css
[modify] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-grid/grid-model/support/grid.css
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/text-indent/reference/text-indent-percentage-002-ref.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/text-indent/text-indent-percentage-002.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/text-indent/text-indent-percentage-003.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/text-indent/text-indent-percentage-004.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-000.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-001.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-002.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-003.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-004.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-005.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-006.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-007.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-008.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-00B.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-00D.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-00E.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-00F.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-010.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-011.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-012.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-013.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-014.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-015.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-016.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-017.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-018.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-019.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-01A.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-01B.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-01C.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-01D.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-01E.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-01F.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-07F.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-080.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-081.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-082.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-083.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-084.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-085.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-086.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-087.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-088.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-089.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-08A.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-08B.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-08C.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-08D.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-08E.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-08F.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-090.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-091.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-092.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-093.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-094.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-095.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-096.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-097.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-098.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-099.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-09A.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-09B.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-09C.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-09D.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-09E.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-09F.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/reference/control-chars-000-ref.html
[modify] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/support/grid.css
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/infrastructure/metadata/infrastructure/testdriver/actions/elementPosition.html.ini
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/infrastructure/metadata/infrastructure/testdriver/actions/elementTiming.html.ini
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/infrastructure/metadata/infrastructure/testdriver/actions/eventOrder.html.ini
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/infrastructure/metadata/infrastructure/testdriver/actions/multiDevice.html.ini
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/elementPosition.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/elementTiming.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/eventOrder.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/multiDevice.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/resources/testdriver-actions.js
[modify] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/resources/testdriver.js

Owner: lanwei@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d51634dc19c3295c8560403addf5784e80afcc7

commit 9d51634dc19c3295c8560403addf5784e80afcc7
Author: Lan Wei <lanwei@chromium.org>
Date: Tue Nov 06 05:51:45 2018

Change the button type to int in the pointerActionSequence API

In order to match with test_driver Actions API, we need to change the
button type from string to int in the pointerActionSequence API and the
related web platform tests and layout tests.

Bug: 893480
Change-Id: I151849d31038cf40a2a603196e0f616e15d89072
Reviewed-on: https://chromium-review.googlesource.com/c/1297637
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605605}
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/content/common/input/actions_parser.cc
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/content/common/input/actions_parser_unittest.cc
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/css3/masking/clip-path-selection.html
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/editing/input/drag_in_unselectable.html
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/editing/selection/mouse/selectstart_modify_crash.html
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/external/wpt/pointerlock/mouse_buttons_back_forward-manual.html
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/external/wpt/uievents/mouse/mouse_buttons_back_forward-manual.html
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/external/wpt_automation/css/css-scroll-snap/snap-at-user-scroll-end-manual-automation.js
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/external/wpt_automation/html/user-activation/activation-thru-contextmenu-event-manual-automation.js
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/pointerevent_common_input.js
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/pointerlock/pointerevent_pointerlock_after_pointercapture-manual-automation.js
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/external/wpt_automation/pointerlock/mouse_buttons_back_forward-manual-automation.js
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/external/wpt_automation/pointerlock/pointerlock_common_input.js
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/external/wpt_automation/uievents/click/auxclick_event-manual-automation.js
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/external/wpt_automation/uievents/mouse/mouse_buttons_back_forward-manual-automation.js
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/external/wpt_automation/uievents/mouse/mouseevent_move_button-manual-automation.js
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/fast/events/resources/middleClickAutoscroll.js
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/fast/events/update-hover-when-mouse-press.html
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/fast/scrolling/scrollbar-mousedown-move-mouseup.html
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-support.js
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/webaudio-iframe-with-gesture.html
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/media/controls/modern/scrubbing-stops-when-controls-hidden.html
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/media/controls/modern/scrubbing.html
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/resources/gesture-util.js
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/resources/testdriver-vendor.js
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/rootscroller/keyboard-scroll-document-not-root-scroller.html
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/svg/text/select-text-vertical.html
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/virtual/mouseevent_fractional/fast/events/mouse-coords-in-zoom-and-scroll.html
[modify] https://crrev.com/9d51634dc19c3295c8560403addf5784e80afcc7/third_party/WebKit/LayoutTests/virtual/mouseevent_fractional/fast/events/mouse-right-coords-in-zoom-and-scroll-right.html

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/687313c56366619151285b4d87847b61e6547cbc

commit 687313c56366619151285b4d87847b61e6547cbc
Author: Lan Wei <lanwei@chromium.org>
Date: Fri Nov 09 17:28:50 2018

Add action_sequence in testdriver

After we expose test_driver.Actions API to web users, we add their
implementation in our testdriver file, and fix the wpt tests of
Actions API.

Bug: 893480
Change-Id: Ib02c0223208eeb2cc30c2ca35b98d5fc938baa2c
Reviewed-on: https://chromium-review.googlesource.com/c/1289119
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606882}
[modify] https://crrev.com/687313c56366619151285b4d87847b61e6547cbc/content/common/input/actions_parser.cc
[modify] https://crrev.com/687313c56366619151285b4d87847b61e6547cbc/content/common/input/actions_parser.h
[modify] https://crrev.com/687313c56366619151285b4d87847b61e6547cbc/content/common/input/actions_parser_unittest.cc
[modify] https://crrev.com/687313c56366619151285b4d87847b61e6547cbc/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/687313c56366619151285b4d87847b61e6547cbc/third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/elementPosition.html
[modify] https://crrev.com/687313c56366619151285b4d87847b61e6547cbc/third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/eventOrder.html
[rename] https://crrev.com/687313c56366619151285b4d87847b61e6547cbc/third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_pointermove.html
[modify] https://crrev.com/687313c56366619151285b4d87847b61e6547cbc/third_party/WebKit/LayoutTests/external/wpt/resources/testdriver-actions.js
[modify] https://crrev.com/687313c56366619151285b4d87847b61e6547cbc/third_party/WebKit/LayoutTests/external/wpt/resources/testdriver.js
[delete] https://crrev.com/acb2df40a36d52ef4649dc82d779b8b024112358/third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/pointerevent_pointermove-manual-automation.js
[modify] https://crrev.com/687313c56366619151285b4d87847b61e6547cbc/third_party/WebKit/LayoutTests/resources/testdriver-vendor.js
[modify] https://crrev.com/687313c56366619151285b4d87847b61e6547cbc/third_party/WebKit/LayoutTests/resources/testdriver.js

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1ba120f7b5dbd22db88ddca9bb2f50795ee1523

commit b1ba120f7b5dbd22db88ddca9bb2f50795ee1523
Author: Lan Wei <lanwei@chromium.org>
Date: Mon Nov 26 18:47:57 2018

Modify the web platform tests with mouse inputs to use TestDriver

Since we have implemented test_driver Actions API, we will replace
chrome.gpuBenchmarking.pointerActionSequence with this Actions API in
all the tests. This CL will just replace the web platform tests with
mouse inputs.

Bug: 893480
Change-Id: Ie4eb7f4b8aaf23b2664182c5b8e814c7113dcf9a
Reviewed-on: https://chromium-review.googlesource.com/c/1296823
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610898}
[modify] https://crrev.com/b1ba120f7b5dbd22db88ddca9bb2f50795ee1523/third_party/blink/web_tests/NeverFixTests
[delete] https://crrev.com/d8d233ac03f099cf2ee0a7a61685cd34bcb98078/third_party/blink/web_tests/external/wpt/infrastructure/testdriver/actions/elementPosition-expected.txt
[rename] https://crrev.com/b1ba120f7b5dbd22db88ddca9bb2f50795ee1523/third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_capture_mouse.html
[rename] https://crrev.com/b1ba120f7b5dbd22db88ddca9bb2f50795ee1523/third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_pointermove.html
[rename] https://crrev.com/b1ba120f7b5dbd22db88ddca9bb2f50795ee1523/third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_pointermove_isprimary_same_as_pointerdown.html
[rename] https://crrev.com/b1ba120f7b5dbd22db88ddca9bb2f50795ee1523/third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_pointermove_on_chorded_mouse_button.html
[rename] https://crrev.com/b1ba120f7b5dbd22db88ddca9bb2f50795ee1523/third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_setpointercapture_inactive_button_mouse.html
[modify] https://crrev.com/b1ba120f7b5dbd22db88ddca9bb2f50795ee1523/third_party/blink/web_tests/external/wpt/resources/testdriver-actions.js
[modify] https://crrev.com/b1ba120f7b5dbd22db88ddca9bb2f50795ee1523/third_party/blink/web_tests/external/wpt/resources/testdriver.js
[rename] https://crrev.com/b1ba120f7b5dbd22db88ddca9bb2f50795ee1523/third_party/blink/web_tests/external/wpt/uievents/mouse/mouse_buttons_back_forward.html
[delete] https://crrev.com/d8d233ac03f099cf2ee0a7a61685cd34bcb98078/third_party/blink/web_tests/external/wpt_automation/pointerevents/pointerevent_capture_mouse-manual-automation.js
[delete] https://crrev.com/d8d233ac03f099cf2ee0a7a61685cd34bcb98078/third_party/blink/web_tests/external/wpt_automation/pointerevents/pointerevent_pointermove_isprimary_same_as_pointerdown-manual-automation.js
[delete] https://crrev.com/d8d233ac03f099cf2ee0a7a61685cd34bcb98078/third_party/blink/web_tests/external/wpt_automation/pointerevents/pointerevent_pointermove_on_chorded_mouse_button-manual-automation.js
[delete] https://crrev.com/d8d233ac03f099cf2ee0a7a61685cd34bcb98078/third_party/blink/web_tests/external/wpt_automation/pointerevents/pointerevent_setpointercapture_inactive_button_mouse-manual-automation.js
[delete] https://crrev.com/d8d233ac03f099cf2ee0a7a61685cd34bcb98078/third_party/blink/web_tests/external/wpt_automation/uievents/mouse/mouse_buttons_back_forward-manual-automation.js
[modify] https://crrev.com/b1ba120f7b5dbd22db88ddca9bb2f50795ee1523/third_party/blink/web_tests/resources/testdriver-vendor.js

Cc: smcgruer@chromium.org robertma@chromium.org foolip@chromium.org
 Issue 907726  has been merged into this issue.
Components: Blink>Infra>Ecosystem
 Issue 907726  tracks external/wpt/infrastructure/testdriver/actions/pause.html timing out.

That happens because content::GpuBenchmarking::PointerActionSequence doesn't throw an error when parsing a sequence fails (see the comment about some layout tests failing when that's done). If I uncomment those lines, the error I get is

  FAIL TestDriver actions: pause promise_test: Unhandled rejection with value: object "TypeError: we only support action sequence type of pointer" 
Yes, we do not support "none" type right now, but we are working on it.

Sign in to add a comment