Issue 892860  has been merged into this issue.

The issue seems to be related to Builds which is out of scope for TE, hence adding TE-NeedsTriageHelp label for further investigation of the issue.

Thanks.!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5bf20624a99401dcb6c9e6aee9244334008222b

commit d5bf20624a99401dcb6c9e6aee9244334008222b
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Tue Oct 16 19:37:14 2018

Add Windows ARM64 support to Chromium build scripts.

This change mostly contains build script change under //chrome/build only.
It is targeting MSVC arm64 toolset, but enable clang-cl
could be based on this change.

Bug: 893460
Change-Id: Ia6f69f067a97fcaeb77021c1019bc594b0859eda
Reviewed-on: https://chromium-review.googlesource.com/c/1272076
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600083}
[modify] https://crrev.com/d5bf20624a99401dcb6c9e6aee9244334008222b/build/build_config.h
[modify] https://crrev.com/d5bf20624a99401dcb6c9e6aee9244334008222b/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/d5bf20624a99401dcb6c9e6aee9244334008222b/build/config/compiler/BUILD.gn
[modify] https://crrev.com/d5bf20624a99401dcb6c9e6aee9244334008222b/build/config/win/BUILD.gn
[modify] https://crrev.com/d5bf20624a99401dcb6c9e6aee9244334008222b/build/toolchain/win/BUILD.gn
[modify] https://crrev.com/d5bf20624a99401dcb6c9e6aee9244334008222b/build/toolchain/win/midl.gni
[modify] https://crrev.com/d5bf20624a99401dcb6c9e6aee9244334008222b/build/toolchain/win/tool_wrapper.py
[modify] https://crrev.com/d5bf20624a99401dcb6c9e6aee9244334008222b/build/vs_toolchain.py
[modify] https://crrev.com/d5bf20624a99401dcb6c9e6aee9244334008222b/build/win/reorder-imports.py
[modify] https://crrev.com/d5bf20624a99401dcb6c9e6aee9244334008222b/third_party/boringssl/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9256bf426083e9cb4896e57901a8367e183092c

commit f9256bf426083e9cb4896e57901a8367e183092c
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Fri Oct 19 22:52:14 2018

Use clang intrinsic for quic for Windows ARM64

The intrinsic _mm_prefetch on Windows is x86/x64 only. Instead select
__builtin_prefetch from clang for Windows ARM64.

Bug: 893460
Change-Id: I484b13fe7c616b52abe4b1dff06a5f830fd538d2
Reviewed-on: https://chromium-review.googlesource.com/c/1292528
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601335}
[modify] https://crrev.com/f9256bf426083e9cb4896e57901a8367e183092c/net/third_party/quic/platform/impl/quic_prefetch_impl.h

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/fcbb023b0e09962453b68609341d21fbb17bf9fe

commit fcbb023b0e09962453b68609341d21fbb17bf9fe
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Tue Oct 23 08:45:48 2018

Add Windows ARM64 ABI support to V8

This change added Windows ARM64 ABI support, major things are:
1. Excluding x18 register from any usage because it is reserved as
   platform register. Preserve alignment after the change.
2. Fix the assumption of LP64 in arm64 backend. Windows ARM64 is
   still LLP64.
3. Stack guard page probe for large allocation on stack.

Reference:
Windows ARM64 ABI:
https://docs.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=vs-2017

Bug: chromium:893460
Change-Id: I325884ac8dab719154a0047141e18a9fcb8dff7e
Reviewed-on: https://chromium-review.googlesource.com/c/1285129
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56881}
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/AUTHORS
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/snapshot_toolchain.gni
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/arm64/assembler-arm64-inl.h
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/arm64/assembler-arm64.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/arm64/assembler-arm64.h
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/arm64/constants-arm64.h
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/arm64/cpu-arm64.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/arm64/deoptimizer-arm64.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/arm64/disasm-arm64.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/arm64/instructions-arm64-constants.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/arm64/instructions-arm64.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/arm64/instructions-arm64.h
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/arm64/macro-assembler-arm64.h
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/arm64/simulator-arm64.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/arm64/utils-arm64.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/arm64/utils-arm64.h
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/base/build_config.h
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/base/debug/stack_trace_win.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/base/platform/time.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/deoptimizer.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/libsampler/sampler.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/runtime/runtime-atomics.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/src/wasm/baseline/liftoff-compiler.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/test/cctest/BUILD.gn
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/test/cctest/test-assembler-arm64.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/test/cctest/test-fuzz-arm64.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/test/cctest/test-utils-arm64.cc
[modify] https://crrev.com/fcbb023b0e09962453b68609341d21fbb17bf9fe/test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d2d217d8ed58f806c248963db57ddb6e0aa07e83

commit d2d217d8ed58f806c248963db57ddb6e0aa07e83
Author: Michael Hablich <hablich@chromium.org>
Date: Tue Oct 23 17:32:43 2018

Revert "Add Windows ARM64 ABI support to V8"

This reverts commit fcbb023b0e09962453b68609341d21fbb17bf9fe.

Reason for revert: blocks roll https://chromium-review.googlesource.com/c/chromium/src/+/1296315

Original change's description:
> Add Windows ARM64 ABI support to V8
> 
> This change added Windows ARM64 ABI support, major things are:
> 1. Excluding x18 register from any usage because it is reserved as
>    platform register. Preserve alignment after the change.
> 2. Fix the assumption of LP64 in arm64 backend. Windows ARM64 is
>    still LLP64.
> 3. Stack guard page probe for large allocation on stack.
> 
> Reference:
> Windows ARM64 ABI:
> https://docs.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=vs-2017
> 
> Bug: chromium:893460
> Change-Id: I325884ac8dab719154a0047141e18a9fcb8dff7e
> Reviewed-on: https://chromium-review.googlesource.com/c/1285129
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> Reviewed-by: Andreas Haas <ahaas@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#56881}

TBR=bbudge@chromium.org,ulan@chromium.org,machenbach@chromium.org,hpayer@chromium.org,brucedawson@chromium.org,mlippautz@chromium.org,ahaas@chromium.org,bmeurer@chromium.org,Tom.Tan@microsoft.com

Change-Id: I0b804af6dfca9409a655194fa6e5407f209be2dc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:893460
Reviewed-on: https://chromium-review.googlesource.com/c/1296460
Reviewed-by: Michael Hablich <hablich@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56912}
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/AUTHORS
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/snapshot_toolchain.gni
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/arm64/assembler-arm64-inl.h
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/arm64/assembler-arm64.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/arm64/assembler-arm64.h
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/arm64/constants-arm64.h
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/arm64/cpu-arm64.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/arm64/deoptimizer-arm64.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/arm64/disasm-arm64.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/arm64/instructions-arm64-constants.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/arm64/instructions-arm64.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/arm64/instructions-arm64.h
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/arm64/macro-assembler-arm64.h
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/arm64/simulator-arm64.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/arm64/utils-arm64.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/arm64/utils-arm64.h
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/base/build_config.h
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/base/debug/stack_trace_win.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/base/platform/time.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/deoptimizer.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/libsampler/sampler.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/runtime/runtime-atomics.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/src/wasm/baseline/liftoff-compiler.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/test/cctest/BUILD.gn
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/test/cctest/test-assembler-arm64.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/test/cctest/test-fuzz-arm64.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/test/cctest/test-utils-arm64.cc
[modify] https://crrev.com/d2d217d8ed58f806c248963db57ddb6e0aa07e83/test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a6423cca4a80154f9904c4fbafdc8f8b59bf4041

commit a6423cca4a80154f9904c4fbafdc8f8b59bf4041
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Wed Oct 24 19:46:36 2018

Reland "Add Windows ARM64 ABI support to V8"

This is a reland of fcbb023b0e09962453b68609341d21fbb17bf9fe

Original change's description:
> Add Windows ARM64 ABI support to V8
>
> This change added Windows ARM64 ABI support, major things are:
> 1. Excluding x18 register from any usage because it is reserved as
>    platform register. Preserve alignment after the change.
> 2. Fix the assumption of LP64 in arm64 backend. Windows ARM64 is
>    still LLP64.
> 3. Stack guard page probe for large allocation on stack.
>
> Reference:
> Windows ARM64 ABI:
> https://docs.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=vs-2017
>
> Bug: chromium:893460
> Change-Id: I325884ac8dab719154a0047141e18a9fcb8dff7e
> Reviewed-on: https://chromium-review.googlesource.com/c/1285129
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> Reviewed-by: Andreas Haas <ahaas@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#56881}

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_arm64_dbg_recipe
TBR=mlippautz@chromium.org

Bug: chromium:893460
Change-Id: Icc45fd091c33f7df805842a70236b79b14756f52
Reviewed-on: https://chromium-review.googlesource.com/c/1297300
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56965}
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/AUTHORS
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/snapshot_toolchain.gni
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/arm64/assembler-arm64-inl.h
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/arm64/assembler-arm64.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/arm64/assembler-arm64.h
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/arm64/constants-arm64.h
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/arm64/cpu-arm64.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/arm64/deoptimizer-arm64.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/arm64/disasm-arm64.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/arm64/instructions-arm64-constants.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/arm64/instructions-arm64.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/arm64/instructions-arm64.h
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/arm64/macro-assembler-arm64.h
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/arm64/simulator-arm64.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/arm64/utils-arm64.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/arm64/utils-arm64.h
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/base/build_config.h
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/base/debug/stack_trace_win.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/base/platform/time.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/deoptimizer.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/libsampler/sampler.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/runtime/runtime-atomics.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/src/wasm/baseline/liftoff-compiler.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/test/cctest/BUILD.gn
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/test/cctest/test-assembler-arm64.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/test/cctest/test-fuzz-arm64.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/test/cctest/test-utils-arm64.cc
[modify] https://crrev.com/a6423cca4a80154f9904c4fbafdc8f8b59bf4041/test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b872c9ceca53d2ddb96ef3470e314d3163a69956

commit b872c9ceca53d2ddb96ef3470e314d3163a69956
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Wed Oct 24 22:11:14 2018

Fix OS structure length for Windows ARM64

Chromium task manager static_asserts on Windows structure
SYSTEM_THREAD_INFORMATION and SYSTEM_PROCESS_INFORMATION,
but it assumes non-x64 is x86. Fix this for Windows ARM64.

Bug: 893460
Change-Id: I1face62bdb617c1d62fcdc3d1e2540eecaa45878
Reviewed-on: https://chromium-review.googlesource.com/c/1297394
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602482}
[modify] https://crrev.com/b872c9ceca53d2ddb96ef3470e314d3163a69956/chrome/browser/task_manager/sampling/shared_sampler_win_defines.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73c0583472d0cc8bb723c79b0f2c56ee96e3afdc

commit 73c0583472d0cc8bb723c79b0f2c56ee96e3afdc
Author: Gaurav Dhol <gaurav.dhol@einfochips.com>
Date: Fri Oct 26 12:39:53 2018

Fix compile error: unsupported error

base/process/memory_win.cc(35,2):  error: Unsupported platform

Bug: 893460
Change-Id: I207473a8d4dc7c4d5fc01dae10fde51db0bdfab2
Reviewed-on: https://chromium-review.googlesource.com/c/1298832
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603064}
[modify] https://crrev.com/73c0583472d0cc8bb723c79b0f2c56ee96e3afdc/AUTHORS
[modify] https://crrev.com/73c0583472d0cc8bb723c79b0f2c56ee96e3afdc/base/process/memory_win.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6e3f59db2b7a2c3bbc250143245800b219841ee

commit f6e3f59db2b7a2c3bbc250143245800b219841ee
Author: Gaurav Dhol <gaurav.dhol@einfochips.com>
Date: Mon Oct 29 17:22:41 2018

Fix compile error: redefined  struct FunctorTraits

../..\base/bind_internal.h(415,8):  error: redefinition of 'FunctorTraits<R (*)(Args...) __attribute__((stdcall))>'

Bug: 893460
Change-Id: I370eb3d4cebf3171fb143cba9b022696c5a1ebb2
Reviewed-on: https://chromium-review.googlesource.com/c/1298831
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603540}
[modify] https://crrev.com/f6e3f59db2b7a2c3bbc250143245800b219841ee/base/bind_internal.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dcb9d44ca674d5829cf4a21fb927f564b19b34f

commit 2dcb9d44ca674d5829cf4a21fb927f564b19b34f
Author: Gaurav Dhol <gaurav.dhol@einfochips.com>
Date: Tue Oct 30 19:42:19 2018

Silence compiler error

base/files/file_win.cc(276,40):  error: non-constant-expression cannot
be narrowed from type 'int' to 'BOOLEAN' (aka 'unsigned char') in initializer list

Bug: 893460
Change-Id: Iab503865c0478c36d70fb8b7b9def152f70cfb7f
Reviewed-on: https://chromium-review.googlesource.com/c/1301576
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603985}
[modify] https://crrev.com/2dcb9d44ca674d5829cf4a21fb927f564b19b34f/base/files/file_win.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f996d926df7b084220284e58c84f80cc2b9a0b0

commit 5f996d926df7b084220284e58c84f80cc2b9a0b0
Author: Gaurav Dhol <gaurav.dhol@einfochips.com>
Date: Thu Nov 01 19:03:44 2018

Use the correct atomicops for Win ARM64

Add guard to avoid using x86 header for ARM64
Resolves this error
./base/atomicops_internals_x86_msvc.h(62,3):  error: use of
 undeclared identifier '__faststorefence' __faststorefence();

Bug: 893460
Change-Id: I82b31e0470c63b4465b430768a73071722e16ed3
Reviewed-on: https://chromium-review.googlesource.com/c/1301195
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604657}
[modify] https://crrev.com/5f996d926df7b084220284e58c84f80cc2b9a0b0/base/atomicops.h

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/123a56a3a9c04bf5fa57681c92e959ecd5dac78f

commit 123a56a3a9c04bf5fa57681c92e959ecd5dac78f
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Fri Nov 09 07:49:16 2018

Mangle asm label correctly for Windows ARM64

Same as Windows x64, Windows ARM64 doesn't prefix assembly label with _.


Bug: chromium:893460
Change-Id: I1b19a4e7ea16da3fe8bd1873509fffe3d067613a
Reviewed-on: https://chromium-review.googlesource.com/c/1298376
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57374}
[modify] https://crrev.com/123a56a3a9c04bf5fa57681c92e959ecd5dac78f/src/snapshot/macros.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/779fe22e5439d2528168857beb154760fd36114a

commit 779fe22e5439d2528168857beb154760fd36114a
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Fri Nov 09 18:53:29 2018

Add macro to SaveRegisters_arm64.S to adopt OS specific directives

Some assembler directives are OS specific, like .type and .hidden only
make sense in ELF. They are not valid for Windows ARM64 even with the
same assembler syntax. This change defines macro to select directives
according to target OS. This looks like a convention for assebmly
source code.


Bug: 893460
Change-Id: I7b5a8dc1648987932f11422d3b393513b6b69fbe
Reviewed-on: https://chromium-review.googlesource.com/c/1327884
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#606919}
[modify] https://crrev.com/779fe22e5439d2528168857beb154760fd36114a/third_party/blink/renderer/platform/heap/asm/SaveRegisters_arm64.S

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2858f698499dd986a53514143dcb6bc1a351e110

commit 2858f698499dd986a53514143dcb6bc1a351e110
Author: Jon Kunkee <jkunkee@microsoft.com>
Date: Sat Nov 10 02:13:56 2018

Add Jon Kunkee to AUTHORS

This commit is otherwise empty because the corresponding contributions are in
other repos.

Bug: 893460
Change-Id: I95ae29c6293e52da62573ae6f6e9a10f31fc48c9
Reviewed-on: https://chromium-review.googlesource.com/c/1330793
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607077}
[modify] https://crrev.com/2858f698499dd986a53514143dcb6bc1a351e110/AUTHORS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3589fae92741c99a525dc47a43c3ee998c12ba44

commit 3589fae92741c99a525dc47a43c3ee998c12ba44
Author: Lalit Chandivade <lalit.chandivade@einfochips.com>
Date: Tue Nov 13 11:57:58 2018

Fix compile error

1. Function defined noreturn
2. Fix following compilation error for aarch64 on win -

error: Unsupported architecture 'aarch64' for MS-style inline assembly
IMMEDIATE_CRASH();
        ^
./base/logging.h(595,6):  note: expanded from macro 'IMMEDIATE_CRASH'
    {__asm int 3 __asm ud2 __asm push __COUNTER__}; \

Bug: 893460
Change-Id: I5ed953c3e29480d469d694cf15f5a292e6920cd7
Reviewed-on: https://chromium-review.googlesource.com/c/1298091
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607562}
[modify] https://crrev.com/3589fae92741c99a525dc47a43c3ee998c12ba44/AUTHORS
[modify] https://crrev.com/3589fae92741c99a525dc47a43c3ee998c12ba44/base/logging.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab224ffa0e428263ae2420eee12cd016603a185e

commit ab224ffa0e428263ae2420eee12cd016603a185e
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Tue Nov 13 17:51:42 2018

Get correct program counter in browser_watcher for Windows ARM64.

Bug: 893460
Change-Id: I1beadfbd939b8998a9d64f14260b106180ce3aae
Reviewed-on: https://chromium-review.googlesource.com/c/1333131
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607642}
[modify] https://crrev.com/ab224ffa0e428263ae2420eee12cd016603a185e/components/browser_watcher/stability_debugging.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a17557eb9c36da233012d29da184fffe2b3d99ec

commit a17557eb9c36da233012d29da184fffe2b3d99ec
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Tue Nov 13 18:38:31 2018

Add Windows arm64 target triple to clang-cl command line.

This change enables "is_clang=true" of Chromium build for Windows ARM64.

This change works with current clang-cl.exe in chromium repo mostly, except cannot compiling code with __try/__except. The fix of this compilation issue is under review in LLVM community (see below link).

https://reviews.llvm.org/D53540

Bug: 893460
Change-Id: I3fbc943c9fd04e325b3a9686ce80202dc0f27238
Reviewed-on: https://chromium-review.googlesource.com/c/1330355
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607667}
[modify] https://crrev.com/a17557eb9c36da233012d29da184fffe2b3d99ec/build/toolchain/win/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15d3ed39bb85253ea0f8b20a472eafdd0f570526

commit 15d3ed39bb85253ea0f8b20a472eafdd0f570526
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Wed Nov 14 18:20:50 2018

Add Windows ARM64 stack frame extraction from OS context record.

Bug: 893460
Change-Id: Iff38ac0d8b65c28ad531b1c3d3d8d2842bb76e40
Reviewed-on: https://chromium-review.googlesource.com/c/1330714
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#608053}
[modify] https://crrev.com/15d3ed39bb85253ea0f8b20a472eafdd0f570526/base/debug/stack_trace_win.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28d9059165fdb75fd66b68b10f977c810fb5559c

commit 28d9059165fdb75fd66b68b10f977c810fb5559c
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Wed Nov 14 20:24:54 2018

Initialize zlib processor feature flags for Windows ARM64

Bug: 893460
Change-Id: I69914310f35a1b21159da701447651aba4f1b888
Reviewed-on: https://chromium-review.googlesource.com/c/1334934
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Reviewed-by: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608107}
[modify] https://crrev.com/28d9059165fdb75fd66b68b10f977c810fb5559c/third_party/zlib/arm_features.c

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df3fde1f5e4d3a685237abffc4c225665e15685d

commit df3fde1f5e4d3a685237abffc4c225665e15685d
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Wed Nov 14 20:53:21 2018

Support stack walk on Windows ARM64 in base profiler

Bug: 893460
Change-Id: I9def3ef624b5121c7e902efc01a18754f448b8ce
Reviewed-on: https://chromium-review.googlesource.com/c/1332698
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#608119}
[modify] https://crrev.com/df3fde1f5e4d3a685237abffc4c225665e15685d/base/BUILD.gn
[modify] https://crrev.com/df3fde1f5e4d3a685237abffc4c225665e15685d/base/allocator/allocator_shim_unittest.cc
[modify] https://crrev.com/df3fde1f5e4d3a685237abffc4c225665e15685d/base/profiler/native_stack_sampler_win.cc
[modify] https://crrev.com/df3fde1f5e4d3a685237abffc4c225665e15685d/base/profiler/win32_stack_frame_unwinder.cc
[modify] https://crrev.com/df3fde1f5e4d3a685237abffc4c225665e15685d/base/profiler/win32_stack_frame_unwinder.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92644e1965bc52395065460fc1b7ec00f12e8b6d

commit 92644e1965bc52395065460fc1b7ec00f12e8b6d
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Wed Nov 14 22:18:59 2018

Create export def file for Windows ARM64 platform.

The only difference between the new chrome_elf_arm64.def and existing chrome_elf_x64.def is that RegisterNonABICompliantCodeRange_ExportThunk and UnregisterNonABICompliantCodeRange_ExportThunk are not included because they are defined as x64 specific.

Bug: 893460
Change-Id: Id0d11fb9264309b3c6ce97d81eeab1a39e158fba
Reviewed-on: https://chromium-review.googlesource.com/c/1325149
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#608143}
[modify] https://crrev.com/92644e1965bc52395065460fc1b7ec00f12e8b6d/chrome_elf/BUILD.gn
[add] https://crrev.com/92644e1965bc52395065460fc1b7ec00f12e8b6d/chrome_elf/chrome_elf_arm64.def
[modify] https://crrev.com/92644e1965bc52395065460fc1b7ec00f12e8b6d/chrome_elf/chrome_elf_x64.def
[modify] https://crrev.com/92644e1965bc52395065460fc1b7ec00f12e8b6d/chrome_elf/chrome_elf_x86.def

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24aeaf01858c5070ccecb1b853972a5d75632e87

commit 24aeaf01858c5070ccecb1b853972a5d75632e87
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Thu Nov 15 19:28:13 2018

Disable hooks for Windows ARM64.

Disable IAT hooks on Windows ARM64 for the same reason as Windows X64.
IAT virtual address is 4 bytes in length and insufficient to hook to
arbitrary 64-bit address.

Bug: 893460
Change-Id: I05b607737e07e12a318f261366a59c8ed1a52782
Reviewed-on: https://chromium-review.googlesource.com/c/1337294
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#608472}
[modify] https://crrev.com/24aeaf01858c5070ccecb1b853972a5d75632e87/chrome/app/chrome_main_delegate.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27a86e099b3bd0a107b6dc085fa7d35bb3411b5f

commit 27a86e099b3bd0a107b6dc085fa7d35bb3411b5f
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Thu Nov 15 20:19:40 2018

Add Windows ARM64 support to Chromium sandbox.

Bug: 893460
Change-Id: I40d49723dc53ee45178c95698f05d8cecc040097
Reviewed-on: https://chromium-review.googlesource.com/c/1318059
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608489}
[modify] https://crrev.com/27a86e099b3bd0a107b6dc085fa7d35bb3411b5f/sandbox/win/BUILD.gn
[modify] https://crrev.com/27a86e099b3bd0a107b6dc085fa7d35bb3411b5f/sandbox/win/src/lpc_policy_test.cc
[modify] https://crrev.com/27a86e099b3bd0a107b6dc085fa7d35bb3411b5f/sandbox/win/src/process_policy_test.cc
[modify] https://crrev.com/27a86e099b3bd0a107b6dc085fa7d35bb3411b5f/sandbox/win/src/resolver_64.cc
[modify] https://crrev.com/27a86e099b3bd0a107b6dc085fa7d35bb3411b5f/sandbox/win/src/sandbox_nt_util.h
[modify] https://crrev.com/27a86e099b3bd0a107b6dc085fa7d35bb3411b5f/sandbox/win/src/service_resolver_64.cc
[modify] https://crrev.com/27a86e099b3bd0a107b6dc085fa7d35bb3411b5f/sandbox/win/src/unload_dll_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/webm/libvpx/+/e6f889c120f65bb3d612aec8e6b1e7e4fcd25378

commit e6f889c120f65bb3d612aec8e6b1e7e4fcd25378
Author: Jon Kunkee <jkunkee@microsoft.com>
Date: Thu Nov 15 22:14:46 2018

Add ARM64 Windows to configure scripts

In order to correctly configure for Windows 10 on ARM, this change adds
a --target value arm64-win64-vs15 to ./configure and adds feature
enable/disable logic for the new platform.

This is merely sufficient for Chromium targeting ARM64 Windows.

Bug: 893460
Change-Id: I46194286f63104bdf6ac57d719fdf1e5d5fa72c8

[modify] https://crrev.com/e6f889c120f65bb3d612aec8e6b1e7e4fcd25378/README
[modify] https://crrev.com/e6f889c120f65bb3d612aec8e6b1e7e4fcd25378/build/make/configure.sh
[modify] https://crrev.com/e6f889c120f65bb3d612aec8e6b1e7e4fcd25378/configure

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aad9861132bc5f597a3828de9c9625f0f754ee4a

commit aad9861132bc5f597a3828de9c9625f0f754ee4a
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Fri Nov 16 02:03:56 2018

Don't load AMD VP9 decoder on Windows ARM64

This change makes the code compile for Widnows ARM64. Also AMD GPU could not be available on every device, so assume that it could be ignored to load.

Bug: 893460
Change-Id: Idae2a64fa9ad8f9e3ad9843abc128e48b85a82c5
Reviewed-on: https://chromium-review.googlesource.com/c/1335281
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#608630}
[modify] https://crrev.com/aad9861132bc5f597a3828de9c9625f0f754ee4a/media/gpu/windows/dxva_video_decode_accelerator_win.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18fbbd37a80afefbc456bfda44656937c154708b

commit 18fbbd37a80afefbc456bfda44656937c154708b
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Fri Nov 16 21:20:04 2018

Update vs_toolchain.py to handle ARM64

ARM64 on Win32 adds a third Win32 target platform which requires updates
to the script which configures the toolchain. This includes handling
build\win_toolchain.json listing either two or three toolchains, and not
copying UCRT DLLs in the ARM64 case, except for ucrtbased.dll.

This also fixes some erroneous double quotes, probably left over from
previous changes I made to this file.

This is in preparation for landing and then using crrev.com/c/1330185

Bug: 893460
Change-Id: I1fa775b662e3c0483174c32ad3c73f30f2802ea9
Reviewed-on: https://chromium-review.googlesource.com/c/1339101
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608951}
[modify] https://crrev.com/18fbbd37a80afefbc456bfda44656937c154708b/build/vs_toolchain.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/c6ffd7af7d84ec354a92a0dc11613ec23cf82c60

commit c6ffd7af7d84ec354a92a0dc11613ec23cf82c60
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Fri Nov 16 23:10:02 2018

Include ARM64 bits into win_toolchain/package_from_installed.py

These changes ensure that the packaged Windows SDK bits support targeting
ARM64 Windows. This change must not land until crrev.com/c/1339101 lands,
since it is needed to the varying number of vs_runtime_dll_dirs.

Bug: 893460
Change-Id: Ie32563067c6fb6078acfaccd6d3d572d1dd44888
Reviewed-on: https://chromium-review.googlesource.com/c/1330185
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/c6ffd7af7d84ec354a92a0dc11613ec23cf82c60/win_toolchain/get_toolchain_if_necessary.py
[modify] https://crrev.com/c6ffd7af7d84ec354a92a0dc11613ec23cf82c60/win_toolchain/package_from_installed.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a70f70a29a9738b48e988352417c31b5a5b1cfc4

commit a70f70a29a9738b48e988352417c31b5a5b1cfc4
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Sat Nov 17 02:32:11 2018

Roll src/third_party/depot_tools 767024c68dfe..c6ffd7af7d84 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/767024c68dfe..c6ffd7af7d84


git log 767024c68dfe..c6ffd7af7d84 --date=short --no-merges --format='%ad %ae %s'
2018-11-16 brucedawson@chromium.org Include ARM64 bits into win_toolchain/package_from_installed.py


Created with:
  gclient setdep -r src/third_party/depot_tools@c6ffd7af7d84

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:893460
TBR=agable@chromium.org

Change-Id: Ib337c3d6591ad7ee19b4980fb79d9a0d3dd35e32
Reviewed-on: https://chromium-review.googlesource.com/c/1341012
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609079}
[modify] https://crrev.com/a70f70a29a9738b48e988352417c31b5a5b1cfc4/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2737d3c4d2409b38aa4bc0ddaba76149c3c846a

commit a2737d3c4d2409b38aa4bc0ddaba76149c3c846a
Author: Gaurav Dhol <gaurav.dhol@einfochips.com>
Date: Mon Nov 19 22:23:08 2018

Support CPU cycle counter on ARM64

ARM64 CPUs don't use __rdtsc to get the CPU cycle counter because that
is an x86/x64 specific instruction. This change updates ThreadTicks to
use the appropriate counter on ARM64 builds on Win32.

Bug: 893460
Change-Id: Ia9679aa8d560f887c5a787b9e6f333ceed9d1192
Reviewed-on: https://chromium-review.googlesource.com/c/1301577
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609467}
[modify] https://crrev.com/a2737d3c4d2409b38aa4bc0ddaba76149c3c846a/AUTHORS
[modify] https://crrev.com/a2737d3c4d2409b38aa4bc0ddaba76149c3c846a/base/time/time_win.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c22a04e7177197998d6c37ca2e39fb7d3fb767bd

commit c22a04e7177197998d6c37ca2e39fb7d3fb767bd
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Wed Nov 21 14:04:12 2018

Copy Windows ARM64 VC runtime from correct location

Bug: 893460
Change-Id: Iad812763c50045ffd9b18b73e0233cbeb4062bf2
Reviewed-on: https://chromium-review.googlesource.com/c/1343567
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610041}
[modify] https://crrev.com/c22a04e7177197998d6c37ca2e39fb7d3fb767bd/build/vs_toolchain.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c33c50f3aa4a1bc6d007373a8da33e95f911bd4c

commit c33c50f3aa4a1bc6d007373a8da33e95f911bd4c
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Wed Nov 21 14:10:23 2018

Use Win32 API GetCurrentThreadStackLimits to get stack start address for Windows ARM64

Bug: 893460
Change-Id: I1ebf06dd022defaaa6b06a27455059d9724f0fa5
Reviewed-on: https://chromium-review.googlesource.com/c/1344870
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610043}
[modify] https://crrev.com/c33c50f3aa4a1bc6d007373a8da33e95f911bd4c/third_party/blink/renderer/platform/wtf/stack_util.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ef8323ea826431000b82f3c0dbe1640d0bfe6b94

commit ef8323ea826431000b82f3c0dbe1640d0bfe6b94
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Wed Nov 28 19:30:18 2018

Fix embedded assembly for Windows ARM64.

Two Fixes included to make V8 build work for Windows ARM64.
1. Don't emit ".def" and related macros to define function beginning, because they are invalid for Windows ARM64.
2. Set alignment of data section to 8 which is required for instruction which loads element from v8_Default_embedded_blob_.


Version 7.2.479

Performance and stability improvements on all platforms.

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I0bfea5dd8ed6c1340d11c13dcc2e492e7b22aa8c
Reviewed-on: https://chromium-review.googlesource.com/c/1352210
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Original-Commit-Position: refs/heads/7.2.479@{#1}
Cr-Original-Branched-From: a8152aac7049aed0cc7e7437898de2fce2787288-refs/heads/master@{#57863}
Bug: chromium:893460
Reviewed-on: https://chromium-review.googlesource.com/c/1352791
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#57915}
[modify] https://crrev.com/ef8323ea826431000b82f3c0dbe1640d0bfe6b94/src/snapshot/embedded-file-writer.cc
[modify] https://crrev.com/ef8323ea826431000b82f3c0dbe1640d0bfe6b94/src/snapshot/embedded-file-writer.h

@Tom: I see you pretty active working on this. Would you like to be assigned to this bug? If you don't have the flag associated to your account, we can request it.

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/5c317537a9fe03521467669c4d938680cf5de5b3

commit 5c317537a9fe03521467669c4d938680cf5de5b3
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Mon Dec 03 14:35:47 2018

Don't copy d3dcompiler_47.dll when build target is Windows ARM64

Windows ARM64 was first released at 10.0.16299 which contains d3dcompiler_47.dll under %systemroot%\system32, so no need to copy it from Windows SDK. For the same reason, it is also not included as part of redistribute package for Windows ARM64.

Bug: chromium:893460

Change-Id: I175ce831d800ec1f19c767fc172219f6b693fec3
Reviewed-on: https://chromium-review.googlesource.com/c/1357155
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/5c317537a9fe03521467669c4d938680cf5de5b3/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b45b2eaa206f2d443e7a58703c4bcbcba837a876

commit b45b2eaa206f2d443e7a58703c4bcbcba837a876
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Dec 03 18:39:55 2018

Roll src/third_party/angle 317a9ebdb019..c10a023a66f2 (6 commits)

https://chromium.googlesource.com/angle/angle.git/+log/317a9ebdb019..c10a023a66f2


git log 317a9ebdb019..c10a023a66f2 --date=short --no-merges --format='%ad %ae %s'
2018-12-03 jmadill@chromium.org Fix fuchsia build of libfeature_support.
2018-12-03 thakis@chromium.org List vulkan_core.h as input of generate_vulkan_layers_json.py.
2018-12-03 Tom.Tan@microsoft.com Don't copy d3dcompiler_47.dll when build target is Windows ARM64
2018-12-03 jmadill@chromium.org Refactor test shader style.
2018-11-30 syoussefi@chromium.org Vulkan: Add dynamic index buffers to graph
2018-11-30 ianelliott@google.com Version-2 API of the A4A opt-in/out (a.k.a. feature-support utilities)


Created with:
  gclient setdep -r src/third_party/angle@c10a023a66f2

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:910699 ,chromium:869348,chromium:893460,chromium:b/113346561
TBR=ynovikov@chromium.org

Change-Id: I29ee936a536269990c413cdd50ad7d46601914a6
Reviewed-on: https://chromium-review.googlesource.com/c/1358758
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613170}
[modify] https://crrev.com/b45b2eaa206f2d443e7a58703c4bcbcba837a876/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c18d077d894d1b755679bbe10744fe05b038ff0

commit 1c18d077d894d1b755679bbe10744fe05b038ff0
Author: Jon Kunkee <jkunkee@microsoft.com>
Date: Tue Dec 04 01:32:52 2018

Consume new ARM64 Windows support in libvpx

This change adds ARM64 Windows support to the configure/GNI-generation
script for libvpx and adds the generated config files.

Bug: 893460
Change-Id: I2b58bca3ac1e2650f68dd82495fa3bb5f44b88a7
Reviewed-on: https://chromium-review.googlesource.com/c/1332732
Reviewed-by: James Zern <jzern@chromium.org>
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: James Zern <jzern@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613379}
[modify] https://crrev.com/1c18d077d894d1b755679bbe10744fe05b038ff0/third_party/libvpx/BUILD.gn
[modify] https://crrev.com/1c18d077d894d1b755679bbe10744fe05b038ff0/third_party/libvpx/generate_gni.sh
[add] https://crrev.com/1c18d077d894d1b755679bbe10744fe05b038ff0/third_party/libvpx/source/config/win/arm64/vp8_rtcd.h
[add] https://crrev.com/1c18d077d894d1b755679bbe10744fe05b038ff0/third_party/libvpx/source/config/win/arm64/vp9_rtcd.h
[add] https://crrev.com/1c18d077d894d1b755679bbe10744fe05b038ff0/third_party/libvpx/source/config/win/arm64/vpx_config.asm
[add] https://crrev.com/1c18d077d894d1b755679bbe10744fe05b038ff0/third_party/libvpx/source/config/win/arm64/vpx_config.c
[add] https://crrev.com/1c18d077d894d1b755679bbe10744fe05b038ff0/third_party/libvpx/source/config/win/arm64/vpx_config.h
[add] https://crrev.com/1c18d077d894d1b755679bbe10744fe05b038ff0/third_party/libvpx/source/config/win/arm64/vpx_dsp_rtcd.h
[add] https://crrev.com/1c18d077d894d1b755679bbe10744fe05b038ff0/third_party/libvpx/source/config/win/arm64/vpx_scale_rtcd.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/mini_chromium/+/f701716d9546c00725eec4302a601796417fecef

commit f701716d9546c00725eec4302a601796417fecef
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Wed Dec 05 21:15:59 2018

Add Windows ARM64 build target to mini_chromium.

This is necessary for adding Windows ARM64 support to crashpad because crashpad depends on mini_chromium.

Bug: 893460
Change-Id: I058d08e68ed661636778ffb6dc823196b343b730
Reviewed-on: https://chromium-review.googlesource.com/c/1345247
Reviewed-by: Mark Mentovai <mark@chromium.org>

[delete] https://crrev.com/4a6189577978b86fbd6935aec0d16a127803467c/base/atomicops_internals_mac.h
[modify] https://crrev.com/f701716d9546c00725eec4302a601796417fecef/base/logging.cc
[modify] https://crrev.com/f701716d9546c00725eec4302a601796417fecef/base/base.gyp
[modify] https://crrev.com/f701716d9546c00725eec4302a601796417fecef/build/win_helper.py
[modify] https://crrev.com/f701716d9546c00725eec4302a601796417fecef/base/BUILD.gn
[modify] https://crrev.com/f701716d9546c00725eec4302a601796417fecef/build/build_config.h
[modify] https://crrev.com/f701716d9546c00725eec4302a601796417fecef/base/atomicops.h
[delete] https://crrev.com/4a6189577978b86fbd6935aec0d16a127803467c/base/atomicops_internals_x86_msvc.h
[modify] https://crrev.com/f701716d9546c00725eec4302a601796417fecef/build/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e42d764aec4389504eda9e33749db74d7c947fa0

commit e42d764aec4389504eda9e33749db74d7c947fa0
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Mon Dec 10 23:50:00 2018

Update build instructions for ARM64 Win32

Update the VS install instructions for those who want to try building
Chromium for ARM64 Win32. This also updates the instructions regarding
VS versions and Windows SDK versions.

The results were tested with both https://dillinger.io/ and
python tools/md_browser/md_browser.py docs\windows_build_instructions.md
since neither one gives 100% correct results. In both cases the
multi-line shell command options are copied as intended.

Bug: 893460
Change-Id: Ib3e950c4e4a9ef87e32c89733e4636a8bf06ba54
Reviewed-on: https://chromium-review.googlesource.com/c/1369030
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615328}
[modify] https://crrev.com/e42d764aec4389504eda9e33749db74d7c947fa0/docs/windows_build_instructions.md

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b

commit 761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Wed Dec 12 21:54:55 2018

Add Windows ARM64 support to Chromium crashpad

Bug: chromium:893460
Change-Id: Ifbeb6f937a6b96c77b02dcf8afe492c5bc617435
Reviewed-on: https://chromium-review.googlesource.com/c/1347773
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/client/crashpad_client_win.cc
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/snapshot/win/cpu_context_win.cc
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/snapshot/win/cpu_context_win.h
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/snapshot/win/crashpad_snapshot_test_crashing_child.cc
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/snapshot/win/exception_snapshot_win.cc
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/snapshot/win/exception_snapshot_win.h
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/snapshot/win/process_reader_win_test.cc
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/snapshot/win/process_snapshot_win.cc
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/snapshot/win/system_snapshot_win.cc
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/snapshot/win/system_snapshot_win_test.cc
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/snapshot/win/thread_snapshot_win.cc
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/snapshot/win/thread_snapshot_win.h
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/third_party/zlib/BUILD.gn
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/util/BUILD.gn
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/util/misc/capture_context_test_util_win.cc
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/util/net/http_transport_win.cc
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/util/util.gyp
[add] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/util/win/context_wrappers.h
[modify] https://crrev.com/761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b/util/win/safe_terminate_process_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd8c7b26d4da856b36edba4b2d8dff5a786d3eb4

commit dd8c7b26d4da856b36edba4b2d8dff5a786d3eb4
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Thu Dec 13 00:31:51 2018

ARM64 capable toolchain hash

This updates Chrome to build with a toolchain based on VS 2017 15.9.3
and the Windows 10.0.17763.132 SDK, with the ARM64 components included to
support building for ARM64 for Win32. This adds about 400 MB to the package
size, a bit less than a 50% increase.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

The package was created by downloading VS 2017 Update 9.3, from
https://www.visualstudio.com/vs/, and then running the installer like this:

$ PATH_TO_INSTALLER.EXE ^
    --add Microsoft.VisualStudio.Workload.NativeDesktop ^
    --add Microsoft.VisualStudio.Component.VC.ATLMFC ^
    --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^
    --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^
    --includeRecommended --passive

Then Add or Remove Programs was used to modify the SDK to add the
Debuggers package.

Then the packaging script was run like this:

  python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.17763.0

This was tested on two VMs to ensure that the results are consistent.

This should not significantly affect the x86 and x64 builds, although
there may have been some STL and CRT changes that could cause changes.

Bug: 893460
Change-Id: I33dd5b915ffaf17f306d804f561d26bf82060b03
Reviewed-on: https://chromium-review.googlesource.com/c/1342814
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616123}
[modify] https://crrev.com/dd8c7b26d4da856b36edba4b2d8dff5a786d3eb4/build/vs_toolchain.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5

commit bd9f6fa837fe8a51a95b5c6996dddc7572c288d5
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Thu Dec 13 05:20:49 2018

Update Crashpad to 761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b

3ca07134305c roll googletest to b18d39
c56557ae4a4f [fuchsia][arm64][snapshot] remove NOTREACHEDs
109bece2c3bc Added support for running crashpad that is embedded inside
             a dll
1a9209b581b9 [fuchsia] actually clean up lock file in release mode
9b6dde910185 [fuchsia] remove Fuchsia-specific code in
             MoveFileOrDirectory
761c6fe8be0e Add Windows ARM64 support to Chromium crashpad

Bug: 893460
Change-Id: I6f3cb01cdd7c30ed1ee5e963faab7ee87975ded1
Reviewed-on: https://chromium-review.googlesource.com/c/1375372
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616220}
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/README.chromium
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/DEPS
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/client/crashpad_client_win.cc
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/client/settings.cc
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/snapshot/fuchsia/system_snapshot_fuchsia.cc
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/snapshot/win/cpu_context_win.cc
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/snapshot/win/cpu_context_win.h
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_crashing_child.cc
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win.cc
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win.h
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/snapshot/win/process_reader_win_test.cc
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/snapshot/win/system_snapshot_win.cc
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/snapshot/win/system_snapshot_win_test.cc
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/snapshot/win/thread_snapshot_win.cc
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/snapshot/win/thread_snapshot_win.h
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/third_party/gtest/BUILD.gn
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/third_party/zlib/BUILD.gn
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/util/BUILD.gn
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/util/file/filesystem_posix.cc
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/util/misc/capture_context_test_util_win.cc
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/util/net/http_transport_win.cc
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/util/util.gyp
[add] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/util/win/context_wrappers.h
[modify] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/third_party/crashpad/crashpad/util/win/safe_terminate_process_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee86e3d1d70c04102da0a2311f90819f343aee8e

commit ee86e3d1d70c04102da0a2311f90819f343aee8e
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Dec 13 11:36:09 2018

Revert "ARM64 capable toolchain hash"

This reverts commit dd8c7b26d4da856b36edba4b2d8dff5a786d3eb4.

Reason for revert: Breaks V8 compilation with msvc due to goma errors:
https://ci.chromium.org/p/v8/builders/luci.v8.try/v8_win64_msvc_compile_rel/b8927261102998791312

Original change's description:
> ARM64 capable toolchain hash
> 
> This updates Chrome to build with a toolchain based on VS 2017 15.9.3
> and the Windows 10.0.17763.132 SDK, with the ARM64 components included to
> support building for ARM64 for Win32. This adds about 400 MB to the package
> size, a bit less than a 50% increase.
> 
> Packaging was done on a Windows Server 2016 VM, cleanly created for this
> purpose.
> 
> The package was created by downloading VS 2017 Update 9.3, from
> https://www.visualstudio.com/vs/, and then running the installer like this:
> 
> $ PATH_TO_INSTALLER.EXE ^
>     --add Microsoft.VisualStudio.Workload.NativeDesktop ^
>     --add Microsoft.VisualStudio.Component.VC.ATLMFC ^
>     --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^
>     --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^
>     --includeRecommended --passive
> 
> Then Add or Remove Programs was used to modify the SDK to add the
> Debuggers package.
> 
> Then the packaging script was run like this:
> 
>   python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.17763.0
> 
> This was tested on two VMs to ensure that the results are consistent.
> 
> This should not significantly affect the x86 and x64 builds, although
> there may have been some STL and CRT changes that could cause changes.
> 
> Bug: 893460
> Change-Id: I33dd5b915ffaf17f306d804f561d26bf82060b03
> Reviewed-on: https://chromium-review.googlesource.com/c/1342814
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616123}

TBR=thakis@chromium.org,dpranke@chromium.org,brucedawson@chromium.org,scottmg@chromium.org

Change-Id: I17be21b124053a182157bfecd54d722f210e6171
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 893460
Reviewed-on: https://chromium-review.googlesource.com/c/1375125
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616270}
[modify] https://crrev.com/ee86e3d1d70c04102da0a2311f90819f343aee8e/build/vs_toolchain.py

Assigning this to me so that I can see it more easily.

905526: Enable sandbox unittests...
915046: Failures when rolling a new toolchain

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/baf7f48adbde3fe9a379ce947da32e1f6ec496f1

commit baf7f48adbde3fe9a379ce947da32e1f6ec496f1
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Fri Dec 21 17:53:15 2018

Fix IMMEDIATE_CRASH macro for MSVC build

Bug: 893460
Change-Id: Id2fc733196d0c02f296538367f6f8799c6cfea1b
Reviewed-on: https://chromium-review.googlesource.com/c/1384932
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#618551}
[modify] https://crrev.com/baf7f48adbde3fe9a379ce947da32e1f6ec496f1/base/logging.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/137baeee720450738202260fcff76a88d8e0dee5

commit 137baeee720450738202260fcff76a88d8e0dee5
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Sat Dec 22 00:44:29 2018

Roll src/third_party/pdfium eb3f4742a6bd..25bc9a92b338 (1 commits)

https://pdfium.googlesource.com/pdfium.git/+log/eb3f4742a6bd..25bc9a92b338


git log eb3f4742a6bd..25bc9a92b338 --date=short --no-merges --format='%ad %ae %s'
2018-12-21 Tom.Tan@microsoft.com Pick up Windows ARM64 support from base\logging.h


Created with:
  gclient setdep -r src/third_party/pdfium@25bc9a92b338

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium: 893460
TBR=dsinclair@chromium.org

Change-Id: I9b2edfcff86202d63d18a78d10d1e9f6cb1a3f5f
Reviewed-on: https://chromium-review.googlesource.com/c/1388960
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#618690}
[modify] https://crrev.com/137baeee720450738202260fcff76a88d8e0dee5/DEPS

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/9bc33b9638446e3fa5ab54bcee228e869697659e

commit 9bc33b9638446e3fa5ab54bcee228e869697659e
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Mon Dec 31 23:55:21 2018

Fix header file for _byteswap_ulong from MSVC CRT

According to below MSDN link, _byte_swap_ulong comes from stdlib.h, not intrin.h

https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/byteswap-uint64-byteswap-ulong-byteswap-ushort

Bug: chromium:893460
Change-Id: I381e27a367fdc7a72b7d8e844c3e9aaebf1fcf76
Reviewed-on: https://skia-review.googlesource.com/c/180444
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>

[modify] https://crrev.com/9bc33b9638446e3fa5ab54bcee228e869697659e/src/core/SkMathPriv.h
[modify] https://crrev.com/9bc33b9638446e3fa5ab54bcee228e869697659e/AUTHORS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/068cf64f883715401ec33c80c09bce0ee3e9d2b4

commit 068cf64f883715401ec33c80c09bce0ee3e9d2b4
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Jan 01 02:15:00 2019

Roll src/third_party/skia 61b3d1d00057..9bc33b963844 (1 commits)

https://skia.googlesource.com/skia.git/+log/61b3d1d00057..9bc33b963844


git log 61b3d1d00057..9bc33b963844 --date=short --no-merges --format='%ad %ae %s'
2018-12-31 Tom.Tan@microsoft.com Fix header file for _byteswap_ulong from MSVC CRT


Created with:
  gclient setdep -r src/third_party/skia@9bc33b963844

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:893460
TBR=bungeman@chromium.org

Change-Id: Ibb9f050d8ff1956fc9e54ec1b37e1476be4342d3
Reviewed-on: https://chromium-review.googlesource.com/c/1392898
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619325}
[modify] https://crrev.com/068cf64f883715401ec33c80c09bce0ee3e9d2b4/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/breakpad/breakpad/+/b988fa74ec18de6214b18f723e48331d9a7802ae

commit b988fa74ec18de6214b18f723e48331d9a7802ae
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Thu Jan 03 00:10:28 2019

Extract intruction pointer correctly for Windows ARM64

Bug: 893460
Change-Id: Ibbdf734e72c29c4779b6a701dceec1626056a9ba
Reviewed-on: https://chromium-review.googlesource.com/c/1393763
Reviewed-by: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/b988fa74ec18de6214b18f723e48331d9a7802ae/src/client/windows/handler/exception_handler.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2972dd7d97cae140e359cbe18a05c950c4b12b2

commit a2972dd7d97cae140e359cbe18a05c950c4b12b2
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Fri Jan 04 00:00:19 2019

Fix GetTSC test to handle ARM64 on Win32

The recently added timer performance test for __rdtsc fails to compile
on ARM64, for obvious reasons. This change fixes the test to use the
ARM64 cycle counter when building for that platform.

The ReadCycleCounter definition was copied from base\time\time_win.cc

Bug: 893460
Change-Id: I0d891c5a197e097084a765ab66e9da1b4173b418
Reviewed-on: https://chromium-review.googlesource.com/c/1394987
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619820}
[modify] https://crrev.com/a2972dd7d97cae140e359cbe18a05c950c4b12b2/base/time/time_win_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a16f2ba48fc76eeb4a2812cc8f2d774a5c1f8c3

commit 2a16f2ba48fc76eeb4a2812cc8f2d774a5c1f8c3
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Fri Jan 04 18:19:09 2019

Reland "ARM64 capable toolchain hash"

This is a reland of dd8c7b26d4da856b36edba4b2d8dff5a786d3eb4

Original change's description:
> ARM64 capable toolchain hash
>
> This updates Chrome to build with a toolchain based on VS 2017 15.9.3
> and the Windows 10.0.17763.132 SDK, with the ARM64 components included to
> support building for ARM64 for Win32. This adds about 400 MB to the package
> size, a bit less than a 50% increase.
>
> Packaging was done on a Windows Server 2016 VM, cleanly created for this
> purpose.
>
> The package was created by downloading VS 2017 Update 9.3, from
> https://www.visualstudio.com/vs/, and then running the installer like this:
>
> $ PATH_TO_INSTALLER.EXE ^
>     --add Microsoft.VisualStudio.Workload.NativeDesktop ^
>     --add Microsoft.VisualStudio.Component.VC.ATLMFC ^
>     --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^
>     --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^
>     --includeRecommended --passive
>
> Then Add or Remove Programs was used to modify the SDK to add the
> Debuggers package.
>
> Then the packaging script was run like this:
>
>   python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.17763.0
>
> This was tested on two VMs to ensure that the results are consistent.
>
> This should not significantly affect the x86 and x64 builds, although
> there may have been some STL and CRT changes that could cause changes.
>
> Bug: 893460
> Change-Id: I33dd5b915ffaf17f306d804f561d26bf82060b03
> Reviewed-on: https://chromium-review.googlesource.com/c/1342814
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616123}

Bug: 893460, 915046 
Change-Id: I1f4f8fb7f37785ba935ef698964fa87f9a91e313
Reviewed-on: https://chromium-review.googlesource.com/c/1377510
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620001}
[modify] https://crrev.com/2a16f2ba48fc76eeb4a2812cc8f2d774a5c1f8c3/build/vs_toolchain.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8c851991162df9699b10ae29de9391adfc7eca4

commit b8c851991162df9699b10ae29de9391adfc7eca4
Author: Matthew Wolenetz <wolenetz@chromium.org>
Date: Fri Jan 04 19:35:46 2019

Revert "Reland "ARM64 capable toolchain hash""

This reverts commit 2a16f2ba48fc76eeb4a2812cc8f2d774a5c1f8c3.

Reason for revert: Strongly suspected as culprit for  bug 919163 : angle_deqp_gles2_d3d11_tests failing on chromium.gpu.fyi/Win7 FYI dEQP Release (AMD)

Original change's description:
> Reland "ARM64 capable toolchain hash"
> 
> This is a reland of dd8c7b26d4da856b36edba4b2d8dff5a786d3eb4
> 
> Original change's description:
> > ARM64 capable toolchain hash
> >
> > This updates Chrome to build with a toolchain based on VS 2017 15.9.3
> > and the Windows 10.0.17763.132 SDK, with the ARM64 components included to
> > support building for ARM64 for Win32. This adds about 400 MB to the package
> > size, a bit less than a 50% increase.
> >
> > Packaging was done on a Windows Server 2016 VM, cleanly created for this
> > purpose.
> >
> > The package was created by downloading VS 2017 Update 9.3, from
> > https://www.visualstudio.com/vs/, and then running the installer like this:
> >
> > $ PATH_TO_INSTALLER.EXE ^
> >     --add Microsoft.VisualStudio.Workload.NativeDesktop ^
> >     --add Microsoft.VisualStudio.Component.VC.ATLMFC ^
> >     --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^
> >     --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^
> >     --includeRecommended --passive
> >
> > Then Add or Remove Programs was used to modify the SDK to add the
> > Debuggers package.
> >
> > Then the packaging script was run like this:
> >
> >   python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.17763.0
> >
> > This was tested on two VMs to ensure that the results are consistent.
> >
> > This should not significantly affect the x86 and x64 builds, although
> > there may have been some STL and CRT changes that could cause changes.
> >
> > Bug: 893460
> > Change-Id: I33dd5b915ffaf17f306d804f561d26bf82060b03
> > Reviewed-on: https://chromium-review.googlesource.com/c/1342814
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#616123}
> 
> Bug: 893460, 915046 
> Change-Id: I1f4f8fb7f37785ba935ef698964fa87f9a91e313
> Reviewed-on: https://chromium-review.googlesource.com/c/1377510
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#620001}

TBR=thakis@chromium.org,dpranke@chromium.org,machenbach@chromium.org,brucedawson@chromium.org,scottmg@chromium.org

Change-Id: Ic032ab4307045ada9b2f6e0955bc4ad7dc8e84f8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 893460,  915046 ,  919163 
Reviewed-on: https://chromium-review.googlesource.com/c/1396560
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620030}
[modify] https://crrev.com/b8c851991162df9699b10ae29de9391adfc7eca4/build/vs_toolchain.py

The following revision refers to this bug:
  https://swiftshader.googlesource.com/SwiftShader.git/+/f6d56f15c09eb6b85163112cc813123583e77cc1

commit f6d56f15c09eb6b85163112cc813123583e77cc1
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Mon Jan 07 19:46:19 2019

Add intrinsics and missing LLVM AsmParser files for Windows ARM64

llvm::parseIR in llvm-7.0\llvm\lib\IRReader\IRReader.cpp calls parseAssembly
which is defined in lib/AsmParser/Parser.cpp, but the latter file is not
included in swiftshader_llvm which causes unresovled symbol for linking.
This CL added the necessary source files under llvm\AsmParser to
swiftshader_llvm.

This CL also changed __rdtsc() to use Windows ARM64 intrinsic _ReadStatusReg
to get cycle counter as alternative of __rdtsc().

Bug: chromium:893460
Change-Id: I269662f2e4249a3ec5495ecad02bc759139e1d4f
Reviewed-on: https://swiftshader-review.googlesource.com/c/23508
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Tom Tan <Tom.Tan@microsoft.com>

[modify] https://crrev.com/f6d56f15c09eb6b85163112cc813123583e77cc1/src/Common/Timer.cpp
[modify] https://crrev.com/f6d56f15c09eb6b85163112cc813123583e77cc1/src/OpenGL/libEGL/Display.cpp
[modify] https://crrev.com/f6d56f15c09eb6b85163112cc813123583e77cc1/third_party/llvm-7.0/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72facd799574df60163963ea0485c875a63b7dbf

commit 72facd799574df60163963ea0485c875a63b7dbf
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Mon Jan 07 21:55:10 2019

Add MIDL output for Windows ARM64

All these files are generated by MIDL tool from Visual Studio for Windows ARM64
 based on latest Chromium mater branch.

Bug: 893460
Change-Id: I244c28ae2811e411807e13559a1c10c0fc3a5da4
Reviewed-on: https://chromium-review.googlesource.com/c/1395191
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620492}
[modify] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/README.chromium
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/chrome/elevation_service/arm64/elevation_service_idl.dlldata.c
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/chrome/elevation_service/arm64/elevation_service_idl.h
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/chrome/elevation_service/arm64/elevation_service_idl.tlb
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/chrome/elevation_service/arm64/elevation_service_idl_i.c
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/chrome/elevation_service/arm64/elevation_service_idl_p.c
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/iaccessible2/arm64/ia2_api_all.dlldata.c
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/iaccessible2/arm64/ia2_api_all.h
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/iaccessible2/arm64/ia2_api_all.tlb
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/iaccessible2/arm64/ia2_api_all_i.c
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/iaccessible2/arm64/ia2_api_all_p.c
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/isimpledom/ISimpleDOMDocument.idl/arm64/ISimpleDOMDocument.dlldata.c
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/isimpledom/ISimpleDOMDocument.idl/arm64/ISimpleDOMDocument.h
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/isimpledom/ISimpleDOMDocument.idl/arm64/ISimpleDOMDocument_i.c
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/isimpledom/ISimpleDOMDocument.idl/arm64/ISimpleDOMDocument_p.c
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/isimpledom/ISimpleDOMNode.idl/arm64/ISimpleDOMNode.dlldata.c
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/isimpledom/ISimpleDOMNode.idl/arm64/ISimpleDOMNode.h
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/isimpledom/ISimpleDOMNode.idl/arm64/ISimpleDOMNode_i.c
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/isimpledom/ISimpleDOMNode.idl/arm64/ISimpleDOMNode_p.c
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/isimpledom/ISimpleDOMText.idl/arm64/ISimpleDOMText.dlldata.c
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/isimpledom/ISimpleDOMText.idl/arm64/ISimpleDOMText.h
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/isimpledom/ISimpleDOMText.idl/arm64/ISimpleDOMText_i.c
[add] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/midl/third_party/isimpledom/ISimpleDOMText.idl/arm64/ISimpleDOMText_p.c
[modify] https://crrev.com/72facd799574df60163963ea0485c875a63b7dbf/third_party/win_build_output/remidl.bat

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa675251d9e1778e19ac77c5bef290c2e78c04b0

commit aa675251d9e1778e19ac77c5bef290c2e78c04b0
Author: Jon Kunkee <jkunkee@microsoft.com>
Date: Mon Jan 07 23:47:42 2019

Fix CDB.exe copy script for ARM64 Windows

This change adds ARM64 support to the CDB.exe copy script. Also, since
ARM64 Windows is by definition Windows 10 1709+, the eventing-provider
and ucrtbase DLLs are shipped with the OS and do not need to be copied.

Bug: 893460
Change-Id: Ia278c4636bc1303c24f174df88f6232a2e403c82
Reviewed-on: https://chromium-review.googlesource.com/c/1399289
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620533}
[modify] https://crrev.com/aa675251d9e1778e19ac77c5bef290c2e78c04b0/build/win/copy_cdb_to_output.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fe5e8635c22f578ae96fffbec0047fc4cd5098c

commit 1fe5e8635c22f578ae96fffbec0047fc4cd5098c
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Wed Jan 09 23:51:03 2019

ARM64 capable toolchain with old d3dcompiler

This is a reland of crrev.com/c/1377510, with a new toolchain hash due to
packaging an old version of d3dcompiler_47.dll.

This updates Chrome to build with a toolchain based on VS 2017 15.9.3
and the Windows 10.0.17763.132 SDK, with the ARM64 components included to
support building for ARM64 for Win32. This adds about 400 MB to the package
size, a bit less than a 50% increase. This package contains the 17134 version
of d3dcompiler_47.dll, to avoid gaining a dependency on the universal CRT
which would cause problems for some Windows 7 machines ( bug 919163 ).

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

The package was created by downloading VS 2017 Update 9.3, from
https://www.visualstudio.com/vs/, and then running the installer like this:

$ PATH_TO_INSTALLER.EXE ^
    --add Microsoft.VisualStudio.Workload.NativeDesktop ^
    --add Microsoft.VisualStudio.Component.VC.ATLMFC ^
    --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^
    --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^
    --includeRecommended --passive

Then Add or Remove Programs was used to modify the SDK to add the
Debuggers package.

Then the packaging script was run like this:

  python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.17763.0

This was tested on two VMs to ensure that the results are consistent.

Since the new d3dcompiler_47.dll uses the UCRT and we want to avoid shipping
that the final packaging step was to unzip the package, copy over the two copies
of that DLL from win_sdk\Redist, and then repackage the toolchain with:
  > python package_from_installed.py --repackage=<full-path-to-toolchain-dir>

This should not significantly affect the x86 and x64 builds, although
there may have been some STL and CRT changes that could cause changes.

Bug: 893460,  915046 ,  919163 
Change-Id: I5891479863dd8371505ca9a4439f6939aa564ba8
Reviewed-on: https://chromium-review.googlesource.com/c/1401403
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621376}
[modify] https://crrev.com/1fe5e8635c22f578ae96fffbec0047fc4cd5098c/build/vs_toolchain.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/4b75b8bab99385646911c24403a016ce9c3d5740

commit 4b75b8bab99385646911c24403a016ce9c3d5740
Author: chcunningham <chcunningham@chromium.org>
Date: Fri Jan 11 03:05:53 2019

Add ARM64 Windows support to the Chromium FFMPEG repo

This change adds the necessary paths in the Chromium config and GN
generation scripts to include ARM64 Windows in future ffmpeg rolls.

This includes skipping linking for this platform since lld-link hits a
'relocation out of range' bug during the roll build's link phase.

It also includes the resulting ARM64 Windows configuration files,
generated in Linux following the ffmpeg roll instructions.

The generate_gn.py unit tests were also updated to reflect this change.

Bug: 893460
Change-Id: Ib43bc76f403dacc4da75f0c8ee63c73bb4436d60
Reviewed-on: https://chromium-review.googlesource.com/c/1334688
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>

[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chrome/win/arm64/libavutil/ffversion.h
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chromium/win/arm64/libavcodec/bsf_list.c
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chromium/win/arm64/libavutil/avconfig.h
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chrome/win/arm64/config.h
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chrome/win/arm64/libavcodec/bsf_list.c
[modify] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/scripts/generate_gn.py
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chromium/win/arm64/libavcodec/codec_list.c
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chromium/win/arm64/libavformat/muxer_list.c
[modify] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/ffmpeg_generated.gni
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chrome/win/arm64/libavutil/avconfig.h
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chromium/win/arm64/libavformat/demuxer_list.c
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chrome/win/arm64/libavcodec/parser_list.c
[modify] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/scripts/build_ffmpeg.py
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chromium/win/arm64/libavutil/ffversion.h
[modify] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/scripts/fake_linker.py
[modify] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/scripts/generate_gn_unittest.py
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chrome/win/arm64/libavformat/muxer_list.c
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chromium/win/arm64/libavcodec/parser_list.c
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chromium/win/arm64/libavformat/protocol_list.c
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chromium/win/arm64/config.h
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chrome/win/arm64/libavcodec/codec_list.c
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chrome/win/arm64/libavformat/demuxer_list.c
[add] https://crrev.com/4b75b8bab99385646911c24403a016ce9c3d5740/chromium/config/Chrome/win/arm64/libavformat/protocol_list.c

The following revision refers to this bug:
  https://boringssl.googlesource.com/boringssl/+/de3c1f69cc8422f94e4415b34398f3be29fa1f83

commit de3c1f69cc8422f94e4415b34398f3be29fa1f83
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Mon Jan 14 19:49:39 2019

Fix header file for _byteswap_ulong and _byteswap_uint64 from MSVC CRT

_byteswap_ulong and _byteswap_uint64 are documented (see below link) as coming from stdlib.h.
 On some build configurations stdlib.h is pulled in by intrin.h but that is not guaranteed. In particular,
this assumption causes build breaks when building Chromium for Windows ARM64 with clang-cl. This
 change switches the #include to use the documented header file, thus fixing Windows ARM64 with clang-cl.


https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/byteswap-uint64-byteswap-ulong-byteswap-ushort

Bug: chromium:893460
Change-Id: I738c7227a9e156c894c2be62b52228a5bbd88414
Reviewed-on: https://boringssl-review.googlesource.com/c/34244
Reviewed-by: David Benjamin <davidben@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: David Benjamin <davidben@google.com>

[modify] https://crrev.com/de3c1f69cc8422f94e4415b34398f3be29fa1f83/crypto/internal.h

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b12390b20269b08dc0efab2509e19a6bc735cd91

commit b12390b20269b08dc0efab2509e19a6bc735cd91
Author: Jon Kunkee <jkunkee@microsoft.com>
Date: Wed Jan 16 09:25:04 2019

Add MSVC ARMASM capability to mksnapshot

When building v8 using MSVC (as for Node.js), clang-cl is not available
to act as an assembler. This change allows mksnapshot to accomodate this
fact by emitting assembly in the MSVC ARM assembler's format.

Incidentally, the MSVC ARM asm format is just the ARM, Holdings assembler's
asm format with a small handful of unimplemented features.

https://docs.microsoft.com/en-us/cpp/assembler/arm/arm-assembler-reference

Bug: chromium:893460,v8:8645
Change-Id: I1a6b765b0f9b4d117d7a6f100015a4f124442865
Reviewed-on: https://chromium-review.googlesource.com/c/1394758
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58842}
[modify] https://crrev.com/b12390b20269b08dc0efab2509e19a6bc735cd91/src/snapshot/embedded-file-writer.cc

The following revision refers to this bug:
  https://swiftshader.googlesource.com/SwiftShader.git/+/0571621b22539986406c9418ea71a2648d06c5ac

commit 0571621b22539986406c9418ea71a2648d06c5ac
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Thu Jan 17 18:53:06 2019

Port LLVM change rL350655

Chromium enabled warning -Wmicrosoft-include which complains the line "#include "Windows/WindowsSupport.h""
in lib/Support/Windows/Threading.inc because both files are under the same folder (see below error message). The fix was
merged to Clang master at https://reviews.llvm.org/rL350655. Port the change to unblock Windows ARM64 build before
a new rolling of LLVM to swiftshader.

error: #include resolved using non-portable Microsoft search rules as:
../../third_party/swiftshader/third_party/llvm-7.0/llvm/lib/Support/Windows/WindowsSupport.h [-Werror,-Wmicrosoft-include]

Bug: chromium:893460
Change-Id: I9eb32fd92e4d96f7d22a07a7c2da70b98eba19d3
Reviewed-on: https://swiftshader-review.googlesource.com/c/23669
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Tom Tan <Tom.Tan@microsoft.com>

[modify] https://crrev.com/0571621b22539986406c9418ea71a2648d06c5ac/third_party/llvm-7.0/llvm/lib/Support/Windows/Threading.inc

The following revision refers to this bug:
  https://chromium.googlesource.com/webm/libvpx/+/cc6d6a3b3f0f802ae0d5458b42e8ef7c896c9538

commit cc6d6a3b3f0f802ae0d5458b42e8ef7c896c9538
Author: Jon Kunkee <jkunkee@microsoft.com>
Date: Wed Jan 23 00:06:50 2019

Fix Windows SDK and VS version checks

If WindowsTargetPlatformVersion is not set, the Visual Studio 15 (2017)
toolchain assumes that Windows 8.1 is being targeted. Since ARM64
support is only present and unlocked in Windows SDKs >= Windows 10 1809,
set that SDK as required in the vcxproj files.

Note that this will not be an issue in Visual Studio 16 or greater,
hence the -eq major version check.

https://developercommunity.visualstudio.com/content/problem/128836/windowstargetplatformversion-to-use-the-latest-ava.html

Bug: chromium:893460

Change-Id: Ib069501ad384d91349b1f635722dedd31a4edd97

[modify] https://crrev.com/cc6d6a3b3f0f802ae0d5458b42e8ef7c896c9538/build/make/gen_msvs_vcxproj.sh

The following revision refers to this bug:
  https://chromium.googlesource.com/webm/libvpx/+/cc6d6a3b3f0f802ae0d5458b42e8ef7c896c9538

commit cc6d6a3b3f0f802ae0d5458b42e8ef7c896c9538
Author: Jon Kunkee <jkunkee@microsoft.com>
Date: Wed Jan 23 00:06:50 2019

Fix Windows SDK and VS version checks

If WindowsTargetPlatformVersion is not set, the Visual Studio 15 (2017)
toolchain assumes that Windows 8.1 is being targeted. Since ARM64
support is only present and unlocked in Windows SDKs >= Windows 10 1809,
set that SDK as required in the vcxproj files.

Note that this will not be an issue in Visual Studio 16 or greater,
hence the -eq major version check.

https://developercommunity.visualstudio.com/content/problem/128836/windowstargetplatformversion-to-use-the-latest-ava.html

Bug: chromium:893460

Change-Id: Ib069501ad384d91349b1f635722dedd31a4edd97

[modify] https://crrev.com/cc6d6a3b3f0f802ae0d5458b42e8ef7c896c9538/build/make/gen_msvs_vcxproj.sh

The following revision refers to this bug:
  https://chromium.googlesource.com/webm/libvpx/+/cc6d6a3b3f0f802ae0d5458b42e8ef7c896c9538

commit cc6d6a3b3f0f802ae0d5458b42e8ef7c896c9538
Author: Jon Kunkee <jkunkee@microsoft.com>
Date: Wed Jan 23 00:06:50 2019

Fix Windows SDK and VS version checks

If WindowsTargetPlatformVersion is not set, the Visual Studio 15 (2017)
toolchain assumes that Windows 8.1 is being targeted. Since ARM64
support is only present and unlocked in Windows SDKs >= Windows 10 1809,
set that SDK as required in the vcxproj files.

Note that this will not be an issue in Visual Studio 16 or greater,
hence the -eq major version check.

https://developercommunity.visualstudio.com/content/problem/128836/windowstargetplatformversion-to-use-the-latest-ava.html

Bug: chromium:893460

Change-Id: Ib069501ad384d91349b1f635722dedd31a4edd97

[modify] https://crrev.com/cc6d6a3b3f0f802ae0d5458b42e8ef7c896c9538/build/make/gen_msvs_vcxproj.sh

The following revision refers to this bug:
  https://chromium.googlesource.com/webm/libvpx/+/cc6d6a3b3f0f802ae0d5458b42e8ef7c896c9538

commit cc6d6a3b3f0f802ae0d5458b42e8ef7c896c9538
Author: Jon Kunkee <jkunkee@microsoft.com>
Date: Wed Jan 23 00:06:50 2019

Fix Windows SDK and VS version checks

If WindowsTargetPlatformVersion is not set, the Visual Studio 15 (2017)
toolchain assumes that Windows 8.1 is being targeted. Since ARM64
support is only present and unlocked in Windows SDKs >= Windows 10 1809,
set that SDK as required in the vcxproj files.

Note that this will not be an issue in Visual Studio 16 or greater,
hence the -eq major version check.

https://developercommunity.visualstudio.com/content/problem/128836/windowstargetplatformversion-to-use-the-latest-ava.html

Bug: chromium:893460

Change-Id: Ib069501ad384d91349b1f635722dedd31a4edd97

[modify] https://crrev.com/cc6d6a3b3f0f802ae0d5458b42e8ef7c896c9538/build/make/gen_msvs_vcxproj.sh