S13N: Many cancelled network requests appear in DevTools that don't appear in non-S13N |
|||
Issue descriptionGo to https://www.soundslice.com/scores/33982/ and check the network activity. When ServicifiedServiceWorker or NetworkServive is on, there are many cancelled requests that don't appear in the legacy path. This is the link from issue 575357 which may be affected by issue 892227 .
,
Oct 9
CreateURLLoader gets called twice also in non-S13N, but there's no cancelled output in DevTools: [1:1:1009/164859.619140:ERROR:service_worker_network_provider.cc(102)] virtual std::unique_ptr<blink::WebURLLoader> content::(anonymous namespace)::WebServiceWorkerNetworkProviderForFrame::CreateURLLoader(const blink::WebURLRequest &, std::unique_ptr<blink::scheduler::WebResourceLoadingTaskRunnerHandle>): https://d3l4lslmo9uf22.cloudfront.net/r/14048/video-hls-v500022.ts [1:1:1009/164859.621103:ERROR:service_worker_network_provider.cc(102)] virtual std::unique_ptr<blink::WebURLLoader> content::(anonymous namespace)::WebServiceWorkerNetworkProviderForFrame::CreateURLLoader(const blink::WebURLRequest &, std::unique_ptr<blink::scheduler::WebResourceLoadingTaskRunnerHandle>): https://d3l4lslmo9uf22.cloudfront.net/r/14048/video-hls-v500022.ts
,
Oct 11
Also if I set a breakpoint in the service worker's fetch event, it only gets hit once for the main resource request. Subsequent requests don't stop at the breakpoint even though the service worker is running.
,
Oct 11
The service worker returns a "fallback was required" response. I discovered in non-S13nSW these requests are suppressed by matching on the HTTP response status line "Service Worker Fallback Required" via issue 477685 . In S13nSW we aren't adding this line.
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6bd3f0297d8ebb3e76908e83295cb17fdffcc92 commit b6bd3f0297d8ebb3e76908e83295cb17fdffcc92 Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Oct 11 09:43:19 2018 service worker: s13n: Don't show CORS fallback responses in DevTools. DevTools recognizes the string "Service Worker Fallback Required" (see issue 477685 ) and doesn't show the response in that case. Bug: 893459 Change-Id: Ieadd2d1ce3e738b866ae78d20396c36fb8880c75 Reviewed-on: https://chromium-review.googlesource.com/c/1276065 Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#598709} [modify] https://crrev.com/b6bd3f0297d8ebb3e76908e83295cb17fdffcc92/content/renderer/service_worker/service_worker_subresource_loader.cc [modify] https://crrev.com/b6bd3f0297d8ebb3e76908e83295cb17fdffcc92/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
,
Oct 12
,
Oct 19
Fixed in M71. |
|||
►
Sign in to add a comment |
|||
Comment 1 by falken@chromium.org
, Oct 9