New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 893456 link

Starred by 8 users
Status: Fixed
Owner:
malaykeshav@chromium.org
Closed: Oct 10
Cc:
█ reed@chromium.org
a...@chromium.org
meh...@chromium.org
nyerramilli@chromium.org
msw@chromium.org
rbasuvula@chromium.org
afakhry@chromium.org
ellyjo...@chromium.org
malaykeshav@chromium.org
osh...@chromium.org
taku...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Arrows are seen distorted on wrench menu.

Reported by shruti.j...@etouch.net, Oct 9 
Chrome Version: 71.0.3574.0 (Official Build)Revision	90c2ba94f7158703b83270aa5db0203821a5fcca-refs/branch-heads/3574@{#1} (64-bit) 
OS : Windows(7, 8, 8.1 ,10)


What steps will reproduce the problem?
1.Launch chrome and click on three dots and open wrench menu.
2.Observe the sub-listing arrow icons of Eg.History,Bookmarks,More tools...

Actual Result :Arrows are seen distorted on wrench menu.
Expected Result :Arrows should be seen proper on wrench menu.

This is a regression issue broken in ‘M-71’ and will soon inform the bisect info:
Good Build :71.0.3573.0 
Bad Build : 71.0.3574.0 

Kindly refer the attached screen-cast.

Thank you..!
Expected_Result.mp4
296 KB View Download
Actual_Result.mp4
190 KB View Download

Comment 1 by shruti.j...@etouch.net, Oct 9

Labels: hasbisect OS-Linux OS-Mac
Owner: malaykeshav@chromium.org
Status: Assigned (was: Unconfirmed)

Updates:
Bisect info:
You are probably looking for a change made after 597645 (known good), but no later than 597651 (first known bad).

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/d7db601c688d4b4d0fdb492af5331e1e650743a3..dbffadb3cc285cd34d1e1d080aac15e161382d44 

Suspect:r597646 ?

@Malay Keshav   : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:

1.Unable to provide 'per-revision' bisect as it shows "We don't have enough builds to bisect" error message.
2.Tried on other machines but still getting the same error again.
3.Hence provided suspect through 'Chromium bisect'
4.Issue is also seen on OS :  Mac(10.12.6, 10.13.1, 10.14.1, 10.13.6), Linux(14.04 LTS)

Thank you..!

Comment 2 by malaykeshav@chromium.org, Oct 9

Cc: malaykeshav@chromium.org
 Issue 893463  has been merged into this issue.

Comment 3 by malaykeshav@chromium.org, Oct 9

Cc: msw@chromium.org
Status: Started (was: Assigned)

Comment 4 by malaykeshav@chromium.org, Oct 9

Labels: OS-Chrome
Working on a fix. Caused by: https://chromium-review.googlesource.com/c/chromium/src/+/1262967

Comment 5 by malaykeshav@chromium.org, Oct 9

Cc: osh...@chromium.org afakhry@chromium.org

Comment 7 by malaykeshav@chromium.org, Oct 10 

 Issue 893922  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b98be91d96f0b653bafce146c9d1f036a34b688

commit 5b98be91d96f0b653bafce146c9d1f036a34b688
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Wed Oct 10 19:49:42 2018

Update the image origin on preferred size change

Earlier image origin was computed for every paint. But with the new
model the image origin is updated only when needed and then cached.
However, a call to update the image origin was missing when a new image
was being set. To ensure such calls are not missed again, this change
updates the image origin whenever the preferred size changes thus making
things far less error prone.

Bug:  893456 
Change-Id: Ib6836bca67604e47384d8ae032dfc01ba3367f59
Component: ImageView, Images, Icons
Reviewed-on: https://chromium-review.googlesource.com/c/1271784
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598459}
[modify] https://crrev.com/5b98be91d96f0b653bafce146c9d1f036a34b688/ui/views/controls/image_view_base.cc
[modify] https://crrev.com/5b98be91d96f0b653bafce146c9d1f036a34b688/ui/views/controls/image_view_base.h
[modify] https://crrev.com/5b98be91d96f0b653bafce146c9d1f036a34b688/ui/views/controls/image_view_unittest.cc

Comment 9 by malaykeshav@chromium.org, Oct 10

Status: Fixed (was: Started)

Comment 10 by malaykeshav@chromium.org, Oct 10

Cc: ellyjo...@chromium.org a...@chromium.org meh...@chromium.org reed@chromium.org
 Issue 894206  has been merged into this issue.

Comment 11 by malaykeshav@chromium.org, Oct 10 

Issue 893709 has been merged into this issue.

Comment 12 by malaykeshav@chromium.org, Oct 11

Cc: taku...@chromium.org
 Issue 894626  has been merged into this issue.
►

Sign in to add a comment