New issue
Advanced search Search tips

Issue 893426 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Nov 9
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: textNodes should highlight with overlay on hover

Project Member Reported by l...@chromium.org, Oct 9 
Currently we only show the overlay highlight when hovering over an HTMLElement.  We should also highlight TextNodes, similar to other browsers' DevTools.

Originally requested in:  crbug.com/886596

Comment 1 by l...@chromium.org, Oct 11 

Screenshot: https://imgur.com/a/yPFT73e

Comment 2 by l...@chromium.org, Oct 11

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d9b1dd6f507174e18ae1c098912d9d28706efc9

commit 3d9b1dd6f507174e18ae1c098912d9d28706efc9
Author: Erik Luo <luoe@chromium.org>
Date: Fri Nov 09 22:57:40 2018

DevTools: highight text nodes with overlay

Hovering over a TextNode in DevTools will now highlight it on the
page. Its tooltip shows "#text" with VisualOverflowRect dimensions.

Screenshot: https://imgur.com/a/yPFT73e

Bug:  893426 
Change-Id: If988e72960aa68b2d9c666c5de3feb5ce1192509
Reviewed-on: https://chromium-review.googlesource.com/c/1269859
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607013}
[modify] https://crrev.com/3d9b1dd6f507174e18ae1c098912d9d28706efc9/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-expected.txt
[modify] https://crrev.com/3d9b1dd6f507174e18ae1c098912d9d28706efc9/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node.js
[modify] https://crrev.com/3d9b1dd6f507174e18ae1c098912d9d28706efc9/third_party/blink/renderer/core/inspector/inspector_highlight.cc
[modify] https://crrev.com/3d9b1dd6f507174e18ae1c098912d9d28706efc9/third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc
[modify] https://crrev.com/3d9b1dd6f507174e18ae1c098912d9d28706efc9/third_party/blink/renderer/devtools/front_end/elements_test_runner/ElementsTestRunner.js

Comment 4 by l...@chromium.org, Nov 9

Status: Fixed (was: Assigned)
►

Sign in to add a comment