New issue
Advanced search Search tips

Issue 893375 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 893373



Sign in to add a comment

Extensions: have declarativeContent.showPageAction work with any extension action

Project Member Reported by rdevlin....@chromium.org, Oct 9

Issue description

declarativeContent.showPageAction() should eventually become declarativeContent.showAction().  As an interim, showPageAction() should work with browser actions.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0cdf39e2c6d996b48c66295b3dfed507f550bda

commit f0cdf39e2c6d996b48c66295b3dfed507f550bda
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Tue Nov 27 04:35:03 2018

[Extensions] Let declarativeContent.showPageAction work with browser actions

There's not really much point in the distinction between page and
browser actions anymore, and we'd like to merge them. Make the
declarativeContent.showPageAction API work with browser actions.
A follow-up will introduce declarativeContent.showAction.

Bug: 893375
Change-Id: Ib4651c225099c62070239f0c37cb4b075d124b1c
Reviewed-on: https://chromium-review.googlesource.com/c/1270006
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611019}
[modify] https://crrev.com/f0cdf39e2c6d996b48c66295b3dfed507f550bda/chrome/browser/extensions/api/declarative_content/content_action.cc
[modify] https://crrev.com/f0cdf39e2c6d996b48c66295b3dfed507f550bda/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc
[modify] https://crrev.com/f0cdf39e2c6d996b48c66295b3dfed507f550bda/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c07b2aa975c46615bc24135f76206c280bcaf994

commit c07b2aa975c46615bc24135f76206c280bcaf994
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Wed Dec 05 20:26:00 2018

[Extensions] Add declarativeContent.showAction()

Add declarativeContent.showAction() as a duplicate of
declarativeContent.showPageAction(). This better conveys that the
content action applies to both types of extension action, and prepares
for a state where an extension can only specify a single action type.

Update tests for the same, and ensure we have testing for both
showAction() and showPageAction().

As of now, leave this undocumented. We'll add documentation for it when
it reaches stable and we can deprecate the old (in order to avoid the
"the old one's deprecated and the new one's not ready yet" state in the
docs).

Bug: 893375
Change-Id: I315da34cb6be8dbf23b5463b45718c1c46dee400
Reviewed-on: https://chromium-review.googlesource.com/c/1298170
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614077}
[modify] https://crrev.com/c07b2aa975c46615bc24135f76206c280bcaf994/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc
[modify] https://crrev.com/c07b2aa975c46615bc24135f76206c280bcaf994/chrome/browser/extensions/api/declarative_content/content_action.cc
[modify] https://crrev.com/c07b2aa975c46615bc24135f76206c280bcaf994/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc
[modify] https://crrev.com/c07b2aa975c46615bc24135f76206c280bcaf994/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc
[modify] https://crrev.com/c07b2aa975c46615bc24135f76206c280bcaf994/chrome/browser/extensions/extension_action.h
[modify] https://crrev.com/c07b2aa975c46615bc24135f76206c280bcaf994/chrome/common/extensions/api/declarative_content.json
[modify] https://crrev.com/c07b2aa975c46615bc24135f76206c280bcaf994/chrome/renderer/resources/extensions/declarative_content_custom_bindings.js
[modify] https://crrev.com/c07b2aa975c46615bc24135f76206c280bcaf994/chrome/test/data/extensions/api_test/declarative_content/persistence/background.js
[modify] https://crrev.com/c07b2aa975c46615bc24135f76206c280bcaf994/chrome/test/data/extensions/api_test/native_bindings/declarative_content/background.js
[modify] https://crrev.com/c07b2aa975c46615bc24135f76206c280bcaf994/extensions/browser/api/declarative/rules_registry_unittest.cc
[modify] https://crrev.com/c07b2aa975c46615bc24135f76206c280bcaf994/extensions/common/api/declarative/declarative_constants.cc
[modify] https://crrev.com/c07b2aa975c46615bc24135f76206c280bcaf994/extensions/common/api/declarative/declarative_constants.h
[modify] https://crrev.com/c07b2aa975c46615bc24135f76206c280bcaf994/extensions/common/api/declarative/declarative_manifest_data.cc
[modify] https://crrev.com/c07b2aa975c46615bc24135f76206c280bcaf994/extensions/common/api/declarative/declarative_manifest_unittest.cc
[modify] https://crrev.com/c07b2aa975c46615bc24135f76206c280bcaf994/extensions/renderer/declarative_content_hooks_delegate.cc

Sign in to add a comment