New issue
Advanced search Search tips

Issue 893369 link

Starred by 2 users
Status: Fixed
Owner:
fdegans@chromium.org
Closed: Nov 16
Cc:
w...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Death tests are flaky for component builds

Project Member Reported by kmarshall@chromium.org, Oct 8 
There is an issue with death tests running on component builds which is manifesting as missing lines from the child process' stderr. Death tests generally look for "Check failed" in the log stream. When that line is missing, the tests fail. The test failure looks like this:

../../mojo/core/options_validation_unittest.cc:107: Failure
Death test: { UserOptionsReader<TestOptions> reader((nullptr)); }
    Result: died but not with expected error.
  Expected: Check failed
Actual msg:
[  DEATH   ] [77016:990343821:1008/114539.766817:37340296:WARNING:test_suite.cc(258)] Test launcher output path /tmp/.org.chromium.Chromium.fDOokM/test_results.xml exists. Not adding test launcher result printer.
[  DEATH   ]

Here are some examples of failures on the bots:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-x64-dbg/2534
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-x64-dbg/2537
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-x64-dbg/2540
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-x64-dbg/2508


Local repro steps:

1. Add a trivial death test case:

`
TEST_F(Repro, Explodey) {
  EXPECT_DEATH_IF_SUPPORTED( {
    CHECK(false);
  }, "Check failed");
}
`

2. Build the test code in an output directory with the GN arg "is_component_build = true".

3. Run the test code repeatedly:

`
   out/OUTDIR/bin/run_test_suite --gtest_filter="Repro.Explodey" --gtest_repeat=1000 --gtest_break_on_failure
`

4. Wait until failure. It should fail relatively soon, after around 10-100 iterations.

Comment 2 by scottmg@chromium.org, Oct 12 

Seems pretty common, another example today: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-x64-dbg/2600

What's the status of that gtest change? "Hopefully-might-fix"? Or "dunno-yet"? Or "totally-not-going-to-help"?

Comment 3 by kmarshall@chromium.org, Oct 12 

The GTest change doesn't fix anything. We suspected the issue had to do with filesystem write races, so I rewrote the stderr capturing portion to avoid FS entirely in favor of using Zircon sockets for direct IPC. Nope, didn't fix the issue.

So I guess the problem that we're seeing is that data written to Zircon sockets is being dropped on process exit().

I suggested disabling the death tests until we have enough spare time, but Wez wants a go at it, so I shared my findings. :)

Comment 4 by kmarshall@chromium.org, Oct 12

Owner: w...@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by fdegans@chromium.org, Oct 15

Cc: w...@chromium.org
Owner: fdegans@chromium.org
Status: Started (was: Assigned)

Comment 6 by fdegans@chromium.org, Oct 15 

Status of this bug:
The gtest change didn't work. FYI, patch is here
https://chromium-review.googlesource.com/c/external/github.com/google/googletest/+/1277983/

Now suspecting fflush implementation in lic/musl.

Comment 7 by w...@chromium.org, Oct 15 

Re #6: FWIW, the gtest change from that patch hasn't been landed up-stream, and it has a bug whereby we might stop reading from the stderr pipe prematurely.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaaa227a50eff1e140a6f4ba9b0c2778b8a3e6cb

commit aaaa227a50eff1e140a6f4ba9b0c2778b8a3e6cb
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Wed Oct 17 21:07:18 2018

Fix strict ordering in SymbolMap::Populate

C++ Compare operators need to follow a strict weak ordering
requirement. The implementation used in SymbolMap::Populate didn't
meet this requirement.

Bug:  893369 
Change-Id: Id1b7e4e7c46feb3bf2098ff810656d1d003aef8c
Tested: Flakiness is gone.
Reviewed-on: https://chromium-review.googlesource.com/c/1286763
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600551}
[modify] https://crrev.com/aaaa227a50eff1e140a6f4ba9b0c2778b8a3e6cb/base/debug/stack_trace_fuchsia.cc

Comment 9 by fdegans@chromium.org, Oct 17 

There are a bunch of different issues involved. A race condition in gtest, truncated stderr, this is fixed in https://github.com/google/googletest/pull/1915
The CL in comment 8 fixes another issue which would cause a separate crash when creating the stack trace.
Once gtest has rolled, this bug should be fixed.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d8600057fedc8d5ab3c58ee651b6028dbb0caa1

commit 4d8600057fedc8d5ab3c58ee651b6028dbb0caa1
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Tue Oct 23 19:07:09 2018

Change a C-style array to an std::array

The sort function was not called with the proper arguments, missing
the last element in the array. This changes the structure to a C++
std::array and changes the arguments passed to the sort function to be
iterators rather than plain pointers.

Bug:  893369 
Change-Id: I0f8cb0b991055daf1a5d39284f72681238177f1d
Tested: Locally, tests still pass.
Reviewed-on: https://chromium-review.googlesource.com/c/1287200
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602041}
[modify] https://crrev.com/4d8600057fedc8d5ab3c58ee651b6028dbb0caa1/base/debug/stack_trace_fuchsia.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b9712c6b1e18844449e2b936f682f83f5bdd9a5f

commit b9712c6b1e18844449e2b936f682f83f5bdd9a5f
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Wed Oct 31 23:03:51 2018

Remove GTEST_HAS_COMBINE

This was removed from gtest and	is necessary to	roll gtest in
Chromium.

TBR=adamk@chromium.org

Bug:  chromium:893369 
Change-Id: I21762aa65ab2fc3f52731e7e812f0bf155f285e6
Reviewed-on: https://chromium-review.googlesource.com/c/1310598
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57193}
[modify] https://crrev.com/b9712c6b1e18844449e2b936f682f83f5bdd9a5f/test/unittests/compiler/machine-operator-unittest.cc
[modify] https://crrev.com/b9712c6b1e18844449e2b936f682f83f5bdd9a5f/test/unittests/compiler/regalloc/register-allocator-unittest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be707070f08c45daf3d1bb9e749dc3bdf3636092

commit be707070f08c45daf3d1bb9e749dc3bdf3636092
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Fri Nov 02 01:23:18 2018

Roll src/third_party/googletest/src/ 2e68926a9..879ac092f (182 commits)

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/2e68926a9d49..879ac092fde0

$ git log 2e68926a9..879ac092f --date=short --no-merges --format='%ad %ae %s'
2018-10-31 jerryturcios08 Correct grammatical error in README.md
2018-10-30 absl-team Googletest export
2018-10-30 misterg Googletest export
2018-10-29 absl-team Googletest export
2018-10-29 akonradi Add Optional() to the cheat sheet doc.
2018-10-29 misterg Googletest export
2018-10-29 misterg Googletest export
2018-10-28 vbrkov Replaced all NULLs with nullptr in googlemock
2018-10-28 vbrkov Replaced all NULLs with nullptr in googletest
2018-10-26 absl-team Googletest export
2018-10-24 absl-team Googletest export
2018-10-24 misterg Googletest export
2018-10-24 jeffvd.a216 Change CMake googletest download location in docs
2018-10-23 durandal Googletest export
2018-10-24 peter_jiachen Disable extensions and force standard
2018-10-24 peter_jiachen Revert previous changes
2018-10-24 peter_jiachen Fix -std=c++11 flag
2018-10-23 joelanderson333 add documentation of manual c++11 specification
2018-10-23 gennadiycivil Update advanced.md
2018-10-23 gennadiycivil Update advanced.md
2018-10-23 gennadiycivil Update advanced.md
2018-10-23 svg153 ACTION table format
2018-10-22 absl-team Googletest export
2018-10-19 gennadiycivil Update .travis.yml
2018-10-18 gennadiycivil Update .travis.yml
2018-10-18 misterg Googletest export
2018-10-16 absl-team Googletest export
2018-10-17 kakkoko Fix incorrect XML file name in help message
2018-10-16 jonathan.wendeborn Removed last reference to internal::kDefault
2018-10-16 jonathan.wendeborn Use existing Mock::GetReactionOnUninterestingCalls()
2018-10-16 jonathan.wendeborn Don't fully qualify enum member
2018-10-16 jonathan.wendeborn Added Mock::IsNaggy, IsNice, and IsStrict
2018-10-12 robert Change types to remove cast warnings.
2018-10-11 misterg Remove duplicate functionality PrintValue (in googletest-param-test-test.cc), use testing::PrintToString
2018-10-11 komh Merge c41b2bf861ef2ac1a975af05ff66d9256f280b01 into f203b2db77161fe54846ea9e839ebec81aeeccac
2018-10-11 dneto Merge 4c92120d6dedb4eeb499a8702faea0224e0a8b23 into 658c6390a5b363f46c6ad448ad1bce9d6e97e53a
2018-10-11 aarond Merge 41fc9745d4a448db7d932250d22fac1dda287443 into 658c6390a5b363f46c6ad448ad1bce9d6e97e53a
2018-10-09 absl-team Project import generated by Copybara.
2018-10-09 misterg Internal Change
2018-10-11 filipp.andjelo Use pcfiledir for prefix in pkgconfig file
2018-10-06 ryee88 fix typo
2018-10-10 spartucus Update .gitignore
2018-10-09 misterg Remove non-variadic pre C++11 AnyOf
2018-10-09 absl-team Unconditionally use std::tuple. Remove all mention of TR1 tuple and our own implementation of tuple.
2018-10-09 misterg Remove testing::internal::BothOfMatcher, no longer needed
2018-10-09 absl-team Apply [[noreturn]] to Abort()
2018-10-09 gennadiycivil Update Makefile.am
2018-10-09 gennadiycivil Update BUILD.bazel
2018-10-09 gennadiycivil Update README.md
2018-10-09 gennadiycivil Delete CHANGES
2018-10-09 gennadiycivil Delete CHANGES
2018-10-08 kuroiwa Merge c1170881039e859738c62b02a918116fc6d346bc into 27c86f29417e53a622a2902baab2d1d82dafc5f9
2018-10-08 misterg Fixing AllOfMatches test, where it properly belongs
2018-10-08 misterg always define define GTEST_LANG_CXX11 1
2018-10-08 misterg Remove non-variadic pre C++11 AllOf
2018-10-05 gennadiycivil Update primer.md
2018-10-05 misterg Remove pre-C++11 code from gtest-printers
2018-10-05 absl-team Make GTestColor and ColoredPrintF available as internal APIs from gtest.h.  This is for use in abseil exception safety testing.
2018-10-05 misterg Removed pre-C++11 IsContainerTest and IteratorTraits
2018-10-04 absl-team Apply clang-tidy modernize-use-nullptr to googletest.
2018-10-04 misterg Remove checking for C++ 11 and a pre-C++11 test from googletest tests
2018-10-03 theonetruecamper Merge d830440d48a9502161448bc78be33a53388dd1f4 into f5260ae757a681566d8f7d0558b8dc0551036506
2018-10-02 jerryturcios08 Remove compilation option for C++11 in the root CMakeLists.txt
2018-10-02 mateo.longo Merge c798e39a4f96f5a985126cc3fab4738b6412cfc1 into e93da23920e5b6887d6a6a291c3a59f83f5b579e
2018-10-02 jerryturcios08 Add compilation option for C++11 in the root CMakeLists.txt
2018-10-02 gennadiycivil Merge 68b8a4c60cd80c78e1875b77807fa13cdd2313f8 into 77962730563eece3525f40b8769e4ca0c6baf64c
2018-10-02 30830880+marbub Merge 86fe8a25eb5a6e4546f9e39cf23a5c764217bf85 into 440527a61e1c91188195f7de212c63c77e8f0a45
2018-10-01 arseny.aprelev Merge 2ce0685f76a4db403b7b2650433a584c150f2108 into 75e834700d19aa373b428c7c746f951737354c28
2018-10-01 misterg Googletest export
2018-09-27 durandal Googletest export
2018-09-30 jerryturcios08 Add a cached variable to CMAKE_CXX_STANDARD
2018-09-28 jerryturcios08 Add C++11 support in the root CMakeLists.txt
2018-09-26 gennadiycivil Update appveyor.yml
2018-09-25 gennadiycivil Revert "[mingw] enable the unittests for gmock and gtest again"
2018-09-25 gennadiycivil Keep one MinGW build, remove the others
2018-09-25 gennadiycivil Update appveyor.yml
2018-09-25 gennadiycivil Update appveyor.yml
2018-09-25 gennadiycivil Delete m4_ax_cxx_compile_stdcxx_11.m4
2018-09-25 gennadiycivil Delete m4_ax_cxx_compile_stdcxx.m4
2018-09-25 gennadiycivil Update configure.ac
2018-09-25 gennadiycivil Update Makefile.am
2018-09-25 gennadiycivil Update .travis.yml
2018-09-25 misterg automake
2018-09-25 misterg test automake c++11
2018-09-25 gennadiycivil Update configure.ac
2018-09-25 gennadiycivil Update configure.ac
2018-09-25 misterg typo
2018-09-25 misterg autotools c++11
2018-09-25 misterg autotools c++11
2018-09-25 misterg test
2018-09-25 misterg include c++11 for autotools
2018-09-25 absl-team Googletest export
2018-09-25 gennadiycivil Revert "Add clang format check to one of the builds"
2018-09-25 misterg Googletest export
2018-09-24 misterg Googletest export
2018-09-20 absl-team Googletest export
2018-09-25 misterg enable MingW on PR
2018-09-25 misterg C++11 autotools build
2018-09-25 misterg adding c++11 to appveyor mingW
2018-09-25 misterg typo
(...)

Created with:
  roll-dep src/third_party/googletest/src

TBR=thakis@chromium.org

Bug:  893369 
Change-Id: Ic7e13ff5fd3952c4d71ab23166a5c36dcad86b99
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1310634
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604801}
[modify] https://crrev.com/be707070f08c45daf3d1bb9e749dc3bdf3636092/DEPS
[modify] https://crrev.com/be707070f08c45daf3d1bb9e749dc3bdf3636092/base/test/gtest_xml_unittest_result_printer.cc
[modify] https://crrev.com/be707070f08c45daf3d1bb9e749dc3bdf3636092/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/be707070f08c45daf3d1bb9e749dc3bdf3636092/media/base/audio_shifter_unittest.cc
[modify] https://crrev.com/be707070f08c45daf3d1bb9e749dc3bdf3636092/third_party/cacheinvalidation/overrides/google/cacheinvalidation/deps/gmock.h
[modify] https://crrev.com/be707070f08c45daf3d1bb9e749dc3bdf3636092/third_party/googletest/BUILD.gn
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b79ddef34f74fb645c3eec840f0ba0100d2e1cb

commit 1b79ddef34f74fb645c3eec840f0ba0100d2e1cb
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Fri Nov 02 02:13:27 2018

Revert "Roll src/third_party/googletest/src/ 2e68926a9..879ac092f (182 commits)"

This reverts commit be707070f08c45daf3d1bb9e749dc3bdf3636092.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 604801 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JlNzA3MDcwZjA4YzQ1ZGFmM2QxYmI5ZTc0OWRjM2JkZjM2MzYwOTIM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win-rel/5462

Sample Failed Step: compile

Original change's description:
> Roll src/third_party/googletest/src/ 2e68926a9..879ac092f (182 commits)
> 
> https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/2e68926a9d49..879ac092fde0
> 
> $ git log 2e68926a9..879ac092f --date=short --no-merges --format='%ad %ae %s'
> 2018-10-31 jerryturcios08 Correct grammatical error in README.md
> 2018-10-30 absl-team Googletest export
> 2018-10-30 misterg Googletest export
> 2018-10-29 absl-team Googletest export
> 2018-10-29 akonradi Add Optional() to the cheat sheet doc.
> 2018-10-29 misterg Googletest export
> 2018-10-29 misterg Googletest export
> 2018-10-28 vbrkov Replaced all NULLs with nullptr in googlemock
> 2018-10-28 vbrkov Replaced all NULLs with nullptr in googletest
> 2018-10-26 absl-team Googletest export
> 2018-10-24 absl-team Googletest export
> 2018-10-24 misterg Googletest export
> 2018-10-24 jeffvd.a216 Change CMake googletest download location in docs
> 2018-10-23 durandal Googletest export
> 2018-10-24 peter_jiachen Disable extensions and force standard
> 2018-10-24 peter_jiachen Revert previous changes
> 2018-10-24 peter_jiachen Fix -std=c++11 flag
> 2018-10-23 joelanderson333 add documentation of manual c++11 specification
> 2018-10-23 gennadiycivil Update advanced.md
> 2018-10-23 gennadiycivil Update advanced.md
> 2018-10-23 gennadiycivil Update advanced.md
> 2018-10-23 svg153 ACTION table format
> 2018-10-22 absl-team Googletest export
> 2018-10-19 gennadiycivil Update .travis.yml
> 2018-10-18 gennadiycivil Update .travis.yml
> 2018-10-18 misterg Googletest export
> 2018-10-16 absl-team Googletest export
> 2018-10-17 kakkoko Fix incorrect XML file name in help message
> 2018-10-16 jonathan.wendeborn Removed last reference to internal::kDefault
> 2018-10-16 jonathan.wendeborn Use existing Mock::GetReactionOnUninterestingCalls()
> 2018-10-16 jonathan.wendeborn Don't fully qualify enum member
> 2018-10-16 jonathan.wendeborn Added Mock::IsNaggy, IsNice, and IsStrict
> 2018-10-12 robert Change types to remove cast warnings.
> 2018-10-11 misterg Remove duplicate functionality PrintValue (in googletest-param-test-test.cc), use testing::PrintToString
> 2018-10-11 komh Merge c41b2bf861ef2ac1a975af05ff66d9256f280b01 into f203b2db77161fe54846ea9e839ebec81aeeccac
> 2018-10-11 dneto Merge 4c92120d6dedb4eeb499a8702faea0224e0a8b23 into 658c6390a5b363f46c6ad448ad1bce9d6e97e53a
> 2018-10-11 aarond Merge 41fc9745d4a448db7d932250d22fac1dda287443 into 658c6390a5b363f46c6ad448ad1bce9d6e97e53a
> 2018-10-09 absl-team Project import generated by Copybara.
> 2018-10-09 misterg Internal Change
> 2018-10-11 filipp.andjelo Use pcfiledir for prefix in pkgconfig file
> 2018-10-06 ryee88 fix typo
> 2018-10-10 spartucus Update .gitignore
> 2018-10-09 misterg Remove non-variadic pre C++11 AnyOf
> 2018-10-09 absl-team Unconditionally use std::tuple. Remove all mention of TR1 tuple and our own implementation of tuple.
> 2018-10-09 misterg Remove testing::internal::BothOfMatcher, no longer needed
> 2018-10-09 absl-team Apply [[noreturn]] to Abort()
> 2018-10-09 gennadiycivil Update Makefile.am
> 2018-10-09 gennadiycivil Update BUILD.bazel
> 2018-10-09 gennadiycivil Update README.md
> 2018-10-09 gennadiycivil Delete CHANGES
> 2018-10-09 gennadiycivil Delete CHANGES
> 2018-10-08 kuroiwa Merge c1170881039e859738c62b02a918116fc6d346bc into 27c86f29417e53a622a2902baab2d1d82dafc5f9
> 2018-10-08 misterg Fixing AllOfMatches test, where it properly belongs
> 2018-10-08 misterg always define define GTEST_LANG_CXX11 1
> 2018-10-08 misterg Remove non-variadic pre C++11 AllOf
> 2018-10-05 gennadiycivil Update primer.md
> 2018-10-05 misterg Remove pre-C++11 code from gtest-printers
> 2018-10-05 absl-team Make GTestColor and ColoredPrintF available as internal APIs from gtest.h.  This is for use in abseil exception safety testing.
> 2018-10-05 misterg Removed pre-C++11 IsContainerTest and IteratorTraits
> 2018-10-04 absl-team Apply clang-tidy modernize-use-nullptr to googletest.
> 2018-10-04 misterg Remove checking for C++ 11 and a pre-C++11 test from googletest tests
> 2018-10-03 theonetruecamper Merge d830440d48a9502161448bc78be33a53388dd1f4 into f5260ae757a681566d8f7d0558b8dc0551036506
> 2018-10-02 jerryturcios08 Remove compilation option for C++11 in the root CMakeLists.txt
> 2018-10-02 mateo.longo Merge c798e39a4f96f5a985126cc3fab4738b6412cfc1 into e93da23920e5b6887d6a6a291c3a59f83f5b579e
> 2018-10-02 jerryturcios08 Add compilation option for C++11 in the root CMakeLists.txt
> 2018-10-02 gennadiycivil Merge 68b8a4c60cd80c78e1875b77807fa13cdd2313f8 into 77962730563eece3525f40b8769e4ca0c6baf64c
> 2018-10-02 30830880+marbub Merge 86fe8a25eb5a6e4546f9e39cf23a5c764217bf85 into 440527a61e1c91188195f7de212c63c77e8f0a45
> 2018-10-01 arseny.aprelev Merge 2ce0685f76a4db403b7b2650433a584c150f2108 into 75e834700d19aa373b428c7c746f951737354c28
> 2018-10-01 misterg Googletest export
> 2018-09-27 durandal Googletest export
> 2018-09-30 jerryturcios08 Add a cached variable to CMAKE_CXX_STANDARD
> 2018-09-28 jerryturcios08 Add C++11 support in the root CMakeLists.txt
> 2018-09-26 gennadiycivil Update appveyor.yml
> 2018-09-25 gennadiycivil Revert "[mingw] enable the unittests for gmock and gtest again"
> 2018-09-25 gennadiycivil Keep one MinGW build, remove the others
> 2018-09-25 gennadiycivil Update appveyor.yml
> 2018-09-25 gennadiycivil Update appveyor.yml
> 2018-09-25 gennadiycivil Delete m4_ax_cxx_compile_stdcxx_11.m4
> 2018-09-25 gennadiycivil Delete m4_ax_cxx_compile_stdcxx.m4
> 2018-09-25 gennadiycivil Update configure.ac
> 2018-09-25 gennadiycivil Update Makefile.am
> 2018-09-25 gennadiycivil Update .travis.yml
> 2018-09-25 misterg automake
> 2018-09-25 misterg test automake c++11
> 2018-09-25 gennadiycivil Update configure.ac
> 2018-09-25 gennadiycivil Update configure.ac
> 2018-09-25 misterg typo
> 2018-09-25 misterg autotools c++11
> 2018-09-25 misterg autotools c++11
> 2018-09-25 misterg test
> 2018-09-25 misterg include c++11 for autotools
> 2018-09-25 absl-team Googletest export
> 2018-09-25 gennadiycivil Revert "Add clang format check to one of the builds"
> 2018-09-25 misterg Googletest export
> 2018-09-24 misterg Googletest export
> 2018-09-20 absl-team Googletest export
> 2018-09-25 misterg enable MingW on PR
> 2018-09-25 misterg C++11 autotools build
> 2018-09-25 misterg adding c++11 to appveyor mingW
> 2018-09-25 misterg typo
> (...)
> 
> Created with:
>   roll-dep src/third_party/googletest/src
> 
> TBR=thakis@chromium.org
> 
> Bug:  893369 
> Change-Id: Ic7e13ff5fd3952c4d71ab23166a5c36dcad86b99
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng
> Reviewed-on: https://chromium-review.googlesource.com/c/1310634
> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604801}

Change-Id: I290509bb9d2e13791ce12f30846aa0703b85f5c0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  893369 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1313882
Cr-Commit-Position: refs/heads/master@{#604810}
[modify] https://crrev.com/1b79ddef34f74fb645c3eec840f0ba0100d2e1cb/DEPS
[modify] https://crrev.com/1b79ddef34f74fb645c3eec840f0ba0100d2e1cb/base/test/gtest_xml_unittest_result_printer.cc
[modify] https://crrev.com/1b79ddef34f74fb645c3eec840f0ba0100d2e1cb/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/1b79ddef34f74fb645c3eec840f0ba0100d2e1cb/media/base/audio_shifter_unittest.cc
[modify] https://crrev.com/1b79ddef34f74fb645c3eec840f0ba0100d2e1cb/third_party/cacheinvalidation/overrides/google/cacheinvalidation/deps/gmock.h
[modify] https://crrev.com/1b79ddef34f74fb645c3eec840f0ba0100d2e1cb/third_party/googletest/BUILD.gn
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faecab5e5087950b65e0b5f36a4803f4001812c2

commit faecab5e5087950b65e0b5f36a4803f4001812c2
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Tue Nov 13 23:08:33 2018

Reland "Roll src/third_party/googletest/src/ 2e68926a9..879ac092f (182 commits)"

This is a reland of be707070f08c45daf3d1bb9e749dc3bdf3636092
The build failure was fixed in perfetto:
https://android-review.googlesource.com/c/platform/external/perfetto/+/822041

Original change's description:
> Roll src/third_party/googletest/src/ 2e68926a9..879ac092f (182 commits)
>
> https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/2e68926a9d49..879ac092fde0
>
> $ git log 2e68926a9..879ac092f --date=short --no-merges --format='%ad %ae %s'
> 2018-10-31 jerryturcios08 Correct grammatical error in README.md
> 2018-10-30 absl-team Googletest export
> 2018-10-30 misterg Googletest export
> 2018-10-29 absl-team Googletest export
> 2018-10-29 akonradi Add Optional() to the cheat sheet doc.
> 2018-10-29 misterg Googletest export
> 2018-10-29 misterg Googletest export
> 2018-10-28 vbrkov Replaced all NULLs with nullptr in googlemock
> 2018-10-28 vbrkov Replaced all NULLs with nullptr in googletest
> 2018-10-26 absl-team Googletest export
> 2018-10-24 absl-team Googletest export
> 2018-10-24 misterg Googletest export
> 2018-10-24 jeffvd.a216 Change CMake googletest download location in docs
> 2018-10-23 durandal Googletest export
> 2018-10-24 peter_jiachen Disable extensions and force standard
> 2018-10-24 peter_jiachen Revert previous changes
> 2018-10-24 peter_jiachen Fix -std=c++11 flag
> 2018-10-23 joelanderson333 add documentation of manual c++11 specification
> 2018-10-23 gennadiycivil Update advanced.md
> 2018-10-23 gennadiycivil Update advanced.md
> 2018-10-23 gennadiycivil Update advanced.md
> 2018-10-23 svg153 ACTION table format
> 2018-10-22 absl-team Googletest export
> 2018-10-19 gennadiycivil Update .travis.yml
> 2018-10-18 gennadiycivil Update .travis.yml
> 2018-10-18 misterg Googletest export
> 2018-10-16 absl-team Googletest export
> 2018-10-17 kakkoko Fix incorrect XML file name in help message
> 2018-10-16 jonathan.wendeborn Removed last reference to internal::kDefault
> 2018-10-16 jonathan.wendeborn Use existing Mock::GetReactionOnUninterestingCalls()
> 2018-10-16 jonathan.wendeborn Don't fully qualify enum member
> 2018-10-16 jonathan.wendeborn Added Mock::IsNaggy, IsNice, and IsStrict
> 2018-10-12 robert Change types to remove cast warnings.
> 2018-10-11 misterg Remove duplicate functionality PrintValue (in googletest-param-test-test.cc), use testing::PrintToString
> 2018-10-11 komh Merge c41b2bf861ef2ac1a975af05ff66d9256f280b01 into f203b2db77161fe54846ea9e839ebec81aeeccac
> 2018-10-11 dneto Merge 4c92120d6dedb4eeb499a8702faea0224e0a8b23 into 658c6390a5b363f46c6ad448ad1bce9d6e97e53a
> 2018-10-11 aarond Merge 41fc9745d4a448db7d932250d22fac1dda287443 into 658c6390a5b363f46c6ad448ad1bce9d6e97e53a
> 2018-10-09 absl-team Project import generated by Copybara.
> 2018-10-09 misterg Internal Change
> 2018-10-11 filipp.andjelo Use pcfiledir for prefix in pkgconfig file
> 2018-10-06 ryee88 fix typo
> 2018-10-10 spartucus Update .gitignore
> 2018-10-09 misterg Remove non-variadic pre C++11 AnyOf
> 2018-10-09 absl-team Unconditionally use std::tuple. Remove all mention of TR1 tuple and our own implementation of tuple.
> 2018-10-09 misterg Remove testing::internal::BothOfMatcher, no longer needed
> 2018-10-09 absl-team Apply [[noreturn]] to Abort()
> 2018-10-09 gennadiycivil Update Makefile.am
> 2018-10-09 gennadiycivil Update BUILD.bazel
> 2018-10-09 gennadiycivil Update README.md
> 2018-10-09 gennadiycivil Delete CHANGES
> 2018-10-09 gennadiycivil Delete CHANGES
> 2018-10-08 kuroiwa Merge c1170881039e859738c62b02a918116fc6d346bc into 27c86f29417e53a622a2902baab2d1d82dafc5f9
> 2018-10-08 misterg Fixing AllOfMatches test, where it properly belongs
> 2018-10-08 misterg always define define GTEST_LANG_CXX11 1
> 2018-10-08 misterg Remove non-variadic pre C++11 AllOf
> 2018-10-05 gennadiycivil Update primer.md
> 2018-10-05 misterg Remove pre-C++11 code from gtest-printers
> 2018-10-05 absl-team Make GTestColor and ColoredPrintF available as internal APIs from gtest.h.  This is for use in abseil exception safety testing.
> 2018-10-05 misterg Removed pre-C++11 IsContainerTest and IteratorTraits
> 2018-10-04 absl-team Apply clang-tidy modernize-use-nullptr to googletest.
> 2018-10-04 misterg Remove checking for C++ 11 and a pre-C++11 test from googletest tests
> 2018-10-03 theonetruecamper Merge d830440d48a9502161448bc78be33a53388dd1f4 into f5260ae757a681566d8f7d0558b8dc0551036506
> 2018-10-02 jerryturcios08 Remove compilation option for C++11 in the root CMakeLists.txt
> 2018-10-02 mateo.longo Merge c798e39a4f96f5a985126cc3fab4738b6412cfc1 into e93da23920e5b6887d6a6a291c3a59f83f5b579e
> 2018-10-02 jerryturcios08 Add compilation option for C++11 in the root CMakeLists.txt
> 2018-10-02 gennadiycivil Merge 68b8a4c60cd80c78e1875b77807fa13cdd2313f8 into 77962730563eece3525f40b8769e4ca0c6baf64c
> 2018-10-02 30830880+marbub Merge 86fe8a25eb5a6e4546f9e39cf23a5c764217bf85 into 440527a61e1c91188195f7de212c63c77e8f0a45
> 2018-10-01 arseny.aprelev Merge 2ce0685f76a4db403b7b2650433a584c150f2108 into 75e834700d19aa373b428c7c746f951737354c28
> 2018-10-01 misterg Googletest export
> 2018-09-27 durandal Googletest export
> 2018-09-30 jerryturcios08 Add a cached variable to CMAKE_CXX_STANDARD
> 2018-09-28 jerryturcios08 Add C++11 support in the root CMakeLists.txt
> 2018-09-26 gennadiycivil Update appveyor.yml
> 2018-09-25 gennadiycivil Revert "[mingw] enable the unittests for gmock and gtest again"
> 2018-09-25 gennadiycivil Keep one MinGW build, remove the others
> 2018-09-25 gennadiycivil Update appveyor.yml
> 2018-09-25 gennadiycivil Update appveyor.yml
> 2018-09-25 gennadiycivil Delete m4_ax_cxx_compile_stdcxx_11.m4
> 2018-09-25 gennadiycivil Delete m4_ax_cxx_compile_stdcxx.m4
> 2018-09-25 gennadiycivil Update configure.ac
> 2018-09-25 gennadiycivil Update Makefile.am
> 2018-09-25 gennadiycivil Update .travis.yml
> 2018-09-25 misterg automake
> 2018-09-25 misterg test automake c++11
> 2018-09-25 gennadiycivil Update configure.ac
> 2018-09-25 gennadiycivil Update configure.ac
> 2018-09-25 misterg typo
> 2018-09-25 misterg autotools c++11
> 2018-09-25 misterg autotools c++11
> 2018-09-25 misterg test
> 2018-09-25 misterg include c++11 for autotools
> 2018-09-25 absl-team Googletest export
> 2018-09-25 gennadiycivil Revert "Add clang format check to one of the builds"
> 2018-09-25 misterg Googletest export
> 2018-09-24 misterg Googletest export
> 2018-09-20 absl-team Googletest export
> 2018-09-25 misterg enable MingW on PR
> 2018-09-25 misterg C++11 autotools build
> 2018-09-25 misterg adding c++11 to appveyor mingW
> 2018-09-25 misterg typo
> (...)
>
> Created with:
>   roll-dep src/third_party/googletest/src
>
> TBR=thakis@chromium.org
>
> Bug:  893369 
> Change-Id: Ic7e13ff5fd3952c4d71ab23166a5c36dcad86b99
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng
> Reviewed-on: https://chromium-review.googlesource.com/c/1310634
> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604801}

TBR=thakis@chromium.org

Bug:  893369 
Change-Id: I227ca83bcd60662367c39f2869606928c922194d
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chromium.try:win_x64_archive
Reviewed-on: https://chromium-review.googlesource.com/c/1320471
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607798}
[modify] https://crrev.com/faecab5e5087950b65e0b5f36a4803f4001812c2/DEPS
[modify] https://crrev.com/faecab5e5087950b65e0b5f36a4803f4001812c2/base/test/gtest_xml_unittest_result_printer.cc
[modify] https://crrev.com/faecab5e5087950b65e0b5f36a4803f4001812c2/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/faecab5e5087950b65e0b5f36a4803f4001812c2/media/base/audio_shifter_unittest.cc
[modify] https://crrev.com/faecab5e5087950b65e0b5f36a4803f4001812c2/third_party/cacheinvalidation/overrides/google/cacheinvalidation/deps/gmock.h
[modify] https://crrev.com/faecab5e5087950b65e0b5f36a4803f4001812c2/third_party/googletest/BUILD.gn
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc1e38cdab9722363298f027f71d0ca075640185

commit fc1e38cdab9722363298f027f71d0ca075640185
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Nov 14 18:03:38 2018

Add ZX dependency in googletest

Add explicit dependency on fuchsia-sdk:zx in googletest. This should
unblock chromium roll to V8, which was broken after crrev.com/607798

TBR=dpranke@chromium.org

Bug:  893369 
Change-Id: I58895fce6d2ed40008cac724735403be8b70226d
Reviewed-on: https://chromium-review.googlesource.com/c/1336070
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608025}
[modify] https://crrev.com/fc1e38cdab9722363298f027f71d0ca075640185/third_party/googletest/BUILD.gn

Comment 16 by fdegans@chromium.org, Nov 16

Status: Fixed (was: Started)
This should now be fixed.
►

Sign in to add a comment