New issue
Advanced search Search tips

Issue 893357 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 9
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Replace pre-built 7z SFX module for installers with source code for same.

Project Member Reported by rogerta@chromium.org, Oct 8

Issue description

Replace pre-built 7z SFX module for installers with source code for same.

This SFX module for installers is built as part of the chromium build
so that the resulting binary can take advantage of mitigations used in most
of chromium's code.  The pre-built module did not pass the checks in
tools/checkbins/checkbins.py whereas the module as built with chromium does.

The SFX module for installers is used to build the google credential provider installer.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e7ed89978868fc464759257b687d39ce0a24daf

commit 8e7ed89978868fc464759257b687d39ce0a24daf
Author: Roger Tawa <rogerta@chromium.org>
Date: Tue Oct 09 13:44:13 2018

Replace pre-built 7z SFX module for installers with source code for same.

This SFX module for installers is built as part of the chromium build
so that the resulting binary can take advantage of mitigations used in most
of chromium's code.  The pre-built module did not pass the checks in
tools/checkbins/checkbins.py whereas the module as built with chromium does.

Bug:  893357 
Change-Id: I27d6f6d0e6cbeb3eb5d68f028dfa1a8e3d00067a
Reviewed-on: https://chromium-review.googlesource.com/c/1267345
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597897}
[add] https://crrev.com/8e7ed89978868fc464759257b687d39ce0a24daf/third_party/lzma_sdk/7zVersion.h
[add] https://crrev.com/8e7ed89978868fc464759257b687d39ce0a24daf/third_party/lzma_sdk/7zVersion.rc
[delete] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/third_party/lzma_sdk/Executable/7zS2.sfx
[modify] https://crrev.com/8e7ed89978868fc464759257b687d39ce0a24daf/third_party/lzma_sdk/README.chromium
[add] https://crrev.com/8e7ed89978868fc464759257b687d39ce0a24daf/third_party/lzma_sdk/Util/SfxSetup/BUILD.gn
[add] https://crrev.com/8e7ed89978868fc464759257b687d39ce0a24daf/third_party/lzma_sdk/Util/SfxSetup/Precomp.h
[add] https://crrev.com/8e7ed89978868fc464759257b687d39ce0a24daf/third_party/lzma_sdk/Util/SfxSetup/SfxSetup.c
[add] https://crrev.com/8e7ed89978868fc464759257b687d39ce0a24daf/third_party/lzma_sdk/Util/SfxSetup/chromium.patch
[add] https://crrev.com/8e7ed89978868fc464759257b687d39ce0a24daf/third_party/lzma_sdk/Util/SfxSetup/resource.rc
[add] https://crrev.com/8e7ed89978868fc464759257b687d39ce0a24daf/third_party/lzma_sdk/Util/SfxSetup/setup.ico

Status: Fixed (was: Started)

Sign in to add a comment