New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 893353 link

Starred by 1 user
Status: Fixed
Owner:
nohle@chromium.org
Closed: Oct 17
Cc:
█ elizabethchiu@chromium.org
jessejames@google.com
█ jlklein@chromium.org
shibasheikh@chromium.org
nohle@chromium.org
khorimoto@chromium.org
█ jordynass@chromium.org
█ jhawkins@chromium.org
hansberry@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

OOBE: Change negative button text to "No, thanks" instead of "Cancel"

Project Member Reported by hansberry@chromium.org, Oct 8 
Other OOBE dialogs offer a "Skip" button if the user does not want the feature being offered. Our dialog offers "Cancel", but this could make the user think they are totally canceling the OOBE signin process. 

Should we be consistent with other dialogs and change this string to "Skip"? Shiba, curious what you think here.

See mocks: https://docs.google.com/presentation/d/1hloC0CmSxtuwHbVLbKSaq1HWpxyYt4EDTTxMuPu0wHc/edit#slide=id.g39ff52efdb_7_12

Comment 1 by khorimoto@chromium.org, Oct 8

Owner: ----
Status: Available (was: Assigned)
Summary: OOBE: Change negative button text to "No Thanks" instead of "Cancel" (was: OOBE setup flow negative button "Cancel" is potentially confusing)
According to the OOBE mocks at [1], the button should read "No Thanks" in OOBE mode.

To accomplish this, we will need to supply different button text values in OOBE vs. non-OOBE mode. We'll need to add a getStartSetupButtonTranslationId() function to MultiDeviceSetupDelegate (see [2]) and will need to override both the OOBE and non-OOBE versions to return the correct value. StartSetupPage would then need to modify its backwardButtonTextId property to use the value provided by the delegate.

[1] https://docs.google.com/presentation/d/1U_ObeMIzR5RzjbOaLXbnpBabL8nBlmMUbpdCFoU6-4E/edit#slide=id.g3b73ef5920_0_628
[2] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_components/chromeos/multidevice_setup/multidevice_setup_delegate.js

Comment 2 by shibasheikh@chromium.org, Oct 8 

Yes, the button should actually be "No, thanks". I'll update my mocks.

Comment 3 by khorimoto@chromium.org, Oct 8

Summary: OOBE: Change negative button text to "No, thanks" instead of "Cancel" (was: OOBE: Change negative button text to "No Thanks" instead of "Cancel")

Comment 4 by nohle@chromium.org, Oct 10

Owner: nohle@chromium.org

Comment 5 by nohle@chromium.org, Oct 10

Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c257639f2961de4ea8c5673514191e7b95ab377

commit 8c257639f2961de4ea8c5673514191e7b95ab377
Author: Josh Nohle <nohle@google.com>
Date: Tue Oct 16 04:57:46 2018

[CrOS MultiDevice] Change "Cancel" to "No thanks" in OOBE

On the start setup page of OOBE, change the text of the cancel button to
read "No thanks" instead of "Cancel".

Screenshots:
OOBE: https://drive.google.com/open?id=1QjHg1_v1QFg1tph986Xi2igPUYG8nJlneA
post-OOBE: https://drive.google.com/open?id=1-hxQjU-WVMi8sAWNAZB-7LyrcX3F5ju5bQ

Bug:  893353 
Change-Id: I748f282b392bccfe17bd14f8bc036cca786bb8f9
Tested: Manual; ./out/Default/browser_tests --gtest_filter=*MultiDevice*
Reviewed-on: https://chromium-review.googlesource.com/c/1272067
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599860}
[modify] https://crrev.com/8c257639f2961de4ea8c5673514191e7b95ab377/chrome/browser/resources/chromeos/login/multidevice_setup_first_run.js
[modify] https://crrev.com/8c257639f2961de4ea8c5673514191e7b95ab377/chrome/browser/resources/chromeos/multidevice_setup/post_oobe_delegate.js
[modify] https://crrev.com/8c257639f2961de4ea8c5673514191e7b95ab377/chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_localized_strings_provider.cc
[modify] https://crrev.com/8c257639f2961de4ea8c5673514191e7b95ab377/chrome/test/data/webui/multidevice_setup/integration_test.js
[modify] https://crrev.com/8c257639f2961de4ea8c5673514191e7b95ab377/ui/webui/resources/cr_components/chromeos/multidevice_setup/multidevice_setup.html
[modify] https://crrev.com/8c257639f2961de4ea8c5673514191e7b95ab377/ui/webui/resources/cr_components/chromeos/multidevice_setup/multidevice_setup_delegate.js
[modify] https://crrev.com/8c257639f2961de4ea8c5673514191e7b95ab377/ui/webui/resources/cr_components/chromeos/multidevice_setup/start_setup_page.js

Comment 7 by jlklein@chromium.org, Oct 16

Labels: Merge-Request-71
Project Member

Comment 8 by sheriffbot@chromium.org, Oct 17

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 17

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13ded7887ab0d35a1c9a6425d73ea47137224387

commit 13ded7887ab0d35a1c9a6425d73ea47137224387
Author: Josh Nohle <nohle@google.com>
Date: Wed Oct 17 15:53:19 2018

[CrOS MultiDevice] Change "Cancel" to "No thanks" in OOBE

On the start setup page of OOBE, change the text of the cancel button to
read "No thanks" instead of "Cancel".

Screenshots:
OOBE: https://drive.google.com/open?id=1QjHg1_v1QFg1tph986Xi2igPUYG8nJlneA
post-OOBE: https://drive.google.com/open?id=1-hxQjU-WVMi8sAWNAZB-7LyrcX3F5ju5bQ

Bug:  893353 
Change-Id: I748f282b392bccfe17bd14f8bc036cca786bb8f9
Tested: Manual; ./out/Default/browser_tests --gtest_filter=*MultiDevice*
Reviewed-on: https://chromium-review.googlesource.com/c/1272067
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599860}(cherry picked from commit 8c257639f2961de4ea8c5673514191e7b95ab377)
Reviewed-on: https://chromium-review.googlesource.com/c/1286873
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#84}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/13ded7887ab0d35a1c9a6425d73ea47137224387/chrome/browser/resources/chromeos/login/multidevice_setup_first_run.js
[modify] https://crrev.com/13ded7887ab0d35a1c9a6425d73ea47137224387/chrome/browser/resources/chromeos/multidevice_setup/post_oobe_delegate.js
[modify] https://crrev.com/13ded7887ab0d35a1c9a6425d73ea47137224387/chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_localized_strings_provider.cc
[modify] https://crrev.com/13ded7887ab0d35a1c9a6425d73ea47137224387/chrome/test/data/webui/multidevice_setup/integration_test.js
[modify] https://crrev.com/13ded7887ab0d35a1c9a6425d73ea47137224387/ui/webui/resources/cr_components/chromeos/multidevice_setup/multidevice_setup.html
[modify] https://crrev.com/13ded7887ab0d35a1c9a6425d73ea47137224387/ui/webui/resources/cr_components/chromeos/multidevice_setup/multidevice_setup_delegate.js
[modify] https://crrev.com/13ded7887ab0d35a1c9a6425d73ea47137224387/ui/webui/resources/cr_components/chromeos/multidevice_setup/start_setup_page.js

Comment 10 by jlklein@chromium.org, Oct 17

Status: Fixed (was: Started)
Project Member

Comment 11 by cr-audit...@appspot.gserviceaccount.com, Oct 23

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/13ded7887ab0d35a1c9a6425d73ea47137224387

Commit: 13ded7887ab0d35a1c9a6425d73ea47137224387
Author: nohle@google.com
Commiter: jlklein@chromium.org
Date: 2018-10-17 15:53:19 +0000 UTC

[CrOS MultiDevice] Change "Cancel" to "No thanks" in OOBE

On the start setup page of OOBE, change the text of the cancel button to
read "No thanks" instead of "Cancel".

Screenshots:
OOBE: https://drive.google.com/open?id=1QjHg1_v1QFg1tph986Xi2igPUYG8nJlneA
post-OOBE: https://drive.google.com/open?id=1-hxQjU-WVMi8sAWNAZB-7LyrcX3F5ju5bQ

Bug:  893353 
Change-Id: I748f282b392bccfe17bd14f8bc036cca786bb8f9
Tested: Manual; ./out/Default/browser_tests --gtest_filter=*MultiDevice*
Reviewed-on: https://chromium-review.googlesource.com/c/1272067
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599860}(cherry picked from commit 8c257639f2961de4ea8c5673514191e7b95ab377)
Reviewed-on: https://chromium-review.googlesource.com/c/1286873
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#84}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
►

Sign in to add a comment