OOBE setup shows "Learn more" links which cannot be opened |
|||||||||
Issue descriptionBecause the user can't open webpages in Chrome during OOBE, the two "Learn more" links on the setup flow dialog don't do anything. Shiba, what is the right thing to do here? Can we simply remove the links?
,
Oct 9
We shouldn't remove the links, the user should still be able to open these links and read more about the feature. We can follow the example set by the ARC++ optin "Google privacy policy" link. It opens a URL and displays it in the flow (screenshots attached). Here's the code they're using to do so: https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js?q=getPrivacyPolicyLink&sq=package:chromium&g=0&l=84
,
Oct 9
Grabbing.
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfebc9e310c9fd4494d0944b3133745224aa01f9 commit cfebc9e310c9fd4494d0944b3133745224aa01f9 Author: Ryan Hansberry <hansberry@chromium.org> Date: Fri Oct 12 03:21:25 2018 [CrOS MultiDevice] Display a modal webview of links in MultiDevice OOBE screen. Links can't be opened like they usually would be in OOBE, because there's no browser to open them in. This CL creates a webview modal which is displayed when the user clicks on one of the two "Learn More" links in the MultiDevice OOBE screen, and loads it with the appropriate URL. Screenshot: https://screenshot.googleplex.com/JL9nfShorRA.png Bug: 893349 Change-Id: I1ac06ea26857adcdf1f3113756e95e15b2f8a127 Reviewed-on: https://chromium-review.googlesource.com/c/1275296 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599084} [modify] https://crrev.com/cfebc9e310c9fd4494d0944b3133745224aa01f9/chrome/browser/resources/chromeos/login/multidevice_setup_first_run.html [modify] https://crrev.com/cfebc9e310c9fd4494d0944b3133745224aa01f9/chrome/browser/resources/chromeos/login/multidevice_setup_first_run.js [modify] https://crrev.com/cfebc9e310c9fd4494d0944b3133745224aa01f9/chrome/browser/resources/chromeos/login/screen_multidevice_setup.html [modify] https://crrev.com/cfebc9e310c9fd4494d0944b3133745224aa01f9/ui/webui/resources/cr_components/chromeos/multidevice_setup/BUILD.gn [modify] https://crrev.com/cfebc9e310c9fd4494d0944b3133745224aa01f9/ui/webui/resources/cr_components/chromeos/multidevice_setup/start_setup_page.html [modify] https://crrev.com/cfebc9e310c9fd4494d0944b3133745224aa01f9/ui/webui/resources/cr_components/chromeos/multidevice_setup/start_setup_page.js
,
Oct 12
,
Oct 12
This just missed M71 branch. Reopening and requesting merge.
,
Oct 13
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fcc8958f09d9cab28483a3885bffea098c710dd commit 0fcc8958f09d9cab28483a3885bffea098c710dd Author: Ryan Hansberry <hansberry@chromium.org> Date: Mon Oct 15 15:35:03 2018 [CrOS MultiDevice] Display a modal webview of links in MultiDevice OOBE screen. Links can't be opened like they usually would be in OOBE, because there's no browser to open them in. This CL creates a webview modal which is displayed when the user clicks on one of the two "Learn More" links in the MultiDevice OOBE screen, and loads it with the appropriate URL. Screenshot: https://screenshot.googleplex.com/JL9nfShorRA.png Bug: 893349 Change-Id: I1ac06ea26857adcdf1f3113756e95e15b2f8a127 Reviewed-on: https://chromium-review.googlesource.com/c/1275296 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599084}(cherry picked from commit cfebc9e310c9fd4494d0944b3133745224aa01f9) Reviewed-on: https://chromium-review.googlesource.com/c/1280846 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#22} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/0fcc8958f09d9cab28483a3885bffea098c710dd/chrome/browser/resources/chromeos/login/multidevice_setup_first_run.html [modify] https://crrev.com/0fcc8958f09d9cab28483a3885bffea098c710dd/chrome/browser/resources/chromeos/login/multidevice_setup_first_run.js [modify] https://crrev.com/0fcc8958f09d9cab28483a3885bffea098c710dd/chrome/browser/resources/chromeos/login/screen_multidevice_setup.html [modify] https://crrev.com/0fcc8958f09d9cab28483a3885bffea098c710dd/ui/webui/resources/cr_components/chromeos/multidevice_setup/BUILD.gn [modify] https://crrev.com/0fcc8958f09d9cab28483a3885bffea098c710dd/ui/webui/resources/cr_components/chromeos/multidevice_setup/start_setup_page.html [modify] https://crrev.com/0fcc8958f09d9cab28483a3885bffea098c710dd/ui/webui/resources/cr_components/chromeos/multidevice_setup/start_setup_page.js
,
Oct 15
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fcc8958f09d9cab28483a3885bffea098c710dd Commit: 0fcc8958f09d9cab28483a3885bffea098c710dd Author: hansberry@chromium.org Commiter: hansberry@chromium.org Date: 2018-10-15 15:35:03 +0000 UTC [CrOS MultiDevice] Display a modal webview of links in MultiDevice OOBE screen. Links can't be opened like they usually would be in OOBE, because there's no browser to open them in. This CL creates a webview modal which is displayed when the user clicks on one of the two "Learn More" links in the MultiDevice OOBE screen, and loads it with the appropriate URL. Screenshot: https://screenshot.googleplex.com/JL9nfShorRA.png Bug: 893349 Change-Id: I1ac06ea26857adcdf1f3113756e95e15b2f8a127 Reviewed-on: https://chromium-review.googlesource.com/c/1275296 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599084}(cherry picked from commit cfebc9e310c9fd4494d0944b3133745224aa01f9) Reviewed-on: https://chromium-review.googlesource.com/c/1280846 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#22} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by hansberry@chromium.org
, Oct 8