NetworkFileShares UI: Default display name should be leaf node of share_url |
||||
Issue descriptionThe default display name should be the file component of the share_url. The user can change still change the display if he/she wants. Additionally, the full url should be added in parenthesis after the display name so that it is visible in the tooltip in File Manager
,
Oct 9
The extension still has "(optional)" even though the field is populated automatically
,
Oct 10
,
Oct 10
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c82a4d82739101769cb6d24c347a11d75123d96 commit 0c82a4d82739101769cb6d24c347a11d75123d96 Author: Bailey Berro <baileyberro@chromium.org> Date: Thu Oct 11 03:27:35 2018 Set share display name to leaf of share path - Set the Display name field to the leaf node of the share url when the share path is in the \\server\share format. - When the share is in smb:// format, the entire path will become the display name Bug: chromium:893342 Change-Id: I2e6a5d0390ab5cbab7fd8eb0d069787baf6da7d9 Reviewed-on: https://chromium-review.googlesource.com/c/1271895 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#598654} [modify] https://crrev.com/0c82a4d82739101769cb6d24c347a11d75123d96/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.html [modify] https://crrev.com/0c82a4d82739101769cb6d24c347a11d75123d96/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.js
,
Oct 11
|
||||
►
Sign in to add a comment |
||||
Comment 1 by baileyberro@chromium.org
, Oct 9