CR_DEFINE_STATIC_LOCAL is obsolete; a function-local static of type base::NoDestructor<T> should be used instead. There are about 100 uses; https://cs.chromium.org/search/?q=CR_DEFINE_STATIC_LOCAL&type=cs .
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04b5b4fdee99fe2c5b3e78dc6eff0f4904a27568 commit 04b5b4fdee99fe2c5b3e78dc6eff0f4904a27568 Author: Avi Drissman <avi@chromium.org> Date: Tue Oct 09 01:18:09 2018 Link removal of CR_DEFINE_STATIC_LOCAL to a bug. BUG= 893317 Change-Id: I05774ba71205167bc4f49cbdca750039ad59a009 Reviewed-on: https://chromium-review.googlesource.com/c/1269556 Reviewed-by: Albert J. Wong <ajwong@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#597764} [modify] https://crrev.com/04b5b4fdee99fe2c5b3e78dc6eff0f4904a27568/base/macros.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20e44be69c93321463020650da18e362f2014124 commit 20e44be69c93321463020650da18e362f2014124 Author: Avi Drissman <avi@chromium.org> Date: Tue Oct 09 19:12:25 2018 Remove CR_DEFINE_STATIC_LOCAL from /ui. BUG= 893317 Change-Id: Ib324d3541b273fb5ab7bcfd77d62e5e9f192d4f6 Reviewed-on: https://chromium-review.googlesource.com/c/1271195 Reviewed-by: Albert J. Wong <ajwong@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#598029} [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/accessibility/ax_node_data.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/accessibility/platform/ax_platform_node_base.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/accessibility/platform/ax_platform_node_delegate_base.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/accessibility/platform/ax_platform_node_mac.mm [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/base/clipboard/clipboard.h [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/base/clipboard/clipboard_android.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/base/clipboard/clipboard_aura.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/base/clipboard/clipboard_aurax11.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/base/clipboard/clipboard_mac.mm [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/base/dragdrop/os_exchange_data_provider_win.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/base/x/x11_util.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/gfx/font_render_params_android.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/gfx/font_render_params_fuchsia.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/gfx/font_render_params_mac.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/gfx/image/image_skia.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/gfx/platform_font_win.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/native_theme/native_theme_android.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/native_theme/native_theme_android.h [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/native_theme/native_theme_aura.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/native_theme/native_theme_aura.h [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/native_theme/native_theme_dark_aura.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/native_theme/native_theme_dark_aura.h [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/native_theme/native_theme_mac.h [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/native_theme/native_theme_mac.mm [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/native_theme/native_theme_win.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/native_theme/native_theme_win.h [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/views/cocoa/tooltip_manager_mac.mm [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/views/controls/menu/menu_config.cc [modify] https://crrev.com/20e44be69c93321463020650da18e362f2014124/ui/views/controls/textfield/textfield_model.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/364efc5385a4c6f6cb48584e2d79887402c4d7e3 commit 364efc5385a4c6f6cb48584e2d79887402c4d7e3 Author: Avi Drissman <avi@chromium.org> Date: Tue Oct 09 23:01:56 2018 Remove CR_DEFINE_STATIC_LOCAL from /chrome/browser. BUG= 893317 Change-Id: Ie8cf1b49483c62323c17e673489583f3939fc9df Reviewed-on: https://chromium-review.googlesource.com/c/1270352 Reviewed-by: Albert J. Wong <ajwong@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#598120} [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/autofill/form_structure_browsertest.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/browsing_data/browsing_data_cookie_helper.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/chrome_browser_main_win.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/chromeos/login/screens/update_screen.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/chromeos/ui/passphrase_textfield.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/engagement/site_engagement_score.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/engagement/site_engagement_score.h [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/first_run/first_run_internal_posix.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/installable/installable_logging.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/media/media_engagement_preloaded_list.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/page_load_metrics/observers/use_counter/ukm_features.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/profiles/profile_manager.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/renderer_preferences_util.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/resource_coordinator/tab_activity_watcher.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/ui/android/tab_model/tab_model_list.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/ui/chrome_pages.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_cocoa.mm [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/ui/libgtkui/native_theme_gtk.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/ui/libgtkui/native_theme_gtk.h [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/ui/page_info/page_info_dialog.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/ui/search/local_ntp_render_browsertest.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/ui/tabs/window_activity_watcher.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/ui/tabs/window_activity_watcher.h [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/ui/views/accelerator_table.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/ui/views/extensions/browser_action_drag_data.cc [modify] https://crrev.com/364efc5385a4c6f6cb48584e2d79887402c4d7e3/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac53c5c532ea0584e86790b49bbe39a770bbbc56 commit ac53c5c532ea0584e86790b49bbe39a770bbbc56 Author: Avi Drissman <avi@chromium.org> Date: Wed Oct 10 15:39:51 2018 Remove CR_DEFINE_STATIC_LOCAL from /components. BUG= 893317 Change-Id: Iea05656a6629ff91d04df6038480d36d44514b8e Reviewed-on: https://chromium-review.googlesource.com/c/1271717 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#598338} [modify] https://crrev.com/ac53c5c532ea0584e86790b49bbe39a770bbbc56/components/autofill/content/renderer/form_autofill_util.cc [modify] https://crrev.com/ac53c5c532ea0584e86790b49bbe39a770bbbc56/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/ac53c5c532ea0584e86790b49bbe39a770bbbc56/components/autofill/content/renderer/password_form_conversion_utils.cc [modify] https://crrev.com/ac53c5c532ea0584e86790b49bbe39a770bbbc56/components/autofill/core/browser/autofill_merge_unittest.cc [modify] https://crrev.com/ac53c5c532ea0584e86790b49bbe39a770bbbc56/components/bookmarks/browser/bookmark_codec_unittest.cc [modify] https://crrev.com/ac53c5c532ea0584e86790b49bbe39a770bbbc56/components/browsing_data/core/browsing_data_utils.cc [modify] https://crrev.com/ac53c5c532ea0584e86790b49bbe39a770bbbc56/components/drive/file_system_core_util.cc [modify] https://crrev.com/ac53c5c532ea0584e86790b49bbe39a770bbbc56/components/exo/data_offer.cc [modify] https://crrev.com/ac53c5c532ea0584e86790b49bbe39a770bbbc56/components/google/core/common/google_util.cc [modify] https://crrev.com/ac53c5c532ea0584e86790b49bbe39a770bbbc56/components/infobars/core/infobar_delegate.cc [modify] https://crrev.com/ac53c5c532ea0584e86790b49bbe39a770bbbc56/components/omnibox/browser/history_quick_provider_performance_unittest.cc [modify] https://crrev.com/ac53c5c532ea0584e86790b49bbe39a770bbbc56/components/omnibox/browser/scored_history_match.cc [modify] https://crrev.com/ac53c5c532ea0584e86790b49bbe39a770bbbc56/components/omnibox/browser/url_prefix.cc [modify] https://crrev.com/ac53c5c532ea0584e86790b49bbe39a770bbbc56/components/sync/model/entity_data.cc [modify] https://crrev.com/ac53c5c532ea0584e86790b49bbe39a770bbbc56/components/url_pattern_index/url_pattern_index.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75c82610d7446629bb8ef69d91fde0b1567e2b72 commit 75c82610d7446629bb8ef69d91fde0b1567e2b72 Author: Avi Drissman <avi@chromium.org> Date: Wed Oct 10 17:25:54 2018 Remove CR_DEFINE_STATIC_LOCAL from /content. BUG= 893317 Change-Id: Ife017f0b38335265dfb5dba1d978d3b4ef2c2297 Reviewed-on: https://chromium-review.googlesource.com/c/1271719 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#598383} [modify] https://crrev.com/75c82610d7446629bb8ef69d91fde0b1567e2b72/content/browser/accessibility/accessibility_tree_formatter_mac.mm [modify] https://crrev.com/75c82610d7446629bb8ef69d91fde0b1567e2b72/content/browser/accessibility/browser_accessibility.cc [modify] https://crrev.com/75c82610d7446629bb8ef69d91fde0b1567e2b72/content/browser/accessibility/browser_accessibility_manager.cc [modify] https://crrev.com/75c82610d7446629bb8ef69d91fde0b1567e2b72/content/browser/font_unique_name_lookup/font_unique_name_lookup_service.cc [modify] https://crrev.com/75c82610d7446629bb8ef69d91fde0b1567e2b72/content/browser/hyphenation/hyphenation_impl.cc [modify] https://crrev.com/75c82610d7446629bb8ef69d91fde0b1567e2b72/content/browser/renderer_interface_binders.cc [modify] https://crrev.com/75c82610d7446629bb8ef69d91fde0b1567e2b72/content/browser/web_contents/web_contents_view_aura.cc [modify] https://crrev.com/75c82610d7446629bb8ef69d91fde0b1567e2b72/content/public/browser/site_isolation_policy.cc [modify] https://crrev.com/75c82610d7446629bb8ef69d91fde0b1567e2b72/content/public/common/content_client.cc [modify] https://crrev.com/75c82610d7446629bb8ef69d91fde0b1567e2b72/content/renderer/manifest/manifest_manager.cc [modify] https://crrev.com/75c82610d7446629bb8ef69d91fde0b1567e2b72/content/renderer/pepper/plugin_module.cc [modify] https://crrev.com/75c82610d7446629bb8ef69d91fde0b1567e2b72/content/shell/test_runner/test_plugin.cc [modify] https://crrev.com/75c82610d7446629bb8ef69d91fde0b1567e2b72/content/test/accessibility_browser_test_utils.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94ea9d34dd782fba1a7909fb10b42f6ddc643451 commit 94ea9d34dd782fba1a7909fb10b42f6ddc643451 Author: Avi Drissman <avi@chromium.org> Date: Fri Oct 12 17:23:59 2018 Remove CR_DEFINE_STATIC_LOCAL. BUG= 893317 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8920fd240a55a32ee5dd27e049cc528193644dcf Reviewed-on: https://chromium-review.googlesource.com/c/1273809 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Wei Li <weili@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#599267} [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/android_webview/browser/aw_contents.cc [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/android_webview/browser/aw_settings.cc [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/ash/public/cpp/app_list/app_list_config.cc [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/base/macros.h [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/base/memory/shared_memory_posix.cc [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/base/no_destructor.h [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/base/test/test_suite.cc [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/chrome/common/extensions/manifest_handlers/app_icon_color_info.cc [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/chrome/common/net/net_resource_provider.cc [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/chrome/common/profiling.cc [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/chrome/renderer/chrome_content_renderer_client.cc [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/chrome/renderer/net_benchmarking_extension.cc [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/device/vr/openvr/openvr_render_loop.cc [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/extensions/browser/api/web_request/web_request_api.cc [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/extensions/browser/api/web_request/web_request_api.h [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/extensions/common/extension_l10n_util.cc [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/extensions/common/file_util.cc [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/headless/lib/browser/headless_browser_impl_mac.mm [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/ios/chrome/browser/autofill/form_structure_browsertest.mm [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/printing/backend/print_backend_cups.cc [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/services/service_manager/service_manager.cc [modify] https://crrev.com/94ea9d34dd782fba1a7909fb10b42f6ddc643451/third_party/blink/common/feature_policy/feature_policy.cc
Comment 1 by bugdroid1@chromium.org
, Oct 9