New issue
Advanced search Search tips

Issue 893312 link

Starred by 1 user
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Oct 11
Cc:
omrilio@chromium.org
mccanny@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

With homecher, tapping overview where a homecher icon is opens that app.

Project Member Reported by sammiequon@chromium.org, Oct 8 
What steps will reproduce the problem?
(1) Press launcher button so that homecher is available.
(2) Hover finger over an app.
(3) Enter overview.
(4) Tap down on where the app was.

What is the expected result?
Exit overview. Restore MRU window if there is one.

What happens instead?
The homecher app is opened.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a41cd639af864334337d349edaf9624cdc9d6868

commit a41cd639af864334337d349edaf9624cdc9d6868
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Oct 10 21:10:37 2018

applist: Do not process events on app list while in overview.

This prevents users from being able to open app list apps while in
overview by clicking the location of the icon.

Test: manual
Bug:  893312 
Change-Id: I73221a820caae1f7fe120d1d432728f37343576a
Reviewed-on: https://chromium-review.googlesource.com/c/1274451
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598506}
[modify] https://crrev.com/a41cd639af864334337d349edaf9624cdc9d6868/ash/app_list/app_list_controller_impl.cc
[modify] https://crrev.com/a41cd639af864334337d349edaf9624cdc9d6868/ash/app_list/app_list_controller_impl.h
[modify] https://crrev.com/a41cd639af864334337d349edaf9624cdc9d6868/ash/app_list/app_list_view_delegate.h
[modify] https://crrev.com/a41cd639af864334337d349edaf9624cdc9d6868/ash/app_list/test/app_list_test_view_delegate.cc
[modify] https://crrev.com/a41cd639af864334337d349edaf9624cdc9d6868/ash/app_list/test/app_list_test_view_delegate.h
[modify] https://crrev.com/a41cd639af864334337d349edaf9624cdc9d6868/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/a41cd639af864334337d349edaf9624cdc9d6868/ash/shell/app_list.cc
[modify] https://crrev.com/a41cd639af864334337d349edaf9624cdc9d6868/ash/wm/overview/window_selector_controller.cc
[modify] https://crrev.com/a41cd639af864334337d349edaf9624cdc9d6868/ash/wm/overview/window_selector_controller.h

Comment 2 by sammiequon@chromium.org, Oct 11

Status: Fixed (was: Assigned)
►

Sign in to add a comment