[Harmony Cast Dialog] Hover on stop button to change sink status text to "Stop casting" |
||||||
Issue descriptionWhenever the user hovers/focuses on the stop button for a sink while casting, the status text for the sink should say "Stop casting".
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/045de9e53df333233016b5fb17bf5a04ed36556d commit 045de9e53df333233016b5fb17bf5a04ed36556d Author: John Williams <jrw@google.com> Date: Wed Oct 17 21:33:53 2018 Set status to "Stop casting" when user overs on stop icon. Bug: 893311 Change-Id: I5479bf30aad7801234144b475ebed6f975760afc Reviewed-on: https://chromium-review.googlesource.com/c/1281878 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#600565} [modify] https://crrev.com/045de9e53df333233016b5fb17bf5a04ed36556d/chrome/app/media_router_strings.grdp [modify] https://crrev.com/045de9e53df333233016b5fb17bf5a04ed36556d/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc [modify] https://crrev.com/045de9e53df333233016b5fb17bf5a04ed36556d/chrome/browser/ui/views/media_router/cast_dialog_sink_button.h [modify] https://crrev.com/045de9e53df333233016b5fb17bf5a04ed36556d/chrome/browser/ui/views/media_router/cast_dialog_sink_button_unittest.cc
,
Oct 18
This change includes a localized string, BTW. Does that affect whether we can merge it into M71?
,
Oct 18
This bug requires manual review: There is .grd file changes and we are only 46 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 19
Pls apply applicable OSs label. Thank you.
,
Oct 19
,
Oct 19
This is P3 , Type: Feature and require localization of string for M71 so rejecting merge to M71. Pls let me know if there is any concern here. Thank you.
,
Oct 29
I believe no further work is necessary here. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jrw@chromium.org
, Oct 15