New issue
Advanced search Search tips

Issue 893301 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

[Harmony Cast Dialog] Remove focus outline from stop button

Project Member Reported by taku...@chromium.org, Oct 8

Issue description

As shown in [1], focus outlines (blue solid and black dotted lines in the screenshot) can get stuck on the stop button. Since focus state is already indicated by an inkdrop, these outlines should never be shown.

[1] https://screenshot.googleplex.com/uX5ozpq09qj
 
Owner: taku...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94c0b8d58b6f5f1d2a86e1760468011119515bc6

commit 94c0b8d58b6f5f1d2a86e1760468011119515bc6
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Tue Oct 09 23:46:27 2018

[Harmony Cast Dialog] Remove focus outlines from the stop button

Remove unnecessary focus outlines from the stop button shown for active
Cast devices. When the button is in focus, an inkdrop shadow is shown
instead.

Bug:  893301 
Change-Id: Id9d4d4a038d37d63c645ba99cf2b5e0b8f7470ca
Reviewed-on: https://chromium-review.googlesource.com/c/1271589
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598135}
[modify] https://crrev.com/94c0b8d58b6f5f1d2a86e1760468011119515bc6/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc

 Issue 894097  has been merged into this issue.
Status: Fixed (was: Assigned)

Sign in to add a comment