Add support for controlling media sessions through the service
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1ff7f8ad29f5c66e76092726cbb7be1a5468cd4 commit e1ff7f8ad29f5c66e76092726cbb7be1a5468cd4 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Oct 09 16:05:10 2018 [Audio Focus] Add MockMediaSession Move MockMediaSession out of AudioFocusManagerTest so we can use it in other tests. BUG=893296 Change-Id: Iea6b8930f2c9e3dafc694697c73342d1de463d0e Reviewed-on: https://chromium-review.googlesource.com/c/1269187 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597932} [modify] https://crrev.com/e1ff7f8ad29f5c66e76092726cbb7be1a5468cd4/services/media_session/BUILD.gn [modify] https://crrev.com/e1ff7f8ad29f5c66e76092726cbb7be1a5468cd4/services/media_session/audio_focus_manager.h [modify] https://crrev.com/e1ff7f8ad29f5c66e76092726cbb7be1a5468cd4/services/media_session/audio_focus_manager_unittest.cc [add] https://crrev.com/e1ff7f8ad29f5c66e76092726cbb7be1a5468cd4/services/media_session/mock_media_session.cc [add] https://crrev.com/e1ff7f8ad29f5c66e76092726cbb7be1a5468cd4/services/media_session/mock_media_session.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24e8a9ccfd7c94b9d059ee663ce5f955e8b2d6f3 commit 24e8a9ccfd7c94b9d059ee663ce5f955e8b2d6f3 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Oct 18 16:54:34 2018 [Media Session] Add a MediaController Add a MediaController that can be used to proxy commands to a MediaSession. Also adds a MediaControllerFactory for creating them over mojo. BUG=893296 Change-Id: I82a7cb5798094486a28517dc5a18112ec8d14871 Reviewed-on: https://chromium-review.googlesource.com/c/1269623 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#600799} [modify] https://crrev.com/24e8a9ccfd7c94b9d059ee663ce5f955e8b2d6f3/services/media_session/BUILD.gn [modify] https://crrev.com/24e8a9ccfd7c94b9d059ee663ce5f955e8b2d6f3/services/media_session/audio_focus_manager.cc [modify] https://crrev.com/24e8a9ccfd7c94b9d059ee663ce5f955e8b2d6f3/services/media_session/audio_focus_manager.h [modify] https://crrev.com/24e8a9ccfd7c94b9d059ee663ce5f955e8b2d6f3/services/media_session/manifest.json [add] https://crrev.com/24e8a9ccfd7c94b9d059ee663ce5f955e8b2d6f3/services/media_session/media_controller.cc [add] https://crrev.com/24e8a9ccfd7c94b9d059ee663ce5f955e8b2d6f3/services/media_session/media_controller.h [add] https://crrev.com/24e8a9ccfd7c94b9d059ee663ce5f955e8b2d6f3/services/media_session/media_controller_unittest.cc [modify] https://crrev.com/24e8a9ccfd7c94b9d059ee663ce5f955e8b2d6f3/services/media_session/media_session_service.cc [modify] https://crrev.com/24e8a9ccfd7c94b9d059ee663ce5f955e8b2d6f3/services/media_session/mock_media_session.cc [modify] https://crrev.com/24e8a9ccfd7c94b9d059ee663ce5f955e8b2d6f3/services/media_session/mock_media_session.h [modify] https://crrev.com/24e8a9ccfd7c94b9d059ee663ce5f955e8b2d6f3/services/media_session/public/mojom/BUILD.gn [add] https://crrev.com/24e8a9ccfd7c94b9d059ee663ce5f955e8b2d6f3/services/media_session/public/mojom/media_controller.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/834490b77593bf1f39e20b78afebc52702e96b98 commit 834490b77593bf1f39e20b78afebc52702e96b98 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Oct 18 17:01:18 2018 [Media Controller] Add resume and toggle suspend resume Adds resume to the Media Controller mojo interface. Also adds a ToggleSuspendResume method to make it easier to toggle play/pause. BUG=893296 Change-Id: Ib9615d3c93909ca24e0eec0b4d6e690c186703dc Reviewed-on: https://chromium-review.googlesource.com/c/1272081 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#600802} [modify] https://crrev.com/834490b77593bf1f39e20b78afebc52702e96b98/services/media_session/audio_focus_manager.cc [modify] https://crrev.com/834490b77593bf1f39e20b78afebc52702e96b98/services/media_session/media_controller.cc [modify] https://crrev.com/834490b77593bf1f39e20b78afebc52702e96b98/services/media_session/media_controller.h [modify] https://crrev.com/834490b77593bf1f39e20b78afebc52702e96b98/services/media_session/media_controller_unittest.cc [modify] https://crrev.com/834490b77593bf1f39e20b78afebc52702e96b98/services/media_session/mock_media_session.cc [modify] https://crrev.com/834490b77593bf1f39e20b78afebc52702e96b98/services/media_session/mock_media_session.h [modify] https://crrev.com/834490b77593bf1f39e20b78afebc52702e96b98/services/media_session/public/mojom/media_controller.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ee18d310d3f388750eb3e4b74fcfcebe1b74a2e commit 8ee18d310d3f388750eb3e4b74fcfcebe1b74a2e Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Oct 25 00:13:11 2018 [Media Controller] Add playback state Add playback state to MediaSessionInfo. This reflects the actual playback state of the media. This is used because the audio focus state may not line up with whether there is media playing (e.g. apps commonly hold audio focus when they are paused). BUG=893296 Change-Id: I025856fe007c08e61e85cb1417b472aecd5a3ccb Reviewed-on: https://chromium-review.googlesource.com/c/1282026 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#602534} [modify] https://crrev.com/8ee18d310d3f388750eb3e4b74fcfcebe1b74a2e/services/media_session/audio_focus_manager.cc [modify] https://crrev.com/8ee18d310d3f388750eb3e4b74fcfcebe1b74a2e/services/media_session/media_controller.cc [modify] https://crrev.com/8ee18d310d3f388750eb3e4b74fcfcebe1b74a2e/services/media_session/media_controller.h [modify] https://crrev.com/8ee18d310d3f388750eb3e4b74fcfcebe1b74a2e/services/media_session/media_controller_unittest.cc [modify] https://crrev.com/8ee18d310d3f388750eb3e4b74fcfcebe1b74a2e/services/media_session/mock_media_session.cc [modify] https://crrev.com/8ee18d310d3f388750eb3e4b74fcfcebe1b74a2e/services/media_session/mock_media_session.h [modify] https://crrev.com/8ee18d310d3f388750eb3e4b74fcfcebe1b74a2e/services/media_session/public/mojom/media_session.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1112acc308329abfa44207feb5656dac74f7d407 commit 1112acc308329abfa44207feb5656dac74f7d407 Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Oct 29 17:01:36 2018 Media Controller: Add support for previous and next track Add support for Previous/NextTrack to MediaController and the underlying MediaSession. This will be mapped to the previous and next track media keys on CrOS. BUG=893296 Change-Id: I582cd70a04c24af69c80ca891a281311b4d05434 Reviewed-on: https://chromium-review.googlesource.com/c/1287268 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#603528} [modify] https://crrev.com/1112acc308329abfa44207feb5656dac74f7d407/chromecast/browser/cast_media_blocker_unittest.cc [modify] https://crrev.com/1112acc308329abfa44207feb5656dac74f7d407/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/1112acc308329abfa44207feb5656dac74f7d407/content/browser/media/session/media_session_impl.h [modify] https://crrev.com/1112acc308329abfa44207feb5656dac74f7d407/content/browser/media/session/media_session_impl_service_routing_unittest.cc [modify] https://crrev.com/1112acc308329abfa44207feb5656dac74f7d407/content/public/browser/media_session.h [modify] https://crrev.com/1112acc308329abfa44207feb5656dac74f7d407/services/media_session/media_controller.cc [modify] https://crrev.com/1112acc308329abfa44207feb5656dac74f7d407/services/media_session/media_controller.h [modify] https://crrev.com/1112acc308329abfa44207feb5656dac74f7d407/services/media_session/media_controller_unittest.cc [modify] https://crrev.com/1112acc308329abfa44207feb5656dac74f7d407/services/media_session/mock_media_session.cc [modify] https://crrev.com/1112acc308329abfa44207feb5656dac74f7d407/services/media_session/mock_media_session.h [modify] https://crrev.com/1112acc308329abfa44207feb5656dac74f7d407/services/media_session/public/cpp/test/test_media_controller.h [modify] https://crrev.com/1112acc308329abfa44207feb5656dac74f7d407/services/media_session/public/mojom/media_controller.mojom [modify] https://crrev.com/1112acc308329abfa44207feb5656dac74f7d407/services/media_session/public/mojom/media_session.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89b1e46522e3672ccbd042e5c7f34f3d339bf943 commit 89b1e46522e3672ccbd042e5c7f34f3d339bf943 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Oct 30 17:51:24 2018 [Media Controller] Ignore transient sessions The active media controller follows the last played media session. This changes the logic to ignore temporary media sessions by only following kGain sessions. BUG=893296 Change-Id: I6f7fbdbc52d9c6120888501060dce94befaaacbe Reviewed-on: https://chromium-review.googlesource.com/c/1306784 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#603952} [modify] https://crrev.com/89b1e46522e3672ccbd042e5c7f34f3d339bf943/services/media_session/audio_focus_manager.cc [modify] https://crrev.com/89b1e46522e3672ccbd042e5c7f34f3d339bf943/services/media_session/audio_focus_manager.h [modify] https://crrev.com/89b1e46522e3672ccbd042e5c7f34f3d339bf943/services/media_session/media_controller.cc [modify] https://crrev.com/89b1e46522e3672ccbd042e5c7f34f3d339bf943/services/media_session/media_controller.h [modify] https://crrev.com/89b1e46522e3672ccbd042e5c7f34f3d339bf943/services/media_session/media_controller_unittest.cc [modify] https://crrev.com/89b1e46522e3672ccbd042e5c7f34f3d339bf943/services/media_session/mock_media_session.cc [modify] https://crrev.com/89b1e46522e3672ccbd042e5c7f34f3d339bf943/services/media_session/mock_media_session.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77ef5807ec14455621d474453d39d090b1b8e8a0 commit 77ef5807ec14455621d474453d39d090b1b8e8a0 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Nov 08 02:21:04 2018 [Media Notification] Add previous and next track Add previous and next track buttons to the media notification. BUG=893296 Change-Id: I2918e82bfa3ef11ce65e0fd8d21783e683cd3203 Reviewed-on: https://chromium-review.googlesource.com/c/1300114 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#606289} [modify] https://crrev.com/77ef5807ec14455621d474453d39d090b1b8e8a0/ash/media/media_notification_controller.cc [modify] https://crrev.com/77ef5807ec14455621d474453d39d090b1b8e8a0/ash/media/media_notification_view.cc [modify] https://crrev.com/77ef5807ec14455621d474453d39d090b1b8e8a0/ash/media/media_notification_view.h [modify] https://crrev.com/77ef5807ec14455621d474453d39d090b1b8e8a0/ash/media/media_notification_view_unittest.cc [modify] https://crrev.com/77ef5807ec14455621d474453d39d090b1b8e8a0/components/vector_icons/BUILD.gn [add] https://crrev.com/77ef5807ec14455621d474453d39d090b1b8e8a0/components/vector_icons/media_next_track.icon [add] https://crrev.com/77ef5807ec14455621d474453d39d090b1b8e8a0/components/vector_icons/media_previous_track.icon [modify] https://crrev.com/77ef5807ec14455621d474453d39d090b1b8e8a0/ui/views/controls/button/image_button_factory.cc [modify] https://crrev.com/77ef5807ec14455621d474453d39d090b1b8e8a0/ui/views/controls/button/image_button_factory.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5047f588f53bb793f497396bc633e4756f545a85 commit 5047f588f53bb793f497396bc633e4756f545a85 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Nov 08 19:16:14 2018 [Media Notification] Add observer to toggle button Make MediaNotificationController a MediaSessionObserver so it will get updates about playback state which we can use to toggle the play pause button. BUG=893296 Change-Id: If23dee44a1d37283a4a3e6249f3ce67553fe1593 Reviewed-on: https://chromium-review.googlesource.com/c/1311255 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#606562} [modify] https://crrev.com/5047f588f53bb793f497396bc633e4756f545a85/ash/media/media_notification_controller.cc [modify] https://crrev.com/5047f588f53bb793f497396bc633e4756f545a85/ash/media/media_notification_controller.h [modify] https://crrev.com/5047f588f53bb793f497396bc633e4756f545a85/ash/media/media_notification_view.cc [modify] https://crrev.com/5047f588f53bb793f497396bc633e4756f545a85/ash/media/media_notification_view.h [modify] https://crrev.com/5047f588f53bb793f497396bc633e4756f545a85/ash/media/media_notification_view_unittest.cc [modify] https://crrev.com/5047f588f53bb793f497396bc633e4756f545a85/services/media_session/public/cpp/test/test_media_controller.cc [modify] https://crrev.com/5047f588f53bb793f497396bc633e4756f545a85/services/media_session/public/cpp/test/test_media_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f241ab29aef906ccd3f485310f42ada26e4482a5 commit f241ab29aef906ccd3f485310f42ada26e4482a5 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Nov 09 22:16:55 2018 [Media Session] Support playback state in MSI Support playback state in MediaSessionImpl. This is analogous to the previous IsActuallyPaused boolean. Also exposes MockMediaSession as we have duplicate test helpers in content and services that can be shared. BUG=893296 Change-Id: I8d7120a64b2eb9792eb7ba11e1ef13849eb81b93 Reviewed-on: https://chromium-review.googlesource.com/c/1281905 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#606994} [modify] https://crrev.com/f241ab29aef906ccd3f485310f42ada26e4482a5/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/f241ab29aef906ccd3f485310f42ada26e4482a5/content/browser/media/session/media_session_impl.h [modify] https://crrev.com/f241ab29aef906ccd3f485310f42ada26e4482a5/content/browser/media/session/media_session_impl_unittest.cc [modify] https://crrev.com/f241ab29aef906ccd3f485310f42ada26e4482a5/content/test/BUILD.gn [modify] https://crrev.com/f241ab29aef906ccd3f485310f42ada26e4482a5/services/media_session/BUILD.gn [modify] https://crrev.com/f241ab29aef906ccd3f485310f42ada26e4482a5/services/media_session/audio_focus_manager_unittest.cc [modify] https://crrev.com/f241ab29aef906ccd3f485310f42ada26e4482a5/services/media_session/media_controller_unittest.cc [modify] https://crrev.com/f241ab29aef906ccd3f485310f42ada26e4482a5/services/media_session/public/cpp/test/BUILD.gn [rename] https://crrev.com/f241ab29aef906ccd3f485310f42ada26e4482a5/services/media_session/public/cpp/test/mock_media_session.cc [rename] https://crrev.com/f241ab29aef906ccd3f485310f42ada26e4482a5/services/media_session/public/cpp/test/mock_media_session.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/120053248ff30a441bb2f2f3a41da1d6f43b8bd7 commit 120053248ff30a441bb2f2f3a41da1d6f43b8bd7 Author: Becca Hughes <beccahughes@chromium.org> Date: Wed Nov 21 19:38:03 2018 Media Controller: Add support for seeking Add support for seeking to MediaController and the underlying media session. Consolidates the SeekForward/SeekBackward methods into a single Seek method. BUG=893296 Change-Id: I6e76406e2ec3d8afe3a31ae8acfdaf1dcbf667d7 Reviewed-on: https://chromium-review.googlesource.com/c/1306297 Reviewed-by: Sergey Volk <servolk@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#610169} [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/chromecast/browser/cast_media_blocker_unittest.cc [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/content/browser/media/session/media_session_android.cc [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/content/browser/media/session/media_session_android.h [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/content/browser/media/session/media_session_impl.h [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/content/browser/media/session/media_session_impl_browsertest.cc [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/content/browser/media/session/media_session_impl_service_routing_unittest.cc [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/content/public/android/java/src/org/chromium/content/browser/MediaSessionImpl.java [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/content/public/android/java/src/org/chromium/content_public/browser/MediaSession.java [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/content/public/browser/media_session.h [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/services/media_session/media_controller.cc [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/services/media_session/media_controller.h [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/services/media_session/media_controller_unittest.cc [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/services/media_session/public/cpp/test/mock_media_session.cc [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/services/media_session/public/cpp/test/mock_media_session.h [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/services/media_session/public/cpp/test/test_media_controller.h [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/services/media_session/public/mojom/constants.mojom [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/services/media_session/public/mojom/media_controller.mojom [modify] https://crrev.com/120053248ff30a441bb2f2f3a41da1d6f43b8bd7/services/media_session/public/mojom/media_session.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec4f1cdce37dc5e7974f1c683b71ef3f6f7278c0 commit ec4f1cdce37dc5e7974f1c683b71ef3f6f7278c0 Author: Becca Hughes <beccahughes@chromium.org> Date: Wed Nov 21 22:08:01 2018 [Media Notification] Add seek buttons Add seek backwards and forwards buttons to the media notification. BUG=893296 Change-Id: If4a0263295e0b824a78f214e63a9747ba89db4c9 Reviewed-on: https://chromium-review.googlesource.com/c/1306734 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#610233} [modify] https://crrev.com/ec4f1cdce37dc5e7974f1c683b71ef3f6f7278c0/ash/media/media_notification_controller.cc [modify] https://crrev.com/ec4f1cdce37dc5e7974f1c683b71ef3f6f7278c0/ash/media/media_notification_view.cc [modify] https://crrev.com/ec4f1cdce37dc5e7974f1c683b71ef3f6f7278c0/ash/media/media_notification_view_unittest.cc [modify] https://crrev.com/ec4f1cdce37dc5e7974f1c683b71ef3f6f7278c0/components/vector_icons/BUILD.gn [add] https://crrev.com/ec4f1cdce37dc5e7974f1c683b71ef3f6f7278c0/components/vector_icons/media_seek_backward.icon [add] https://crrev.com/ec4f1cdce37dc5e7974f1c683b71ef3f6f7278c0/components/vector_icons/media_seek_forward.icon [modify] https://crrev.com/ec4f1cdce37dc5e7974f1c683b71ef3f6f7278c0/services/media_session/public/cpp/test/test_media_controller.cc [modify] https://crrev.com/ec4f1cdce37dc5e7974f1c683b71ef3f6f7278c0/services/media_session/public/cpp/test/test_media_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/623fa3253e5323f284c4f75e559213b52e0381af commit 623fa3253e5323f284c4f75e559213b52e0381af Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Nov 27 20:02:19 2018 [Media Notification] Move actions to enum Move the action buttons to using the MediaSessionAction enum now that it is available. BUG=893296 Change-Id: I174d7f9aadc0b1cf89b0b1a2f01d8e2a5269aead Reviewed-on: https://chromium-review.googlesource.com/c/1320653 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#611274} [modify] https://crrev.com/623fa3253e5323f284c4f75e559213b52e0381af/ash/media/media_notification_controller.cc [modify] https://crrev.com/623fa3253e5323f284c4f75e559213b52e0381af/ash/media/media_notification_view.cc [modify] https://crrev.com/623fa3253e5323f284c4f75e559213b52e0381af/ash/media/media_notification_view.h [modify] https://crrev.com/623fa3253e5323f284c4f75e559213b52e0381af/ash/media/media_notification_view_unittest.cc [modify] https://crrev.com/623fa3253e5323f284c4f75e559213b52e0381af/services/media_session/public/cpp/test/test_media_controller.cc [modify] https://crrev.com/623fa3253e5323f284c4f75e559213b52e0381af/services/media_session/public/cpp/test/test_media_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f875a248b4ed12cbfb0da9ec2872f3db1f87960 commit 9f875a248b4ed12cbfb0da9ec2872f3db1f87960 Author: Becca Hughes <beccahughes@chromium.org> Date: Wed Nov 28 23:38:32 2018 [Media Controller] Add documentation Add docs for using MediaController. BUG=893296 Change-Id: I5e836749d94b0274d7bc10ee31c03469d1d01cb4 Reviewed-on: https://chromium-review.googlesource.com/c/1354481 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#611938} [modify] https://crrev.com/9f875a248b4ed12cbfb0da9ec2872f3db1f87960/services/media_session/README.md [add] https://crrev.com/9f875a248b4ed12cbfb0da9ec2872f3db1f87960/services/media_session/controlling_media_playback.md
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c51962727b9b163dd1887cc213b14bc08d475c24 commit c51962727b9b163dd1887cc213b14bc08d475c24 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Nov 30 21:38:10 2018 [Media Notification] Add metadata to notification Add labels for artist and title that are shown if we have the metadata from the session. BUG=893296 Change-Id: I9bab7dd6c31c711c3552dbac975477808ec9311a Reviewed-on: https://chromium-review.googlesource.com/c/1321258 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#612794} [modify] https://crrev.com/c51962727b9b163dd1887cc213b14bc08d475c24/ash/media/media_notification_controller.cc [modify] https://crrev.com/c51962727b9b163dd1887cc213b14bc08d475c24/ash/media/media_notification_controller.h [modify] https://crrev.com/c51962727b9b163dd1887cc213b14bc08d475c24/ash/media/media_notification_view.cc [modify] https://crrev.com/c51962727b9b163dd1887cc213b14bc08d475c24/ash/media/media_notification_view.h [modify] https://crrev.com/c51962727b9b163dd1887cc213b14bc08d475c24/ash/media/media_notification_view_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d409c5cab5bbc969337fae1d75b1435cfe9ddbc9 commit d409c5cab5bbc969337fae1d75b1435cfe9ddbc9 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Nov 30 22:34:04 2018 [Media Notification] Add collapsed mode Add a collapsed mode where the notification will show fewer action buttons and also place the buttons to the right of the title/artist information. BUG=893296 Change-Id: I5a05f074ddda0d000a26db76b26ccc97fd732cd7 Reviewed-on: https://chromium-review.googlesource.com/c/1327613 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#612823} [modify] https://crrev.com/d409c5cab5bbc969337fae1d75b1435cfe9ddbc9/ash/media/media_notification_view.cc [modify] https://crrev.com/d409c5cab5bbc969337fae1d75b1435cfe9ddbc9/ash/media/media_notification_view.h [modify] https://crrev.com/d409c5cab5bbc969337fae1d75b1435cfe9ddbc9/ash/media/media_notification_view_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b485a9cce7a08fad618603f6759cc3167b540b8f commit b485a9cce7a08fad618603f6759cc3167b540b8f Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Jan 18 02:05:03 2019 [Media Session] Add source title Add source_title which should be the host name of the website. This will be displayed as the title of the media notification. BUG=893296 Change-Id: Id6dd7e2c0b46bcf30d601c3e90a6c14f2dc4be70 Reviewed-on: https://chromium-review.googlesource.com/c/1334661 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#623956} [modify] https://crrev.com/b485a9cce7a08fad618603f6759cc3167b540b8f/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/b485a9cce7a08fad618603f6759cc3167b540b8f/content/browser/media/session/media_session_impl.h [modify] https://crrev.com/b485a9cce7a08fad618603f6759cc3167b540b8f/content/browser/media/session/media_session_impl_browsertest.cc [modify] https://crrev.com/b485a9cce7a08fad618603f6759cc3167b540b8f/content/browser/media/session/media_session_impl_service_routing_unittest.cc [modify] https://crrev.com/b485a9cce7a08fad618603f6759cc3167b540b8f/services/media_session/public/cpp/media_metadata.cc [modify] https://crrev.com/b485a9cce7a08fad618603f6759cc3167b540b8f/services/media_session/public/cpp/media_metadata.h [modify] https://crrev.com/b485a9cce7a08fad618603f6759cc3167b540b8f/services/media_session/public/cpp/media_session_mojom_traits.cc [modify] https://crrev.com/b485a9cce7a08fad618603f6759cc3167b540b8f/services/media_session/public/cpp/media_session_mojom_traits.h [modify] https://crrev.com/b485a9cce7a08fad618603f6759cc3167b540b8f/services/media_session/public/cpp/test/mock_media_session.cc [modify] https://crrev.com/b485a9cce7a08fad618603f6759cc3167b540b8f/services/media_session/public/mojom/media_session.mojom [modify] https://crrev.com/b485a9cce7a08fad618603f6759cc3167b540b8f/third_party/blink/renderer/modules/mediasession/media_metadata_sanitizer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a281cad0bb2e451e441067ade93a753693caee0 commit 5a281cad0bb2e451e441067ade93a753693caee0 Author: Becca Hughes <beccahughes@chromium.org> Date: Sat Jan 19 00:55:58 2019 [Media Notification] Use source title as the app name Use the source title as the app name for the media notification. BUG=893296 Change-Id: Ida8cb2ac5c140c6c5cdee0804294f7cd9f6fc254 Reviewed-on: https://chromium-review.googlesource.com/c/1335663 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#624387} [modify] https://crrev.com/5a281cad0bb2e451e441067ade93a753693caee0/ash/media/media_notification_view.cc [modify] https://crrev.com/5a281cad0bb2e451e441067ade93a753693caee0/ash/media/media_notification_view_unittest.cc [modify] https://crrev.com/5a281cad0bb2e451e441067ade93a753693caee0/ui/message_center/views/notification_header_view.cc [modify] https://crrev.com/5a281cad0bb2e451e441067ade93a753693caee0/ui/message_center/views/notification_header_view.h
Comment 1 by bugdroid1@chromium.org
, Oct 9