Issue metadata
Sign in to add a comment
|
PageInfoBubble dialog doesn't respect the display's workarea |
||||||||||||||||||||||||
Issue descriptionWhen the docked magnifier is enabled, it resizes the display's workarea to be about two thirds of the display's bounds. The PageInfoBubble dialog however does not respect this workarea, does not size itself properly, and as a result may be shown as chopped. See attached screenshot.
,
Oct 8
Tangentially I also assume we might run into similar problems if we do a vertical split and our minimum toolbar width doesn't fit. I'm not sure if we support vertical split for zooming or how tight that could get.
,
Oct 8
I found this while I was working on a fix for extension dialogs (See issue 868625 ). Here's my CL that fixes this: https://chromium-review.googlesource.com/c/chromium/src/+/1262646
,
Oct 9
Bubbles can only "flip" if they don't fit in the work area. This bubble does do that. So it's *trying* to respect the work area, it just can't improve its position because the work area is too small. A ScrollView was added for the profile menu as part of Issue 869343 That's probably the right fix here. I can't think of a better way to ensure this dialog fits in screen. There will always be pathological that don't fit, even without the magnifier. E.g. websites that have a ton of permissions, or a lot of things that are administrator-controlled (see attached).
,
Oct 9
Given that nothing will actually fit into "so_tiny.png", do we need a system wide fix or do we just shrug it off?
,
Oct 10
I cheated a bit in `so_tiny.png` :). The keyboard is an overlay now - it shouldn't restrict the work area. There's also a floating on-screen-keyboard now, so I wouldn't worry too much about it.
,
Oct 15
,
Nov 12
Assigning to cthomp for further triage. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by pbos@chromium.org
, Oct 8